From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.7 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id F2151C2D0DB for ; Mon, 27 Jan 2020 22:45:53 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id D1F7524656 for ; Mon, 27 Jan 2020 22:45:53 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726327AbgA0Wpw (ORCPT ); Mon, 27 Jan 2020 17:45:52 -0500 Received: from relay8-d.mail.gandi.net ([217.70.183.201]:34871 "EHLO relay8-d.mail.gandi.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726101AbgA0Wpv (ORCPT ); Mon, 27 Jan 2020 17:45:51 -0500 X-Originating-IP: 90.65.92.102 Received: from localhost (lfbn-lyo-1-1913-102.w90-65.abo.wanadoo.fr [90.65.92.102]) (Authenticated sender: alexandre.belloni@bootlin.com) by relay8-d.mail.gandi.net (Postfix) with ESMTPSA id 5EC431BF204; Mon, 27 Jan 2020 22:45:49 +0000 (UTC) Date: Mon, 27 Jan 2020 23:45:49 +0100 From: Alexandre Belloni To: Geert Uytterhoeven Cc: Alessandro Zummo , Akinobu Mita , Joe Perches , linux-rtc@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] rtc: i2c/spi: Avoid inclusion of REGMAP support when not needed Message-ID: <20200127224549.GC3273@piout.net> References: <20200112171349.22268-1-geert@linux-m68k.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200112171349.22268-1-geert@linux-m68k.org> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 12/01/2020 18:13:49+0100, Geert Uytterhoeven wrote: > Merely enabling I2C and RTC selects REGMAP_I2C and REGMAP_SPI, even when > no driver needs it. While the former can be moduler, the latter cannot, > and thus becomes built-in. > > Fix this by moving the select statements for REGMAP_I2C and REGMAP_SPI > from the RTC_I2C_AND_SPI helper to the individual drivers that depend on > it. > > Note that the comment for RTC_I2C_AND_SPI refers to SND_SOC_I2C_AND_SPI > for more information, but the latter does not select REGMAP_{I2C,SPI} > itself, and defers that to the individual drivers, too. > > Fixes: 080481f54ef62121 ("rtc: merge ds3232 and ds3234") > Signed-off-by: Geert Uytterhoeven > --- > Joe: When merging addresses, scripts/get_maintainer.pl replaces > Alexandre's authoritative email address from MAINTAINERS by the > obsolete address in the SoB-line of the commit referred to by the > Fixes-line. > > drivers/rtc/Kconfig | 8 ++++++-- > 1 file changed, 6 insertions(+), 2 deletions(-) > Applied, thanks. -- Alexandre Belloni, Bootlin Embedded Linux and Kernel engineering https://bootlin.com