linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Sudeep Holla <sudeep.holla@arm.com>
To: Peng Fan <peng.fan@nxp.com>
Cc: Etienne Carriere <etienne.carriere@linaro.org>,
	"f.fainelli@gmail.com" <f.fainelli@gmail.com>,
	"andre.przywara@arm.com" <andre.przywara@arm.com>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	etienne carriere <etienne.carriere@st.com>,
	Sudeep Holla <sudeep.holla@arm.com>
Subject: Re: [PATCH v11 2/2] mailbox: introduce ARM SMC based mailbox
Date: Tue, 28 Jan 2020 11:38:21 +0000	[thread overview]
Message-ID: <20200128113821.GA36168@bogus> (raw)
In-Reply-To: <AM0PR04MB448137850D19BADD11F75B18880B0@AM0PR04MB4481.eurprd04.prod.outlook.com>

On Mon, Jan 27, 2020 at 12:58:12PM +0000, Peng Fan wrote:
> > Subject: Re: [PATCH v11 2/2] mailbox: introduce ARM SMC based mailbox
> >
> > Hello Peng and all,
> > > From: Peng Fan <peng.fan@nxp.com>
> > >
> > > This mailbox driver implements a mailbox which signals transmitted
> > > data via an ARM smc (secure monitor call) instruction. The mailbox
> > > receiver is implemented in firmware and can synchronously return data
> > > when it returns execution to the non-secure world again.
> > > An asynchronous receive path is not implemented.
> > > This allows the usage of a mailbox to trigger firmware actions on SoCs
> > > which either don't have a separate management processor or on which
> > > such a core is not available. A user of this mailbox could be the SCP
> > > interface.
> > >

[...]

> > I've successfully tested your change on my board. It is a stm32mp1 with TZ
> > secure hardening and I run an OP-TEE firmware (possibly a TF-A
> > sp_min) with a SCMI server for clock and reset. Upstream in progress.
> > The platform uses 2 instances of your SMC based mailbox device driver
> > (2 mailboxes). Works nice with your change.
> >
> > You can add my T-b tag: Tested-by: Etienne Carriere
> > <etienne.carriere@linaro.org>
>
> Thanks, but this patch has been dropped.
>
> Per Sudeep, we all use smc transport, not smc mailbox ,
>
Yes, I asked if there are any other users of SMC mailbox other than
SCMI. We are planning to separate the transport from the SCMI driver[1]
to enable transport other than mailbox. SMC can be one of them and the
other one planned is virtio. Please feel free to add to the discussion
or review.

--
Regards,
Sudeep

[1] https://lore.kernel.org/lkml/f170b33989b426ac095952634fcd1bf45b86a7a3.1580208329.git.viresh.kumar@linaro.org

  reply	other threads:[~2020-01-28 11:38 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <CAN5uoS_YyPXiqZnNfM32cxeAsK+xuPX9QRK94-DJ6oMQFrZPXQ@mail.gmail.com>
2020-01-22 18:20 ` [PATCH v11 2/2] mailbox: introduce ARM SMC based mailbox Etienne Carriere
2020-01-27 12:58   ` Peng Fan
2020-01-28 11:38     ` Sudeep Holla [this message]
2020-01-29 15:01     ` Etienne Carriere
2020-01-29 16:40       ` Sudeep Holla
2019-12-02 10:14 [PATCH v11 0/2] mailbox: arm: introduce smc triggered mailbox Peng Fan
2019-12-02 10:14 ` [PATCH v11 2/2] mailbox: introduce ARM SMC based mailbox Peng Fan
2019-12-03 11:46   ` Sudeep Holla
2019-12-05  3:24     ` Peng Fan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200128113821.GA36168@bogus \
    --to=sudeep.holla@arm.com \
    --cc=andre.przywara@arm.com \
    --cc=etienne.carriere@linaro.org \
    --cc=etienne.carriere@st.com \
    --cc=f.fainelli@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=peng.fan@nxp.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).