From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6D655C2D0DB for ; Tue, 28 Jan 2020 14:08:21 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 397B624685 for ; Tue, 28 Jan 2020 14:08:21 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1580220501; bh=4eb2e5LZ/M4EqtQ4OCwwTDlswK2tPEHlEvGxJ28JyoY=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=CM5M4mstn7WKNGDAmzDGf1PCnZsDbXGj7471WQy1PXwCgsvdrbfRGpDa5YvmPsvaD pYDQdVtAsym9ABo0JaKHt1NxyE7EvN+xBq8Ak7B+FiahfoHlpTztM+Ek6N4jUVOym7 qBfF/DlpGWl08P6Pjq4FuOw2FAkDy82YUN+krkS8= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728468AbgA1OIU (ORCPT ); Tue, 28 Jan 2020 09:08:20 -0500 Received: from mail.kernel.org ([198.145.29.99]:56264 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728431AbgA1OIR (ORCPT ); Tue, 28 Jan 2020 09:08:17 -0500 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 6146424685; Tue, 28 Jan 2020 14:08:16 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1580220496; bh=4eb2e5LZ/M4EqtQ4OCwwTDlswK2tPEHlEvGxJ28JyoY=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=EeQv3QuZN6r2PiMbu4ZmZiSP586CYR4cT1Rn/pqRepgQU/xZzJHh4ILthWg1dtWyF vpjjbAo6IhcwhAhIRCJQMpg3WZD4ku+eamgGGQZU0bfwR11WTtZLTJ0cceIf3rGXm5 v8evT32EVsVSJvfifBTEpvBd14GRE7jqpexiFqEQ= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Jakub Kicinski , Lorenzo Bianconi , Kalle Valo Subject: [PATCH 4.4 003/183] mt7601u: fix bbp version check in mt7601u_wait_bbp_ready Date: Tue, 28 Jan 2020 15:03:42 +0100 Message-Id: <20200128135829.878390275@linuxfoundation.org> X-Mailer: git-send-email 2.25.0 In-Reply-To: <20200128135829.486060649@linuxfoundation.org> References: <20200128135829.486060649@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Lorenzo Bianconi commit 15e14f76f85f4f0eab3b8146e1cd3c58ce272823 upstream. Fix bbp ready check in mt7601u_wait_bbp_ready. The issue is reported by coverity with the following error: Logical vs. bitwise operator The expression's value does not depend on the operands; inadvertent use of the wrong operator is a likely logic error. Addresses-Coverity-ID: 1309441 ("Logical vs. bitwise operator") Fixes: c869f77d6abb ("add mt7601u driver") Acked-by: Jakub Kicinski Signed-off-by: Lorenzo Bianconi Signed-off-by: Kalle Valo Signed-off-by: Greg Kroah-Hartman --- drivers/net/wireless/mediatek/mt7601u/phy.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- a/drivers/net/wireless/mediatek/mt7601u/phy.c +++ b/drivers/net/wireless/mediatek/mt7601u/phy.c @@ -219,7 +219,7 @@ int mt7601u_wait_bbp_ready(struct mt7601 do { val = mt7601u_bbp_rr(dev, MT_BBP_REG_VERSION); - if (val && ~val) + if (val && val != 0xff) break; } while (--i);