From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8F4B7C2D0DB for ; Tue, 28 Jan 2020 14:14:09 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 4FE0C2468A for ; Tue, 28 Jan 2020 14:14:09 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1580220849; bh=kamDQK9A5zrXLCdRehDMgthjQzWeLGZUCFjjdF4or9g=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=kS5Poo9P3gL2k38yxuLL7RHxBee2f9jOplFqK/HxMPw9pfiXidancm/KuTDeDu9/h 2OZZxSOZxYZKS0WPXNQ0ae/NCxaA7s6GDDXw7poO5CuIoCeps1bQus4jMRkbqddMWn 6c2oUia/spWgmahyqlhRM51UPAu8be5R5xRVTU/E= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729822AbgA1OOI (ORCPT ); Tue, 28 Jan 2020 09:14:08 -0500 Received: from mail.kernel.org ([198.145.29.99]:36030 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729803AbgA1OOG (ORCPT ); Tue, 28 Jan 2020 09:14:06 -0500 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 36D7E2468A; Tue, 28 Jan 2020 14:14:05 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1580220845; bh=kamDQK9A5zrXLCdRehDMgthjQzWeLGZUCFjjdF4or9g=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=Z4+SPe6DjySIRFwlkCEE7Wxp950YCXcIpLhvk/8Is2oKE4wJ3MB9kIC7fICYbSf6O m94w+TGUOQWp4I8KbVvtN3aVD6wiFfCp/7KjJGOFW82X67jPW9iMNSQLTYz1u5eZBw yJT6cqtXB9YsN8PvbkUl4H12UkgBYVeZch2HOPf8= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Johan Hovold , Vladis Dronov , Dmitry Torokhov Subject: [PATCH 4.4 170/183] Input: sur40 - fix interface sanity checks Date: Tue, 28 Jan 2020 15:06:29 +0100 Message-Id: <20200128135846.736875933@linuxfoundation.org> X-Mailer: git-send-email 2.25.0 In-Reply-To: <20200128135829.486060649@linuxfoundation.org> References: <20200128135829.486060649@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Johan Hovold commit 6b32391ed675827f8425a414abbc6fbd54ea54fe upstream. Make sure to use the current alternate setting when verifying the interface descriptors to avoid binding to an invalid interface. This in turn could cause the driver to misbehave or trigger a WARN() in usb_submit_urb() that kernels with panic_on_warn set would choke on. Fixes: bdb5c57f209c ("Input: add sur40 driver for Samsung SUR40 (aka MS Surface 2.0/Pixelsense)") Signed-off-by: Johan Hovold Acked-by: Vladis Dronov Link: https://lore.kernel.org/r/20191210113737.4016-8-johan@kernel.org Signed-off-by: Dmitry Torokhov Signed-off-by: Greg Kroah-Hartman --- drivers/input/touchscreen/sur40.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- a/drivers/input/touchscreen/sur40.c +++ b/drivers/input/touchscreen/sur40.c @@ -496,7 +496,7 @@ static int sur40_probe(struct usb_interf int error; /* Check if we really have the right interface. */ - iface_desc = &interface->altsetting[0]; + iface_desc = interface->cur_altsetting; if (iface_desc->desc.bInterfaceClass != 0xFF) return -ENODEV;