From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A2C32C2D0DB for ; Tue, 28 Jan 2020 14:18:56 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 706F224690 for ; Tue, 28 Jan 2020 14:18:56 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1580221136; bh=ADnRa4oNoXPIoll2MpgGv4g0MHmPBHVYvmPDaUp5uPw=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=WAxOhxR6STrNlgSesXEAH3bqtMfGXrZq2dfO3u7qo6zjSCpSqMExaYrloVjLOrP1v wXZy/yRT91OCKG75Mhj8b/5NpkYf4qXmb7ZksGmdFxmuTuDY6rhdjpxpJbTkGZ+XIo 44Dg8qzKHE6Urfo2H8fLfurdC8ONrhTVGKPnxTx8= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730764AbgA1OSz (ORCPT ); Tue, 28 Jan 2020 09:18:55 -0500 Received: from mail.kernel.org ([198.145.29.99]:43032 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730740AbgA1OSw (ORCPT ); Tue, 28 Jan 2020 09:18:52 -0500 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id B7A292071E; Tue, 28 Jan 2020 14:18:51 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1580221132; bh=ADnRa4oNoXPIoll2MpgGv4g0MHmPBHVYvmPDaUp5uPw=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=LNvtESskIb/LIbIMni20o4KXClmYTI7bgao/jKeAw+V+AizQ2oO3VQodjmZ3YIz+2 r+g75aGKmHCV3gmpRgJxT1MVlYEPejlWa5edO30sgEqgH3uD77fYSLaB0z1ED21KSR gQm33J/1ejJMRa/P9Jlsn8Gkl49XEs48624UjYgU= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Dan Carpenter , Hans Verkuil , Mauro Carvalho Chehab , Sasha Levin Subject: [PATCH 4.9 100/271] media: wl128x: Fix an error code in fm_download_firmware() Date: Tue, 28 Jan 2020 15:04:09 +0100 Message-Id: <20200128135900.040243747@linuxfoundation.org> X-Mailer: git-send-email 2.25.0 In-Reply-To: <20200128135852.449088278@linuxfoundation.org> References: <20200128135852.449088278@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Dan Carpenter [ Upstream commit ef4bb63dc1f7213c08e13f6943c69cd27f69e4a3 ] We forgot to set "ret" on this error path. Fixes: e8454ff7b9a4 ("[media] drivers:media:radio: wl128x: FM Driver Common sources") Signed-off-by: Dan Carpenter Signed-off-by: Hans Verkuil Signed-off-by: Mauro Carvalho Chehab Signed-off-by: Sasha Levin --- drivers/media/radio/wl128x/fmdrv_common.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/drivers/media/radio/wl128x/fmdrv_common.c b/drivers/media/radio/wl128x/fmdrv_common.c index c1457cf466981..db987dda356e0 100644 --- a/drivers/media/radio/wl128x/fmdrv_common.c +++ b/drivers/media/radio/wl128x/fmdrv_common.c @@ -1278,8 +1278,9 @@ static int fm_download_firmware(struct fmdev *fmdev, const u8 *fw_name) switch (action->type) { case ACTION_SEND_COMMAND: /* Send */ - if (fmc_send_cmd(fmdev, 0, 0, action->data, - action->size, NULL, NULL)) + ret = fmc_send_cmd(fmdev, 0, 0, action->data, + action->size, NULL, NULL); + if (ret) goto rel_fw; cmd_cnt++; -- 2.20.1