From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.7 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 94DDEC33CB7 for ; Wed, 29 Jan 2020 10:51:37 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 6738D2064C for ; Wed, 29 Jan 2020 10:51:37 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726605AbgA2Kvg (ORCPT ); Wed, 29 Jan 2020 05:51:36 -0500 Received: from shards.monkeyblade.net ([23.128.96.9]:59218 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726069AbgA2Kvg (ORCPT ); Wed, 29 Jan 2020 05:51:36 -0500 Received: from localhost (unknown [IPv6:2001:982:756:1:57a7:3bfd:5e85:defb]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) (Authenticated sender: davem-davemloft) by shards.monkeyblade.net (Postfix) with ESMTPSA id A09B015C045A5; Wed, 29 Jan 2020 02:51:33 -0800 (PST) Date: Wed, 29 Jan 2020 11:51:31 +0100 (CET) Message-Id: <20200129.115131.1101786807458791369.davem@davemloft.net> To: christophe.roullier@st.com Cc: joabreu@synopsys.com, mcoquelin.stm32@gmail.com, alexandre.torgue@st.com, peppe.cavallaro@st.com, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-stm32@st-md-mailman.stormreply.com, netdev@vger.kernel.org Subject: Re: [PATCH 1/1] net: ethernet: stmmac: simplify phy modes management for stm32 From: David Miller In-Reply-To: <20200128083942.17823-1-christophe.roullier@st.com> References: <20200128083942.17823-1-christophe.roullier@st.com> X-Mailer: Mew version 6.8 on Emacs 26.3 Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Wed, 29 Jan 2020 02:51:35 -0800 (PST) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Christophe Roullier Date: Tue, 28 Jan 2020 09:39:42 +0100 > No new feature, just to simplify stm32 part to be easier to use. > Add by default all Ethernet clocks in DT, and activate or not in function > of phy mode, clock frequency, if property "st,ext-phyclk" is set or not. > Keep backward compatibility > ----------------------------------------------------------------------- > |PHY_MODE | Normal | PHY wo crystal| PHY wo crystal | No 125Mhz | > | | | 25MHz | 50MHz | from PHY | > ----------------------------------------------------------------------- > | MII | - | eth-ck | n/a | n/a | > | | | st,ext-phyclk | | | > ----------------------------------------------------------------------- > | GMII | - | eth-ck | n/a | n/a | > | | | st,ext-phyclk | | | > ----------------------------------------------------------------------- > | RGMII | - | eth-ck | n/a | eth-ck | > | | | st,ext-phyclk | |st,eth-clk-sel| > | | | | | or | > | | | | | st,ext-phyclk| > ------------------------------------------------------------------------ > | RMII | - | eth-ck | eth-ck | n/a | > | | | st,ext-phyclk | st,eth-ref-clk-sel | | > | | | | or st,ext-phyclk | | > ------------------------------------------------------------------------ > > Signed-off-by: Christophe Roullier If anything, this is more of a cleanup, and therefore only appropriate for net-next when it opens back up.