From: Steven Rostedt <rostedt@goodmis.org>
To: Tom Zanussi <zanussi@kernel.org>
Cc: mhiramat@kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 4/4] tracing: Add new testcases for hist trigger parsing errors
Date: Wed, 29 Jan 2020 09:22:00 -0500 [thread overview]
Message-ID: <20200129092200.2200db5e@gandalf.local.home> (raw)
In-Reply-To: <62ec58d9aca661cde46ba678e32a938427945e9e.1561743018.git.zanussi@kernel.org>
On Fri, 28 Jun 2019 12:40:23 -0500
Tom Zanussi <zanussi@kernel.org> wrote:
> Add a testcase ensuring that the tracing error_log correctly displays
> hist trigger parsing errors.
Hi Tom,
I noticed that I never applied these patches (just did), but I also
notice that this test case fails.
Can you have a look on my ftrace/core branch:
git://git.kernel.org/pub/scm/linux/kernel/git/rostedt/linux-trace.git
Thanks,
-- Steve
>
> Signed-off-by: Tom Zanussi <zanussi@kernel.org>
> Reviewed-by: Masami Hiramatsu <mhiramat@kernel.org>
> ---
> .../test.d/trigger/trigger-hist-syntax-errors.tc | 32 ++++++++++++++++++++++
> 1 file changed, 32 insertions(+)
> create mode 100644 tools/testing/selftests/ftrace/test.d/trigger/trigger-hist-syntax-errors.tc
>
> diff --git a/tools/testing/selftests/ftrace/test.d/trigger/trigger-hist-syntax-errors.tc b/tools/testing/selftests/ftrace/test.d/trigger/trigger-hist-syntax-errors.tc
> new file mode 100644
> index 000000000000..d44087a2f3d1
> --- /dev/null
> +++ b/tools/testing/selftests/ftrace/test.d/trigger/trigger-hist-syntax-errors.tc
> @@ -0,0 +1,32 @@
> +#!/bin/sh
> +# SPDX-License-Identifier: GPL-2.0
> +# description: event trigger - test histogram parser errors
> +
> +if [ ! -f set_event -o ! -d events/kmem ]; then
> + echo "event tracing is not supported"
> + exit_unsupported
> +fi
> +
> +if [ ! -f events/kmem/kmalloc/trigger ]; then
> + echo "event trigger is not supported"
> + exit_unsupported
> +fi
> +
> +if [ ! -f events/kmem/kmalloc/hist ]; then
> + echo "hist trigger is not supported"
> + exit_unsupported
> +fi
> +
> +[ -f error_log ] || exit_unsupported
> +
> +check_error() { # command-with-error-pos-by-^
> + ftrace_errlog_check 'hist:kmem:kmalloc' "$1" 'events/kmem/kmalloc/trigger'
> +}
> +
> +check_error 'hist:keys=common_pid:vals=bytes_req:sort=common_pid,^junk' # INVALID_SORT_FIELD
> +check_error 'hist:keys=common_pid:vals=bytes_req:^sort=' # EMPTY_ASSIGNMENT
> +check_error 'hist:keys=common_pid:vals=bytes_req:^sort=common_pid,' # EMPTY_SORT_FIELD
> +check_error 'hist:keys=common_pid:vals=bytes_req:sort=common_pid.^junk' # INVALID_SORT_MODIFIER
> +check_error 'hist:keys=common_pid:vals=bytes_req,bytes_alloc:^sort=common_pid,bytes_req,bytes_alloc' # TOO_MANY_SORT_FIELDS
> +
> +exit 0
next prev parent reply other threads:[~2020-01-29 14:22 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-28 17:40 [PATCH v2 0/4] tracing: Improve error messages for histogram sorting Tom Zanussi
2019-06-28 17:40 ` [PATCH v2 1/4] tracing: Simplify assignment parsing for hist triggers Tom Zanussi
2019-06-28 17:40 ` [PATCH v2 2/4] tracing: Add hist trigger error messages for sort specification Tom Zanussi
2019-06-28 17:40 ` [PATCH v2 3/4] tracing: Add 'hist:' to hist trigger error log error string Tom Zanussi
2019-06-28 17:40 ` [PATCH v2 4/4] tracing: Add new testcases for hist trigger parsing errors Tom Zanussi
2020-01-29 14:22 ` Steven Rostedt [this message]
2020-01-29 14:44 ` Tom Zanussi
2020-01-29 14:53 ` Steven Rostedt
2020-01-29 15:02 ` Steven Rostedt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200129092200.2200db5e@gandalf.local.home \
--to=rostedt@goodmis.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mhiramat@kernel.org \
--cc=zanussi@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).