From: Kent Gibson <warthog618@gmail.com>
To: Bartosz Golaszewski <bgolaszewski@baylibre.com>
Cc: LKML <linux-kernel@vger.kernel.org>,
linux-gpio <linux-gpio@vger.kernel.org>,
Linus Walleij <linus.walleij@linaro.org>
Subject: Re: [PATCH] gpiolib: remove unnecessary argument from set_config call
Date: Wed, 29 Jan 2020 20:33:49 +0800 [thread overview]
Message-ID: <20200129123349.GA3801@sol> (raw)
In-Reply-To: <CAMpxmJWCwtnuB4T3_no59cVvPS5gy6QwOBV3i4FU4N6hmYugEw@mail.gmail.com>
On Wed, Jan 29, 2020 at 11:55:49AM +0100, Bartosz Golaszewski wrote:
> pon., 20 sty 2020 o 11:46 Kent Gibson <warthog618@gmail.com> napisał(a):
> >
> > Remove unnecessary argument when setting PIN_CONFIG_BIAS_DISABLE.
> >
> > Fixes: 2148ad7790ea ("gpiolib: add support for disabling line bias")
> > Signed-off-by: Kent Gibson <warthog618@gmail.com>
> > ---
> >
> > No argument is expected by pinctrl, so removing it should be harmless.
> >
>
> This doesn't really fix any bug, does it? If not, then I'll just take
> it for v5.7 after the merge window.
>
This is just fixing what I suspect was a cut-and-paste error on my part
that wasn't picked up during review - until I had a closer look
following Geert and Andy's recent comments on some of your proposed
changes. So it is just a tidy up.
It could only a problem if a pinctrl is making use of the unnecessary
argument, and there are no such pinctrls that I am aware of.
Merge it in whenever it is convenient.
Cheers,
Kent.
next prev parent reply other threads:[~2020-01-29 12:33 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-20 10:46 [PATCH] gpiolib: remove unnecessary argument from set_config call Kent Gibson
2020-01-29 10:55 ` Bartosz Golaszewski
2020-01-29 12:33 ` Kent Gibson [this message]
2020-02-04 10:04 ` Bartosz Golaszewski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200129123349.GA3801@sol \
--to=warthog618@gmail.com \
--cc=bgolaszewski@baylibre.com \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).