From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.3 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D2461C35240 for ; Wed, 29 Jan 2020 20:58:02 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id A13EB206F0 for ; Wed, 29 Jan 2020 20:58:02 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="PRZU97PR" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727349AbgA2U6C (ORCPT ); Wed, 29 Jan 2020 15:58:02 -0500 Received: from mail-pl1-f193.google.com ([209.85.214.193]:43759 "EHLO mail-pl1-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726317AbgA2U6B (ORCPT ); Wed, 29 Jan 2020 15:58:01 -0500 Received: by mail-pl1-f193.google.com with SMTP id p11so419670plq.10 for ; Wed, 29 Jan 2020 12:58:01 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=jVwFmM58w1zHs+XafhdEQFNB4s0oGwhSx+Pn9dwldcI=; b=PRZU97PRqnm73JIII01dZ49nIQXFrspjmbF29YkkWK8b+aKkdm0uP/PcQ9981eA1Fh c66ONz+/Gd2UvfhN/ElMSbFqPnL7PtXcR8h9Jxwuka+dbeTDYgkEAp8MeqeYffUYY8GP dUD8b2HscFlLLpQzVmVD+mfCN1PZTlhpuLM8E= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=jVwFmM58w1zHs+XafhdEQFNB4s0oGwhSx+Pn9dwldcI=; b=BF3JEuq6Ubks5nK5Cf6N4b39R8itfePpNEy2uFM3JlNRbjQn8IuHlarvqyhfo68ij1 ovp2bzYBIns2N5oJ7MuNFqPTbuZ64aRu1TkmN0iBSDHXnOjCv8DI1YzaBV+iRJl8bWKh CYcvH1V0kMSOrPbZsqpYiBekb3tdiAIjH/K8bWa6jfolO9xImGQkR4ArGifaUWvIMXfa G+Fus/T2nAKb1cnBrO9vVo9UMz0ZcKkbI9AoDHoix08BjzPzAR63jXRfDns+WWCPMalX fvAenibJXvZjR0hj3YZwB7I8K6YDFtXa4sNCo/DsRM4uN8YkMLn70TO/svZYvmTYRDdR A3Yw== X-Gm-Message-State: APjAAAUYeTvNb7FuE8wZyr8v6SpW6HlRNempj7LET1hZfcqIWQlemAzH j908VsqD1Jb7fq3HKBIyEMkTaQ== X-Google-Smtp-Source: APXvYqwNtiXzzLg4SLXJKSkiyJjN0kLcfzIyIyuX83IM53TcVqy5QuZ0vy4d4Jm9zj7z8nf1NMVpGA== X-Received: by 2002:a17:90a:c705:: with SMTP id o5mr1693055pjt.67.1580331480603; Wed, 29 Jan 2020 12:58:00 -0800 (PST) Received: from localhost ([2620:15c:202:1:4fff:7a6b:a335:8fde]) by smtp.gmail.com with ESMTPSA id 2sm3560307pgo.79.2020.01.29.12.57.59 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 29 Jan 2020 12:58:00 -0800 (PST) Date: Wed, 29 Jan 2020 12:57:59 -0800 From: Matthias Kaehlcke To: Sandeep Maheswaram Cc: Andy Gross , Bjorn Andersson , Kishon Vijay Abraham I , Rob Herring , Mark Rutland , Stephen Boyd , Doug Anderson , linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org Subject: Re: [PATCH v4 1/8] dt-bindings: phy: qcom,qusb2: Convert QUSB2 phy bindings to yaml Message-ID: <20200129205759.GG71044@google.com> References: <1580305919-30946-1-git-send-email-sanm@codeaurora.org> <1580305919-30946-2-git-send-email-sanm@codeaurora.org> <20200129202820.GC71044@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20200129202820.GC71044@google.com> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Jan 29, 2020 at 12:28:20PM -0800, Matthias Kaehlcke wrote: > On Wed, Jan 29, 2020 at 07:21:52PM +0530, Sandeep Maheswaram wrote: > > Convert QUSB2 phy bindings to DT schema format using json-schema. > > > > Signed-off-by: Sandeep Maheswaram > > --- > > .../devicetree/bindings/phy/qcom,qusb2-phy.yaml | 142 +++++++++++++++++++++ > > .../devicetree/bindings/phy/qcom-qusb2-phy.txt | 68 ---------- > > 2 files changed, 142 insertions(+), 68 deletions(-) > > create mode 100644 Documentation/devicetree/bindings/phy/qcom,qusb2-phy.yaml > > delete mode 100644 Documentation/devicetree/bindings/phy/qcom-qusb2-phy.txt > > > > diff --git a/Documentation/devicetree/bindings/phy/qcom,qusb2-phy.yaml b/Documentation/devicetree/bindings/phy/qcom,qusb2-phy.yaml > > new file mode 100644 > > index 0000000..90b3cc6 > > --- /dev/null > > +++ b/Documentation/devicetree/bindings/phy/qcom,qusb2-phy.yaml > > @@ -0,0 +1,142 @@ > > +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause) > > + > > +%YAML 1.2 > > +--- > > +$id: "http://devicetree.org/schemas/phy/qcom,qusb2-phy.yaml#" > > +$schema: "http://devicetree.org/meta-schemas/core.yaml#" > > + > > +title: Qualcomm QUSB2 phy controller > > + > > +maintainers: > > + - Manu Gautam > > + > > +description: > > + QUSB2 controller supports LS/FS/HS usb connectivity on Qualcomm chipsets. > > + > > +properties: > > + compatible: > > + enum: > > + - qcom,msm8996-qusb2-phy > > + - qcom,msm8998-qusb2-phy > > + - qcom,sdm845-qusb2-phy > > + reg: > > + maxItems: 1 > > + > > + "#phy-cells": > > + const: 0 > > + > > + clocks: > > + minItems: 2 > > + items: > > + - description: phy config clock > > + - description: 19.2 MHz ref clk > > + - description: phy interface clock (Optional) > > + > > + clock-names: > > + minItems: 2 > > + items: > > + - const: cfg_ahb > > + - const: ref > > + - const: iface > > + > > + vdda-pll-supply: > > + description: > > + Phandle to 1.8V regulator supply to PHY refclk pll block. > > + > > + vdda-phy-dpdm-supply: > > + description: > > + Phandle to 3.1V regulator supply to Dp/Dm port signals. > > + > > + resets: > > + maxItems: 1 > > + > > + nvmem-cells: > > + maxItems: 1 > > + description: > > + Phandle to nvmem cell that contains 'HS Tx trim' > > + tuning parameter value for qusb2 phy. > > + > > + qcom,tcsr-syscon: > > + description: > > + Phandle to TCSR syscon register region. > > + $ref: /schemas/types.yaml#/definitions/cell > > + > > + qcom,imp-res-offset-value: > > + description: > > + It is a 6 bit value that specifies offset to be > > + added to PHY refgen RESCODE via IMP_CTRL1 register. It is a PHY > > + tuning parameter that may vary for different boards of same SOC. > > + This property is applicable to only QUSB2 v2 PHY. > > + allOf: > > + - $ref: /schemas/types.yaml#/definitions/uint32 > > + - minimum: 0 > > + maximum: 63 > > + default: 0 > > + > > + qcom,hstx-trim-value: > > + description: > > + It is a 4 bit value that specifies tuning for HSTX > > + output current. > > + Possible range is - 15mA to 24mA (stepsize of 600 uA). > > + See dt-bindings/phy/phy-qcom-qusb2.h for applicable values. > > + This property is applicable to only QUSB2 v2 PHY. > > + allOf: > > + - $ref: /schemas/types.yaml#/definitions/uint32 > > + - minimum: 0 > > + maximum: 15 > > + default: 3 > > + > > + qcom,preemphasis-level: > > + description: > > + It is a 2 bit value that specifies pre-emphasis level. > > + Possible range is 0 to 15% (stepsize of 5%). > > + See dt-bindings/phy/phy-qcom-qusb2.h for applicable values. > > + This property is applicable to only QUSB2 v2 PHY. > > + allOf: > > + - $ref: /schemas/types.yaml#/definitions/uint32 > > + - minimum: 0 > > + maximum: 3 > > + default: 2 > > + > > + qcom,preemphasis-width: > > + description: > > + It is a 1 bit value that specifies how long the HSTX > > + pre-emphasis (specified using qcom,preemphasis-level) must be in > > + effect. Duration could be half-bit of full-bit. > > + See dt-bindings/phy/phy-qcom-qusb2.h for applicable values. > > + This property is applicable to only QUSB2 v2 PHY. > > + allOf: > > + - $ref: /schemas/types.yaml#/definitions/uint32 > > + - minimum: 0 > > + maximum: 1 > > + default: 0 > > + > > +required: > > + - compatible > > + - reg > > + - "#phy-cells" > > + - clocks > > + - clock-names > > + - vdda-pll-supply > > + - vdda-phy-dpdm-supply > > + - resets > > + > > + > > +examples: > > + - | > > + #include > > + hsusb_phy: phy@7411000 { > > + compatible = "qcom,msm8996-qusb2-phy"; > > + reg = <0x7411000 0x180>; > > + #phy-cells = <0>; > > + > > + clocks = <&gcc GCC_USB_PHY_CFG_AHB2PHY_CLK>, > > + <&gcc GCC_RX1_USB2_CLKREF_CLK>; > > + clock-names = "cfg_ahb", "ref"; > > + > > + vdda-pll-supply = <&pm8994_l12>; > > + vdda-phy-dpdm-supply = <&pm8994_l24>; > > + > > + resets = <&gcc GCC_QUSB2PHY_PRIM_BCR>; > > + nvmem-cells = <&qusb2p_hstx_trim>; > > + }; > > diff --git a/Documentation/devicetree/bindings/phy/qcom-qusb2-phy.txt b/Documentation/devicetree/bindings/phy/qcom-qusb2-phy.txt > > deleted file mode 100644 > > index fe29f9e..0000000 > > --- a/Documentation/devicetree/bindings/phy/qcom-qusb2-phy.txt > > +++ /dev/null > > @@ -1,68 +0,0 @@ > > -Qualcomm QUSB2 phy controller > > -============================= > > - > > -QUSB2 controller supports LS/FS/HS usb connectivity on Qualcomm chipsets. > > - > > -Required properties: > > - - compatible: compatible list, contains > > - "qcom,msm8996-qusb2-phy" for 14nm PHY on msm8996, > > - "qcom,msm8998-qusb2-phy" for 10nm PHY on msm8998, > > - "qcom,sdm845-qusb2-phy" for 10nm PHY on sdm845. > > - > > - - reg: offset and length of the PHY register set. > > - - #phy-cells: must be 0. > > - > > - - clocks: a list of phandles and clock-specifier pairs, > > - one for each entry in clock-names. > > - - clock-names: must be "cfg_ahb" for phy config clock, > > - "ref" for 19.2 MHz ref clk, > > - "iface" for phy interface clock (Optional). > > - > > - - vdda-pll-supply: Phandle to 1.8V regulator supply to PHY refclk pll block. > > - - vdda-phy-dpdm-supply: Phandle to 3.1V regulator supply to Dp/Dm port signals. > > - > > - - resets: Phandle to reset to phy block. > > - > > -Optional properties: > > - - nvmem-cells: Phandle to nvmem cell that contains 'HS Tx trim' > > - tuning parameter value for qusb2 phy. > > - > > - - qcom,tcsr-syscon: Phandle to TCSR syscon register region. > > - - qcom,imp-res-offset-value: It is a 6 bit value that specifies offset to be > > - added to PHY refgen RESCODE via IMP_CTRL1 register. It is a PHY > > - tuning parameter that may vary for different boards of same SOC. > > - This property is applicable to only QUSB2 v2 PHY (sdm845). > > - - qcom,hstx-trim-value: It is a 4 bit value that specifies tuning for HSTX > > - output current. > > - Possible range is - 15mA to 24mA (stepsize of 600 uA). > > - See dt-bindings/phy/phy-qcom-qusb2.h for applicable values. > > - This property is applicable to only QUSB2 v2 PHY (sdm845). > > - Default value is 22.2mA for sdm845. > > - - qcom,preemphasis-level: It is a 2 bit value that specifies pre-emphasis level. > > - Possible range is 0 to 15% (stepsize of 5%). > > - See dt-bindings/phy/phy-qcom-qusb2.h for applicable values. > > - This property is applicable to only QUSB2 v2 PHY (sdm845). > > - Default value is 10% for sdm845. > > -- qcom,preemphasis-width: It is a 1 bit value that specifies how long the HSTX > > - pre-emphasis (specified using qcom,preemphasis-level) must be in > > - effect. Duration could be half-bit of full-bit. > > - See dt-bindings/phy/phy-qcom-qusb2.h for applicable values. > > - This property is applicable to only QUSB2 v2 PHY (sdm845). > > - Default value is full-bit width for sdm845. > > - > > -Example: > > - hsusb_phy: phy@7411000 { > > - compatible = "qcom,msm8996-qusb2-phy"; > > - reg = <0x7411000 0x180>; > > - #phy-cells = <0>; > > - > > - clocks = <&gcc GCC_USB_PHY_CFG_AHB2PHY_CLK>, > > - <&gcc GCC_RX1_USB2_CLKREF_CLK>, > > - clock-names = "cfg_ahb", "ref"; > > - > > - vdda-pll-supply = <&pm8994_l12>; > > - vdda-phy-dpdm-supply = <&pm8994_l24>; > > - > > - resets = <&gcc GCC_QUSB2PHY_PRIM_BCR>; > > - nvmem-cells = <&qusb2p_hstx_trim>; > > - }; > > Reviewed-by: Matthias Kaehlcke This second 'Reviewed-by' was actually intended for '[v4 2/8] dt-bindings: phy: qcom,qusb2: Add compatibles for QUSB2 V2 phy and SC7180'. I replied to the wrong mail after reviewing on patchwork.