From: Sudeep Holla <sudeep.holla@arm.com>
To: Viresh Kumar <viresh.kumar@linaro.org>
Cc: Etienne Carriere <etienne.carriere@linaro.org>,
linux-kernel@vger.kernel.org, Peng Fan <peng.fan@nxp.com>,
Sudeep Holla <sudeep.holla@arm.com>
Subject: Re: [PATCH V5] firmware: arm_scmi: Make scmi core independent of the transport type
Date: Thu, 30 Jan 2020 10:21:04 +0000 [thread overview]
Message-ID: <20200130102104.GA48466@bogus> (raw)
In-Reply-To: <20200130094103.mrz7ween6ukfa4fk@vireshk-i7>
On Thu, Jan 30, 2020 at 03:11:03PM +0530, Viresh Kumar wrote:
> On 30-01-20, 10:25, Etienne Carriere wrote:
> > I've made a first port (draft) for adding new transport channels, next
> > to existing mailbox channel, on top of your change.
> > You can find it here: https://github.com/etienne-lms/linux/pull/1.
> >
> > I don't have specific comments on your change but the one below.
> > I think SMT header should move out of mailbox.c, but that may be a bit
> > out of the scope of your change.
>
> If it is guaranteed that someone will end up using those routines
> apart from mailbox.c, then surely it can be done.
>
I thought about it and decided to take up when we add new transport
instead of doing now and having to redo again when we add new transport
mostly SMC/HVC.
> > I would prefer an optional mak_txdone callback:
> >
> > if (info->desc->ops->mark_txdone)
> > info->desc->ops->mark_txdone(cinfo, ret);
>
> So you are sure that mark_txdone won't be required in your case? I can
> make it optional then.
>
Yes this can be done. Might even help virtio and keeps Peter happy :)
--
Regards,
Sudeep
next prev parent reply other threads:[~2020-01-30 10:21 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-30 9:25 [PATCH V5] firmware: arm_scmi: Make scmi core independent of the transport type Etienne Carriere
2020-01-30 9:41 ` Viresh Kumar
2020-01-30 10:21 ` Sudeep Holla [this message]
2020-01-30 16:24 ` Etienne Carriere
-- strict thread matches above, loose matches on Subject: below --
2020-01-28 10:54 Viresh Kumar
2020-01-28 17:35 ` Sudeep Holla
2020-01-30 11:58 ` Peter Hilber
2020-01-31 4:33 ` Viresh Kumar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200130102104.GA48466@bogus \
--to=sudeep.holla@arm.com \
--cc=etienne.carriere@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=peng.fan@nxp.com \
--cc=viresh.kumar@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).