From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.1 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D6C0EC35240 for ; Thu, 30 Jan 2020 22:14:51 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id A075820CC7 for ; Thu, 30 Jan 2020 22:14:51 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1580422491; bh=Hh04uXBi7OcIx5ozha/taPqwFRcX5aRWOqzIboXiuHU=; h=Date:From:To:Cc:Subject:In-Reply-To:References:List-ID:From; b=VkIcZsIVXEJ73v54XoGa1m6p27ZrFcuoN9k9NMoSApP14Zig4I7GVgW3KviWRHOuU lPybZwmXBtohEyKfcSQbWaBFdTPOvaOetSLgDWpLatJFhoKzkimJhDUVd1lPcj3CM8 Zv4FtRYJw/4Wmz6FpWf9bd4wiDRGOkIqv9gAZJEk= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726239AbgA3WOv (ORCPT ); Thu, 30 Jan 2020 17:14:51 -0500 Received: from mail.kernel.org ([198.145.29.99]:38972 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725907AbgA3WOu (ORCPT ); Thu, 30 Jan 2020 17:14:50 -0500 Received: from cakuba (unknown [199.201.64.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 9273620707; Thu, 30 Jan 2020 22:14:49 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1580422489; bh=Hh04uXBi7OcIx5ozha/taPqwFRcX5aRWOqzIboXiuHU=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=s9ACRgpQmFHVWcx5jc0K+lNdf539SserYwTzfbdVUaTUnC72bjHFmygCrnuZfE5YA Fq2wn2udDI8nOuRa0iIxQqUBuI0H5aIv4+vAlGbBnR5UQ41+QE7ALfD8/n9YpQb9oa yxbZaXU5dQF8EM3PF6N4Qp57ZJ8F5vD3Mrf60/Ok= Date: Thu, 30 Jan 2020 14:14:48 -0800 From: Jakub Kicinski To: Pablo Neira Ayuso Cc: Matteo Croce , netdev@vger.kernel.org, linux-doc@vger.kernel.org, "David S. Miller" , Florian Westphal , linux-kernel@vger.kernel.org Subject: Re: [PATCH net] netfilter: nf_flowtable: fix documentation Message-ID: <20200130141448.27fa32aa@cakuba> In-Reply-To: <20200130191019.19440-1-mcroce@redhat.com> References: <20200130191019.19440-1-mcroce@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 30 Jan 2020 20:10:19 +0100, Matteo Croce wrote: > In the flowtable documentation there is a missing semicolon, the command > as is would give this error: > > nftables.conf:5:27-33: Error: syntax error, unexpected devices, expecting newline or semicolon > hook ingress priority 0 devices = { br0, pppoe-data }; > ^^^^^^^ > nftables.conf:4:12-13: Error: invalid hook (null) > flowtable ft { > ^^ > > Fixes: 19b351f16fd9 ("netfilter: add flowtable documentation") > Signed-off-by: Matteo Croce This is netfilter so even though it's tagged as net, I'm expecting Pablo (or Jon) to take it. Please LMK if I'm wrong.