From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_2 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BF1E3C35240 for ; Thu, 30 Jan 2020 16:12:56 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 9F8CF214DB for ; Thu, 30 Jan 2020 16:12:56 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727457AbgA3QM4 (ORCPT ); Thu, 30 Jan 2020 11:12:56 -0500 Received: from bhuna.collabora.co.uk ([46.235.227.227]:44692 "EHLO bhuna.collabora.co.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727158AbgA3QMz (ORCPT ); Thu, 30 Jan 2020 11:12:55 -0500 Received: from localhost (unknown [IPv6:2a01:e0a:2c:6930:5cf4:84a1:2763:fe0d]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: bbrezillon) by bhuna.collabora.co.uk (Postfix) with ESMTPSA id BD536294F23; Thu, 30 Jan 2020 16:12:52 +0000 (GMT) Date: Thu, 30 Jan 2020 17:12:49 +0100 From: Boris Brezillon To: Ezequiel Garcia Cc: linux-media@vger.kernel.org, devicetree@vger.kernel.org, linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org, Laurent Pinchart , Rob Herring , Tomasz Figa , Nicolas Dufresne , kernel@collabora.com, Paul Kocialkowski , Jonas Karlman , Heiko Stuebner , Sakari Ailus , Hans Verkuil Subject: Re: [PATCH v4 5/6] media: rkvdec: Add the rkvdec driver Message-ID: <20200130171249.3ae0444a@collabora.com> In-Reply-To: <20200129195501.8317-6-ezequiel@collabora.com> References: <20200129195501.8317-1-ezequiel@collabora.com> <20200129195501.8317-6-ezequiel@collabora.com> Organization: Collabora X-Mailer: Claws Mail 3.17.4 (GTK+ 2.24.32; x86_64-redhat-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 29 Jan 2020 16:55:00 -0300 Ezequiel Garcia wrote: > From: Boris Brezillon > > The rockchip vdec block is a stateless decoder that's able to decode > H264, HEVC and VP9 content. This commit adds the core infrastructure > and the H264 backend. Support for VP9 and HEVS will be added later on. > > Signed-off-by: Boris Brezillon > Signed-off-by: Ezequiel Garcia > --- > v4: > * Make poc tables const, as suggested by Hans > * Move buffer extra space calculation TRY_FMT, as done on Hantro. > * Get rid of vb2_request_get_buf and open-code > following Cedrus. We can move it to a helper as a follow-up patch. Well, we know what that means in practice :-). > new file mode 100644 > index 000000000000..1293b3621364 > --- /dev/null > +++ b/drivers/staging/media/rkvdec/rkvdec-regs.h > @@ -0,0 +1,239 @@ > +/* SPDX-License-Identifier: GPL-2.0 */ > +/* > + * Rockchip VPU codec driver > + * > + * Copyright (C) 2015 Rockchip Electronics Co., Ltd. > + * Jung Zhao > + * Alpha Lin > + * > + * This software is licensed under the terms of the GNU General Public > + * License version 2, as published by the Free Software Foundation, and > + * may be copied, distributed, and modified under those terms. > + * > + * This program is distributed in the hope that it will be useful, > + * but WITHOUT ANY WARRANTY; without even the implied warranty of > + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the > + * GNU General Public License for more details. > + */ Oops, looks like I forgot to remove the license text here. Also not entirely sure the copyrights are correct (might be a copy from the hantro driver instead of the rkvdec one). > diff --git a/drivers/staging/media/rkvdec/rkvdec.h b/drivers/staging/media/rkvdec/rkvdec.h > new file mode 100644 > index 000000000000..529ef86510d3 > --- /dev/null > +++ b/drivers/staging/media/rkvdec/rkvdec.h > @@ -0,0 +1,124 @@ > +/* SPDX-License-Identifier: GPL-2.0 */ > +/* > + * Hantro VPU codec driver > + * > + * Copyright 2018 Google LLC. > + * Tomasz Figa > + * > + * Based on s5p-mfc driver by Samsung Electronics Co., Ltd. > + * Copyright (C) 2011 Samsung Electronics Co., Ltd. > + */ This header has been copied from the hantro driver, so it's most likely wrong.