From: Stephen Boyd <sboyd@kernel.org>
To: Heiko Stuebner <heiko@sntech.de>, linux-clk@vger.kernel.org
Cc: linux-arm-kernel@lists.infradead.org,
linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org,
mturquette@baylibre.com, heiko@sntech.de,
christoph.muellner@theobroma-systems.com,
zhangqing@rock-chips.com, robin.murphy@arm.com,
Heiko Stuebner <heiko.stuebner@theobroma-systems.com>
Subject: Re: [PATCH v3 1/3] clk: rockchip: convert rk3399 pll type to use readl_poll_timeout
Date: Thu, 30 Jan 2020 09:19:26 -0800 [thread overview]
Message-ID: <20200130171927.C9ECF206F0@mail.kernel.org> (raw)
In-Reply-To: <20200129163821.1547295-1-heiko@sntech.de>
Quoting Heiko Stuebner (2020-01-29 08:38:19)
> From: Heiko Stuebner <heiko.stuebner@theobroma-systems.com>
>
> Instead of open coding the polling of the lock status, use the
> handy readl_poll_timeout for this. As the pll locking is normally
> blazingly fast and we don't want to incur additional delays, we're
> not doing any sleeps similar to for example the imx clk-pllv4
> and define a very safe but still short timeout of 1ms.
>
> Suggested-by: Stephen Boyd <sboyd@kernel.org>
> Signed-off-by: Heiko Stuebner <heiko.stuebner@theobroma-systems.com>
> ---
Reviewed-by: Stephen Boyd <sboyd@kernel.org>
next prev parent reply other threads:[~2020-01-30 17:19 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-29 16:38 [PATCH v3 1/3] clk: rockchip: convert rk3399 pll type to use readl_poll_timeout Heiko Stuebner
2020-01-29 16:38 ` [PATCH v3 2/3] clk: rockchip: convert basic pll lock_wait to use regmap_read_poll_timeout Heiko Stuebner
2020-01-30 17:19 ` Stephen Boyd
2020-01-29 16:38 ` [PATCH v3 3/3] clk: rockchip: convert rk3036 pll type to use internal lock status Heiko Stuebner
2020-01-30 17:19 ` Stephen Boyd
2020-01-30 17:19 ` Stephen Boyd [this message]
2020-02-12 12:04 ` [PATCH v3 1/3] clk: rockchip: convert rk3399 pll type to use readl_poll_timeout Heiko Stuebner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200130171927.C9ECF206F0@mail.kernel.org \
--to=sboyd@kernel.org \
--cc=christoph.muellner@theobroma-systems.com \
--cc=heiko.stuebner@theobroma-systems.com \
--cc=heiko@sntech.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=mturquette@baylibre.com \
--cc=robin.murphy@arm.com \
--cc=zhangqing@rock-chips.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).