From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.1 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B0F53C35240 for ; Thu, 30 Jan 2020 18:08:58 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 81EE220678 for ; Thu, 30 Jan 2020 18:08:58 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1580407738; bh=3W+VaepOQZK1/2OtY04p71hljSuNF5huaq7gghm3Ydc=; h=In-Reply-To:References:Subject:To:From:Cc:Date:List-ID:From; b=fM78lneMojDtDxl+c718C1qQNPlyy9Ix/z+/HUjESHXROVQf3fqv805VY9PRjdx2f Vhd0rADRmunGwG4De0lTF5Tg3lQdaYv4E0E5+RuyOhuRS6lOh/OH0WY6Tb59uWWqNt S61MzCa5CY9Io8ZVcvzh4bvVSa861cZg16zQ2cM4= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728206AbgA3SI5 (ORCPT ); Thu, 30 Jan 2020 13:08:57 -0500 Received: from mail.kernel.org ([198.145.29.99]:38570 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728190AbgA3SI5 (ORCPT ); Thu, 30 Jan 2020 13:08:57 -0500 Received: from kernel.org (unknown [104.132.0.74]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 6B65C20678; Thu, 30 Jan 2020 18:08:56 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1580407736; bh=3W+VaepOQZK1/2OtY04p71hljSuNF5huaq7gghm3Ydc=; h=In-Reply-To:References:Subject:To:From:Cc:Date:From; b=cuGCBO4qLa3QUE7OV1nspLRbwqAqVDYW0sUVqJ6IvhWuakis8yFV1jzEOEsxLAs13 EhnToPmlKjoazvdWTD/nlwpemWiCoeLKYr/wJSjT/dq72LZ86bISAkHv81CgcIiRv8 epMaDzvWAwhxUrtCts0NRsAtir52umiQ54fXCNkw= Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable In-Reply-To: <1580357923-19783-4-git-send-email-tdas@codeaurora.org> References: <1580357923-19783-1-git-send-email-tdas@codeaurora.org> <1580357923-19783-4-git-send-email-tdas@codeaurora.org> Subject: Re: [PATCH v3 3/3] clk: qcom: Add modem clock controller driver for SC7180 To: Michael Turquette , Taniya Das From: Stephen Boyd Cc: David Brown , Rajendra Nayak , linux-arm-msm@vger.kernel.org, linux-soc@vger.kernel.org, linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org, Andy Gross , devicetree@vger.kernel.org, robh@kernel.org, robh+dt@kernel.org, Taniya Das User-Agent: alot/0.8.1 Date: Thu, 30 Jan 2020 10:08:55 -0800 Message-Id: <20200130180856.6B65C20678@mail.kernel.org> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Quoting Taniya Das (2020-01-29 20:18:43) > Add support for the modem clock controller found on SC7180 > based devices. This would allow modem drivers to probe and > control their clocks. >=20 > Signed-off-by: Taniya Das > --- > drivers/clk/qcom/Kconfig | 9 +++ > drivers/clk/qcom/Makefile | 1 + > drivers/clk/qcom/gcc-sc7180.c | 70 +++++++++++++++++++++ > drivers/clk/qcom/mss-sc7180.c | 143 ++++++++++++++++++++++++++++++++++++= ++++++ Please split this patch into two, one for gcc and one for mss. > 4 files changed, 223 insertions(+) > create mode 100644 drivers/clk/qcom/mss-sc7180.c >=20 > diff --git a/drivers/clk/qcom/mss-sc7180.c b/drivers/clk/qcom/mss-sc7180.c > new file mode 100644 > index 0000000..d82600e > --- /dev/null > +++ b/drivers/clk/qcom/mss-sc7180.c > @@ -0,0 +1,143 @@ > +// SPDX-License-Identifier: GPL-2.0-only > +/* > + * Copyright (c) 2019, The Linux Foundation. All rights reserved. > + */ > + > +#include > +#include > +#include > +#include > +#include > +#include > +#include > + > +#include > + > +#include "clk-regmap.h" > +#include "clk-branch.h" > +#include "common.h" > + [...] > + > +static struct regmap_config mss_regmap_config =3D { Can this be const? > + .reg_bits =3D 32, > + .reg_stride =3D 4, > + .val_bits =3D 32, > + .fast_io =3D true, > +}; > +