From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_2 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2517DC35240 for ; Fri, 31 Jan 2020 12:18:52 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id EC82C20705 for ; Fri, 31 Jan 2020 12:18:51 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728556AbgAaMSv (ORCPT ); Fri, 31 Jan 2020 07:18:51 -0500 Received: from bhuna.collabora.co.uk ([46.235.227.227]:55936 "EHLO bhuna.collabora.co.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728511AbgAaMSv (ORCPT ); Fri, 31 Jan 2020 07:18:51 -0500 Received: from localhost (unknown [IPv6:2a01:e0a:2c:6930:5cf4:84a1:2763:fe0d]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: bbrezillon) by bhuna.collabora.co.uk (Postfix) with ESMTPSA id C86692954FD; Fri, 31 Jan 2020 12:18:48 +0000 (GMT) Date: Fri, 31 Jan 2020 13:18:45 +0100 From: Boris Brezillon To: Ezequiel Garcia Cc: linux-media@vger.kernel.org, devicetree@vger.kernel.org, linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org, Laurent Pinchart , Rob Herring , Tomasz Figa , Nicolas Dufresne , kernel@collabora.com, Paul Kocialkowski , Jonas Karlman , Heiko Stuebner , Sakari Ailus , Hans Verkuil Subject: Re: [PATCH v4 5/6] media: rkvdec: Add the rkvdec driver Message-ID: <20200131131845.65451a8c@collabora.com> In-Reply-To: <739f60a89646cc92f26e34523cbe8aaab5697351.camel@collabora.com> References: <20200129195501.8317-1-ezequiel@collabora.com> <20200129195501.8317-6-ezequiel@collabora.com> <20200130171249.3ae0444a@collabora.com> <739f60a89646cc92f26e34523cbe8aaab5697351.camel@collabora.com> Organization: Collabora X-Mailer: Claws Mail 3.17.4 (GTK+ 2.24.32; x86_64-redhat-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 31 Jan 2020 08:53:47 -0300 Ezequiel Garcia wrote: > On Thu, 2020-01-30 at 17:12 +0100, Boris Brezillon wrote: > > On Wed, 29 Jan 2020 16:55:00 -0300 > > Ezequiel Garcia wrote: > > > > > From: Boris Brezillon > > > > > > The rockchip vdec block is a stateless decoder that's able to decode > > > H264, HEVC and VP9 content. This commit adds the core infrastructure > > > and the H264 backend. Support for VP9 and HEVS will be added later on. ^HEVC > > > > > > Signed-off-by: Boris Brezillon > > > Signed-off-by: Ezequiel Garcia > > > --- > > > v4: > > > * Make poc tables const, as suggested by Hans > > > * Move buffer extra space calculation TRY_FMT, as done on Hantro. > > > * Get rid of vb2_request_get_buf and open-code > > > following Cedrus. We can move it to a helper as a follow-up patch. > > > > Well, we know what that means in practice :-). > > > > Well, not necesarily. I think we can expect a helper soon, > but it doesn't have to be part of this series :-) I'd be happy to be proven wrong ;-).