From: Lukas Wunner <lukas@wunner.de>
To: Nicolas Saenz Julienne <nsaenzjulienne@suse.de>
Cc: Matthias Brugger <matthias.bgg@gmail.com>,
matthias.bgg@kernel.org, linux-arm-kernel@lists.infradead.org,
Matthias Brugger <mbrugger@suse.com>,
Scott Branden <sbranden@broadcom.com>,
gregkh@linuxfoundation.org, linux-kernel@vger.kernel.org,
Ray Jui <rjui@broadcom.com>, Stephen Boyd <swboyd@chromium.org>,
Florian Fainelli <f.fainelli@gmail.com>,
bcm-kernel-feedback-list@broadcom.com,
linux-rpi-kernel@lists.infradead.org,
linux-serial@vger.kernel.org, jslaby@suse.com
Subject: Re: [PATCH] serial: 8250_early: Add earlycon for BCM2835 aux uart
Date: Fri, 31 Jan 2020 16:24:14 +0100 [thread overview]
Message-ID: <20200131152414.73tgwsfhzgu4apkx@wunner.de> (raw)
In-Reply-To: <C099APQHQAHB.3Q9UVYJYT98TN@linux-9qgx>
On Thu, Jan 30, 2020 at 05:11:55PM +0100, Nicolas Saenz Julienne wrote:
> BTW did you had the oportunity to have a go at the patch?
I've just performed a quick test and it doesn't work for me.
If I add stdout-path = "serial1:115200n8"; to the chosen node,
I only get a regular console with this patch, not an earlycon.
> > The problem is that in mainline, bcm2835_defconfig contains:
> > CONFIG_CPU_FREQ_DEFAULT_GOV_CONSERVATIVE=y
> >
> > Likewise in the Foundation's downstream tree, bcmrpi_defconfig as well
> > as bcm2711_defconfig and bcm2709_defconfig contain:
> > CONFIG_CPU_FREQ_DEFAULT_GOV_POWERSAVE=y
> >
> > In contrast to this, we set the following on Revolution Pi devices:
> > CONFIG_CPU_FREQ_DEFAULT_GOV_PERFORMANCE=y
> >
> > Downclocking influences not only the uart1 baud rate but also the
> > spi0 clock. We attach Ethernet chips to spi0, throughput was
> > significantly worse with the ondemand governor (which is what we
> > used previously). We felt that maximum Ethernet performance
> > outweighs the relatively small powersaving gains.
>
> In that regard I suggest you use the upstream cpufreq driver which
> behaves properly in that regard. It disables GPU freq scaling, so as to
> change CPU frequencies without SPI/I2C/UART issues.
Okay, I'll take a look. But the uart1 baudrate will still be wrong
if the firmware downclocks because of overheating, right?
Thanks,
Lukas
next prev parent reply other threads:[~2020-01-31 15:33 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-26 12:33 [PATCH] serial: 8250_early: Add earlycon for BCM2835 aux uart matthias.bgg
2020-01-26 13:12 ` Lukas Wunner
2020-01-26 20:20 ` Matthias Brugger
2020-01-28 12:42 ` Nicolas Saenz Julienne
2020-01-28 14:19 ` Lukas Wunner
2020-01-30 16:11 ` Nicolas Saenz Julienne
2020-01-31 15:24 ` Lukas Wunner [this message]
2020-02-03 19:10 ` Nicolas Saenz Julienne
2020-02-12 13:28 ` Lukas Wunner
2020-02-12 15:18 ` Matthias Brugger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200131152414.73tgwsfhzgu4apkx@wunner.de \
--to=lukas@wunner.de \
--cc=bcm-kernel-feedback-list@broadcom.com \
--cc=f.fainelli@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=jslaby@suse.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rpi-kernel@lists.infradead.org \
--cc=linux-serial@vger.kernel.org \
--cc=matthias.bgg@gmail.com \
--cc=matthias.bgg@kernel.org \
--cc=mbrugger@suse.com \
--cc=nsaenzjulienne@suse.de \
--cc=rjui@broadcom.com \
--cc=sbranden@broadcom.com \
--cc=swboyd@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).