linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH net] netfilter: nf_flowtable: fix documentation
@ 2020-01-30 19:10 Matteo Croce
  2020-01-30 22:14 ` Jakub Kicinski
  2020-01-31 18:29 ` Pablo Neira Ayuso
  0 siblings, 2 replies; 4+ messages in thread
From: Matteo Croce @ 2020-01-30 19:10 UTC (permalink / raw)
  To: netdev, linux-doc
  Cc: David S. Miller, Pablo Neira Ayuso, Florian Westphal, linux-kernel

In the flowtable documentation there is a missing semicolon, the command
as is would give this error:

    nftables.conf:5:27-33: Error: syntax error, unexpected devices, expecting newline or semicolon
                    hook ingress priority 0 devices = { br0, pppoe-data };
                                            ^^^^^^^
    nftables.conf:4:12-13: Error: invalid hook (null)
            flowtable ft {
                      ^^

Fixes: 19b351f16fd9 ("netfilter: add flowtable documentation")
Signed-off-by: Matteo Croce <mcroce@redhat.com>
---
 Documentation/networking/nf_flowtable.txt | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/Documentation/networking/nf_flowtable.txt b/Documentation/networking/nf_flowtable.txt
index ca2136c76042..0bf32d1121be 100644
--- a/Documentation/networking/nf_flowtable.txt
+++ b/Documentation/networking/nf_flowtable.txt
@@ -76,7 +76,7 @@ flowtable and add one rule to your forward chain.
 
         table inet x {
 		flowtable f {
-			hook ingress priority 0 devices = { eth0, eth1 };
+			hook ingress priority 0; devices = { eth0, eth1 };
 		}
                 chain y {
                         type filter hook forward priority 0; policy accept;
-- 
2.24.1


^ permalink raw reply related	[flat|nested] 4+ messages in thread

* Re: [PATCH net] netfilter: nf_flowtable: fix documentation
  2020-01-30 19:10 [PATCH net] netfilter: nf_flowtable: fix documentation Matteo Croce
@ 2020-01-30 22:14 ` Jakub Kicinski
  2020-01-31  0:23   ` Matteo Croce
  2020-01-31 18:29 ` Pablo Neira Ayuso
  1 sibling, 1 reply; 4+ messages in thread
From: Jakub Kicinski @ 2020-01-30 22:14 UTC (permalink / raw)
  To: Pablo Neira Ayuso
  Cc: Matteo Croce, netdev, linux-doc, David S. Miller,
	Florian Westphal, linux-kernel

On Thu, 30 Jan 2020 20:10:19 +0100, Matteo Croce wrote:
> In the flowtable documentation there is a missing semicolon, the command
> as is would give this error:
> 
>     nftables.conf:5:27-33: Error: syntax error, unexpected devices, expecting newline or semicolon
>                     hook ingress priority 0 devices = { br0, pppoe-data };
>                                             ^^^^^^^
>     nftables.conf:4:12-13: Error: invalid hook (null)
>             flowtable ft {
>                       ^^
> 
> Fixes: 19b351f16fd9 ("netfilter: add flowtable documentation")
> Signed-off-by: Matteo Croce <mcroce@redhat.com>

This is netfilter so even though it's tagged as net, I'm expecting
Pablo (or Jon) to take it. Please LMK if I'm wrong.

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH net] netfilter: nf_flowtable: fix documentation
  2020-01-30 22:14 ` Jakub Kicinski
@ 2020-01-31  0:23   ` Matteo Croce
  0 siblings, 0 replies; 4+ messages in thread
From: Matteo Croce @ 2020-01-31  0:23 UTC (permalink / raw)
  To: Jakub Kicinski, netfilter-devel
  Cc: Pablo Neira Ayuso, netdev, linux-doc, David S. Miller,
	Florian Westphal, LKML

On Thu, Jan 30, 2020 at 11:14 PM Jakub Kicinski <kuba@kernel.org> wrote:
>
> On Thu, 30 Jan 2020 20:10:19 +0100, Matteo Croce wrote:
> > In the flowtable documentation there is a missing semicolon, the command
> > as is would give this error:
> >
> >     nftables.conf:5:27-33: Error: syntax error, unexpected devices, expecting newline or semicolon
> >                     hook ingress priority 0 devices = { br0, pppoe-data };
> >                                             ^^^^^^^
> >     nftables.conf:4:12-13: Error: invalid hook (null)
> >             flowtable ft {
> >                       ^^
> >
> > Fixes: 19b351f16fd9 ("netfilter: add flowtable documentation")
> > Signed-off-by: Matteo Croce <mcroce@redhat.com>
>
> This is netfilter so even though it's tagged as net, I'm expecting
> Pablo (or Jon) to take it. Please LMK if I'm wrong.
>

You're right.
As get_maintainers.pl didn't list netfilter-devel@vger.kernel.org I missed it.

-- 
Matteo Croce
per aspera ad upstream


^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH net] netfilter: nf_flowtable: fix documentation
  2020-01-30 19:10 [PATCH net] netfilter: nf_flowtable: fix documentation Matteo Croce
  2020-01-30 22:14 ` Jakub Kicinski
@ 2020-01-31 18:29 ` Pablo Neira Ayuso
  1 sibling, 0 replies; 4+ messages in thread
From: Pablo Neira Ayuso @ 2020-01-31 18:29 UTC (permalink / raw)
  To: Matteo Croce
  Cc: netdev, linux-doc, David S. Miller, Florian Westphal, linux-kernel

On Thu, Jan 30, 2020 at 08:10:19PM +0100, Matteo Croce wrote:
> In the flowtable documentation there is a missing semicolon, the command
> as is would give this error:
> 
>     nftables.conf:5:27-33: Error: syntax error, unexpected devices, expecting newline or semicolon
>                     hook ingress priority 0 devices = { br0, pppoe-data };
>                                             ^^^^^^^
>     nftables.conf:4:12-13: Error: invalid hook (null)
>             flowtable ft {
>                       ^^

Applied, thanks.

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2020-01-31 18:29 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-01-30 19:10 [PATCH net] netfilter: nf_flowtable: fix documentation Matteo Croce
2020-01-30 22:14 ` Jakub Kicinski
2020-01-31  0:23   ` Matteo Croce
2020-01-31 18:29 ` Pablo Neira Ayuso

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).