From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6F860C33CAC for ; Mon, 3 Feb 2020 10:00:45 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 3FE9E2082E for ; Mon, 3 Feb 2020 10:00:45 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727443AbgBCKAo (ORCPT ); Mon, 3 Feb 2020 05:00:44 -0500 Received: from mga12.intel.com ([192.55.52.136]:11623 "EHLO mga12.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726836AbgBCKAo (ORCPT ); Mon, 3 Feb 2020 05:00:44 -0500 X-Amp-Result: UNSCANNABLE X-Amp-File-Uploaded: False Received: from fmsmga008.fm.intel.com ([10.253.24.58]) by fmsmga106.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 03 Feb 2020 02:00:43 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.70,397,1574150400"; d="scan'208";a="225121166" Received: from smile.fi.intel.com (HELO smile) ([10.237.68.40]) by fmsmga008.fm.intel.com with ESMTP; 03 Feb 2020 02:00:42 -0800 Received: from andy by smile with local (Exim 4.93) (envelope-from ) id 1iyYX5-00054m-Nb; Mon, 03 Feb 2020 12:00:43 +0200 Date: Mon, 3 Feb 2020 12:00:43 +0200 From: Andy Shevchenko To: Thomas =?iso-8859-1?Q?Wei=DFschuh?= Cc: Henrique de Moraes Holschuh , Darren Hart , Andy Shevchenko , ibm-acpi-devel@lists.sourceforge.net, platform-driver-x86@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 1/3] platform/x86: thinkpad_acpi: remove unused defines Message-ID: <20200203100043.GZ32742@smile.fi.intel.com> References: <20200131143650.4149-1-linux@weissschuh.net> <20200131143650.4149-2-linux@weissschuh.net> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20200131143650.4149-2-linux@weissschuh.net> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Jan 31, 2020 at 03:36:48PM +0100, Thomas Weißschuh wrote: > They were never used. Thanks for the series. Unfortunately I may not proceed it since it misses our patchwork [1] for some reason. Besides that, this patch is okay, but the rest two must be: - unified together to avoid regression in the middle - done other way around, simple add aliases to *old* ones Don't forget to update any documentation if needed. [1]: https://patchwork.kernel.org/project/platform-driver-x86/list/ > > Signed-off-by: Thomas Weißschuh > --- > drivers/platform/x86/thinkpad_acpi.c | 3 --- > 1 file changed, 3 deletions(-) > > diff --git a/drivers/platform/x86/thinkpad_acpi.c b/drivers/platform/x86/thinkpad_acpi.c > index da794dcfdd92..2d3a99e3efb7 100644 > --- a/drivers/platform/x86/thinkpad_acpi.c > +++ b/drivers/platform/x86/thinkpad_acpi.c > @@ -9323,9 +9323,6 @@ static struct ibm_struct mute_led_driver_data = { > #define GET_STOP "BCSG" > #define SET_STOP "BCSS" > > -#define START_ATTR "charge_start_threshold" > -#define STOP_ATTR "charge_stop_threshold" > - > enum { > BAT_ANY = 0, > BAT_PRIMARY = 1, -- With Best Regards, Andy Shevchenko