From: Jakub Kicinski <kuba@kernel.org>
To: Nicolin Chen <nicoleotsuka@gmail.com>
Cc: davem@davemloft.net, peppe.cavallaro@st.com,
alexandre.torgue@st.com, joabreu@synopsys.com,
mcoquelin.stm32@gmail.com, netdev@vger.kernel.org,
linux-stm32@st-md-mailman.stormreply.com,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] net: stmmac: Delete txtimer in suspend()
Date: Mon, 3 Feb 2020 15:04:54 -0800 [thread overview]
Message-ID: <20200203150454.2938960b@cakuba.hsd1.ca.comcast.net> (raw)
In-Reply-To: <20200201020124.5989-1-nicoleotsuka@gmail.com>
On Fri, 31 Jan 2020 18:01:24 -0800, Nicolin Chen wrote:
> When running v5.5 with a rootfs on NFS, memory abort may happen in
> the system resume stage:
> Unable to handle kernel paging request at virtual address dead00000000012a
> [dead00000000012a] address between user and kernel address ranges
> pc : run_timer_softirq+0x334/0x3d8
> lr : run_timer_softirq+0x244/0x3d8
> x1 : ffff800011cafe80 x0 : dead000000000122
> Call trace:
> run_timer_softirq+0x334/0x3d8
> efi_header_end+0x114/0x234
> irq_exit+0xd0/0xd8
> __handle_domain_irq+0x60/0xb0
> gic_handle_irq+0x58/0xa8
> el1_irq+0xb8/0x180
> arch_cpu_idle+0x10/0x18
> do_idle+0x1d8/0x2b0
> cpu_startup_entry+0x24/0x40
> secondary_start_kernel+0x1b4/0x208
> Code: f9000693 a9400660 f9000020 b4000040 (f9000401)
> ---[ end trace bb83ceeb4c482071 ]---
> Kernel panic - not syncing: Fatal exception in interrupt
> SMP: stopping secondary CPUs
> SMP: failed to stop secondary CPUs 2-3
> Kernel Offset: disabled
> CPU features: 0x00002,2300aa30
> Memory Limit: none
> ---[ end Kernel panic - not syncing: Fatal exception in interrupt ]---
>
> It's found that stmmac_xmit() and stmmac_resume() sometimes might
> run concurrently, possibly resulting in a race condition between
> mod_timer() and setup_timer(), being called by stmmac_xmit() and
> stmmac_resume() respectively.
>
> Since the resume() runs setup_timer() every time, it'd be safer to
> have del_timer_sync() in the suspend() as the counterpart.
>
> Signed-off-by: Nicolin Chen <nicoleotsuka@gmail.com>
Applied, and queued for stable, thank you!
prev parent reply other threads:[~2020-02-03 23:04 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-01 2:01 [PATCH] net: stmmac: Delete txtimer in suspend() Nicolin Chen
2020-02-03 23:04 ` Jakub Kicinski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200203150454.2938960b@cakuba.hsd1.ca.comcast.net \
--to=kuba@kernel.org \
--cc=alexandre.torgue@st.com \
--cc=davem@davemloft.net \
--cc=joabreu@synopsys.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-stm32@st-md-mailman.stormreply.com \
--cc=mcoquelin.stm32@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=nicoleotsuka@gmail.com \
--cc=peppe.cavallaro@st.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).