From: Russell King - ARM Linux admin <linux@armlinux.org.uk>
To: Calvin Johnson <calvin.johnson@nxp.com>
Cc: linux.cj@gmail.com, Jon Nettleton <jon@solid-run.com>,
Makarand Pawagi <makarand.pawagi@nxp.com>,
cristian.sovaiala@nxp.com, laurentiu.tudor@nxp.com,
ioana.ciornei@nxp.com, V.Sethi@nxp.com, pankaj.bansal@nxp.com,
"Rajesh V . Bikkina" <rajesh.bikkina@nxp.com>,
Calvin Johnson <calvin.johnson@oss.nxp.com>,
Andrew Lunn <andrew@lunn.ch>,
"David S. Miller" <davem@davemloft.net>,
Florian Fainelli <f.fainelli@gmail.com>,
Heiner Kallweit <hkallweit1@gmail.com>,
linux-kernel@vger.kernel.org, netdev@vger.kernel.org
Subject: Re: [PATCH v1 6/7] net: phylink: Introduce phylink_fwnode_phy_connect()
Date: Mon, 3 Feb 2020 18:43:30 +0000 [thread overview]
Message-ID: <20200203184330.GF18808@shell.armlinux.org.uk> (raw)
In-Reply-To: <20200203184121.GR25745@shell.armlinux.org.uk>
On Mon, Feb 03, 2020 at 06:41:21PM +0000, Russell King - ARM Linux admin wrote:
> On Fri, Jan 31, 2020 at 09:04:39PM +0530, Calvin Johnson wrote:
> > From: Calvin Johnson <calvin.johnson@oss.nxp.com>
> >
> > Introduce phylink_fwnode_phy_connect API to connect the PHY using
> > fwnode.
> >
> > Signed-off-by: Calvin Johnson <calvin.johnson@oss.nxp.com>
> > ---
> >
> > drivers/net/phy/phylink.c | 64 +++++++++++++++++++++++++++++++++++++++
> > include/linux/phylink.h | 2 ++
> > 2 files changed, 66 insertions(+)
> >
> > diff --git a/drivers/net/phy/phylink.c b/drivers/net/phy/phylink.c
> > index ee7a718662c6..f211f62283b5 100644
> > --- a/drivers/net/phy/phylink.c
> > +++ b/drivers/net/phy/phylink.c
> > @@ -18,6 +18,7 @@
> > #include <linux/spinlock.h>
> > #include <linux/timer.h>
> > #include <linux/workqueue.h>
> > +#include <linux/acpi.h>
> >
> > #include "sfp.h"
> > #include "swphy.h"
> > @@ -817,6 +818,69 @@ int phylink_connect_phy(struct phylink *pl, struct phy_device *phy)
> > }
> > EXPORT_SYMBOL_GPL(phylink_connect_phy);
> >
> > +/**
> > + * phylink_fwnode_phy_connect() - connect the PHY specified in the fwnode.
> > + * @pl: a pointer to a &struct phylink returned from phylink_create()
> > + * @dn: a pointer to a &struct device_node.
> > + * @flags: PHY-specific flags to communicate to the PHY device driver
> > + *
> > + * Connect the phy specified in the device node @dn to the phylink instance
> > + * specified by @pl. Actions specified in phylink_connect_phy() will be
> > + * performed.
> > + *
> > + * Returns 0 on success or a negative errno.
> > + */
> > +int phylink_fwnode_phy_connect(struct phylink *pl,
> > + struct fwnode_handle *fwnode,
> > + u32 flags)
> > +{
> > + struct fwnode_handle *phy_node;
> > + struct phy_device *phy_dev;
> > + int ret;
> > + int status;
> > + struct fwnode_reference_args args;
> > +
> > + /* Fixed links and 802.3z are handled without needing a PHY */
> > + if (pl->link_an_mode == MLO_AN_FIXED ||
> > + (pl->link_an_mode == MLO_AN_INBAND &&
> > + phy_interface_mode_is_8023z(pl->link_interface)))
> > + return 0;
> > +
> > + status = acpi_node_get_property_reference(fwnode, "phy-handle", 0,
> > + &args);
> > + if (ACPI_FAILURE(status) || !is_acpi_device_node(args.fwnode))
> > + status = acpi_node_get_property_reference(fwnode, "phy", 0,
> > + &args);
> > + if (ACPI_FAILURE(status) || !is_acpi_device_node(args.fwnode))
> > + status = acpi_node_get_property_reference(fwnode,
> > + "phy-device", 0,
> > + &args);
>
> This is a copy-and-paste of phylink_of_phy_connect() without much
> thought.
>
> There is no need to duplicate the legacy DT functionality of
> phy/phy-device/phy-handle in ACPI - there is no legacy to support,
> so it's pointless trying to find one of three properties here.
>
> I'd prefer both the DT and ACPI variants to be more integrated, so
> we don't have two almost identical functions except for the firmware
> specific detail.
Also, I don't see any ACPI folk in the list of recipients to your
series.
--
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTC broadband for 0.8mile line in suburbia: sync at 12.1Mbps down 622kbps up
According to speedtest.net: 11.9Mbps down 500kbps up
next prev parent reply other threads:[~2020-02-03 18:43 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-31 15:34 [PATCH v1 0/7] ACPI support for xgmac_mdio and dpaa2-mac drivers Calvin Johnson
2020-01-31 15:34 ` [PATCH v1 1/7] mdio_bus: Introduce fwnode MDIO helpers Calvin Johnson
2020-01-31 16:28 ` Andrew Lunn
2020-02-05 7:11 ` [EXT] " Calvin Johnson (OSS)
2020-02-03 9:49 ` kbuild test robot
2020-02-05 14:17 ` Jeremy Linton
2020-02-07 9:42 ` [EXT] " Calvin Johnson (OSS)
2020-03-17 11:36 ` Calvin Johnson
2020-03-17 14:04 ` Andrew Lunn
2020-03-18 6:03 ` Calvin Johnson
2020-01-31 15:34 ` [PATCH v1 2/7] mdio_bus: modify fwnode phy related functions Calvin Johnson
2020-01-31 15:34 ` [PATCH v1 3/7] net/fsl: add ACPI support for mdio bus Calvin Johnson
2020-01-31 16:08 ` Andy Shevchenko
2020-02-04 7:18 ` Calvin Johnson (OSS)
2020-02-04 11:17 ` Andy Shevchenko
2020-02-03 3:44 ` Florian Fainelli
2020-02-04 18:46 ` Calvin Johnson
2020-01-31 15:34 ` [PATCH v1 4/7] device property: fwnode_get_phy_mode: Change API to solve int/unit warnings Calvin Johnson
2020-01-31 15:55 ` Andy Shevchenko
2020-02-03 9:13 ` Calvin Johnson (OSS)
2020-02-03 9:22 ` Andy Shevchenko
2020-02-03 2:32 ` kbuild test robot
2020-02-03 8:41 ` kbuild test robot
2020-01-31 15:34 ` [PATCH v1 5/7] device property: Introduce fwnode_phy_is_fixed_link() Calvin Johnson
2020-01-31 15:57 ` Andy Shevchenko
2020-02-03 9:21 ` Calvin Johnson (OSS)
2020-01-31 15:34 ` [PATCH v1 6/7] net: phylink: Introduce phylink_fwnode_phy_connect() Calvin Johnson
2020-02-03 18:21 ` kbuild test robot
2020-02-03 18:41 ` Russell King - ARM Linux admin
2020-02-03 18:43 ` Russell King - ARM Linux admin [this message]
2020-02-05 11:33 ` [EXT] " Calvin Johnson (OSS)
2020-01-31 15:34 ` [PATCH v1 7/7] dpaa2-eth: Add ACPI support for DPAA2 MAC driver Calvin Johnson
2020-02-03 18:02 ` [PATCH v1 0/7] ACPI support for xgmac_mdio and dpaa2-mac drivers Florian Fainelli
2020-02-05 8:31 ` [EXT] " Calvin Johnson (OSS)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200203184330.GF18808@shell.armlinux.org.uk \
--to=linux@armlinux.org.uk \
--cc=V.Sethi@nxp.com \
--cc=andrew@lunn.ch \
--cc=calvin.johnson@nxp.com \
--cc=calvin.johnson@oss.nxp.com \
--cc=cristian.sovaiala@nxp.com \
--cc=davem@davemloft.net \
--cc=f.fainelli@gmail.com \
--cc=hkallweit1@gmail.com \
--cc=ioana.ciornei@nxp.com \
--cc=jon@solid-run.com \
--cc=laurentiu.tudor@nxp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux.cj@gmail.com \
--cc=makarand.pawagi@nxp.com \
--cc=netdev@vger.kernel.org \
--cc=pankaj.bansal@nxp.com \
--cc=rajesh.bikkina@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).