From: Guenter Roeck <linux@roeck-us.net>
To: Avri Altman <Avri.Altman@wdc.com>
Cc: Avi Shchislowski <Avi.Shchislowski@wdc.com>,
Alim Akhtar <alim.akhtar@samsung.com>,
"James E.J. Bottomley" <jejb@linux.ibm.com>,
"Martin K. Petersen" <martin.petersen@oracle.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-scsi@vger.kernel.org" <linux-scsi@vger.kernel.org>
Subject: Re: [PATCH 0/5] scsi: ufs: ufs device as a temperature sensor
Date: Mon, 3 Feb 2020 13:47:33 -0800 [thread overview]
Message-ID: <20200203214733.GA30898@roeck-us.net> (raw)
In-Reply-To: <MN2PR04MB69910152F14A7D481029E4ECFC000@MN2PR04MB6991.namprd04.prod.outlook.com>
On Mon, Feb 03, 2020 at 09:29:57PM +0000, Avri Altman wrote:
> > >> Can you add an explanation why this can't be added to the just-
> > introduced
> > >> 'drivetemp' driver in the hwmon subsystem, and why it make sense to
> > have
> > >> proprietary attributes for temperature and temperature limits ?
>
>
> Guenter hi,
> Yeah - I see your point. But here is the thing -
> UFS devices support only a subset of scsi commands.
> It does not support ATA_16 nor SMART attributes.
> Moreover, you can't read UFS attributes using any other scsi/ATA/SATA
> Commands, nor it obey the ATA temperature sensing conventions.
> So unless you want to totally break the newly born drivetemp -
> Better to leave ufs devices out of it.
>
drivetemp is written with extensibility in mind. For example, Martin has a
prototype enhancement which supports SCSI drive temperature sensors.
As long as a device can be identified as ufs device, and as long as there
is a means to pass-through commands, adding a new type would be easy.
> Another option is to put a ufs module under hwmon.
> Do you see why would that be more advantageous to using the thermal core?
> Provided that you are not going to deprecate it (Intel's wifi card is still using it)...
>
Deprecate what, and what does this discussion have to do with Intel's wifi
card ?
Either case, the hardware monitoring subsystem provides standard attributes,
and it provides a bridge to the thermal subsystem. The question should be
why _not_ to use the hwmon subsystem, and this question should be answered
as part of this patch series.
Guenter
next prev parent reply other threads:[~2020-02-03 21:47 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-02 10:46 [PATCH 0/5] scsi: ufs: ufs device as a temperature sensor Avi Shchislowski
2020-02-02 10:46 ` [PATCH 1/5] scsi: ufs: Add ufs thermal support Avi Shchislowski
2020-02-02 10:46 ` [PATCH 2/5] scsi: ufs: export ufshcd_enable_ee Avi Shchislowski
2020-02-02 10:46 ` [PATCH 3/5] scsi: ufs: enable thermal exception event Avi Shchislowski
2020-02-02 10:46 ` [PATCH 4/5] scsi: ufs-thermal: implement thermal file ops Avi Shchislowski
2020-02-02 10:46 ` [PATCH 5/5] scsi: ufs: temperature atrributes add to ufs_sysfs Avi Shchislowski
2020-02-02 19:21 ` [PATCH 0/5] scsi: ufs: ufs device as a temperature sensor Guenter Roeck
2020-02-03 11:57 ` Avi Shchislowski
2020-02-03 14:47 ` Guenter Roeck
2020-02-03 21:29 ` Avri Altman
2020-02-03 21:47 ` Guenter Roeck [this message]
2020-02-04 6:17 ` Avri Altman
2020-02-06 10:40 ` Avi Shchislowski
2020-02-06 11:39 ` Julian Calaby
2020-02-06 12:08 ` Avri Altman
2020-02-06 12:41 ` Julian Calaby
2020-02-06 13:40 ` Avri Altman
2020-02-06 15:49 ` Julian Calaby
2020-02-06 19:32 ` Avri Altman
2020-02-06 20:42 ` Guenter Roeck
2020-02-06 22:21 ` Avri Altman
2020-02-07 0:47 ` Julian Calaby
2020-02-03 8:51 ` [EXT] " Bean Huo (beanhuo)
-- strict thread matches above, loose matches on Subject: below --
2020-02-02 15:47 Avi Shchislowski
2020-02-02 7:41 Avi Shchislowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200203214733.GA30898@roeck-us.net \
--to=linux@roeck-us.net \
--cc=Avi.Shchislowski@wdc.com \
--cc=Avri.Altman@wdc.com \
--cc=alim.akhtar@samsung.com \
--cc=jejb@linux.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).