From: Jiri Pirko <jiri@resnulli.us>
To: Ray Jui <ray.jui@broadcom.com>
Cc: Jiri Pirko <jiri@mellanox.com>,
"David S. Miller" <davem@davemloft.net>,
netdev@vger.kernel.org,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
BCM Kernel Feedback <bcm-kernel-feedback-list@broadcom.com>
Subject: Re: RFC: Use of devlink/health report for non-Ethernet devices
Date: Tue, 4 Feb 2020 07:48:54 +0100 [thread overview]
Message-ID: <20200204064854.GK2260@nanopsycho> (raw)
In-Reply-To: <f8e67e40-71d4-f03c-6bc0-6496663af895@broadcom.com>
Tue, Feb 04, 2020 at 12:01:37AM CET, ray.jui@broadcom.com wrote:
>Hi Jiri/Eran/David,
>
>I've been investigating the health report feature of devlink, and have a
>couple related questions as follows:
>
>1. Based on my investigation, it seems that devlink health report mechanism
>provides the hook for a device driver to report errors, dump debug
>information, trigger object dump, initiate self-recovery, and etc. The
>current users of health report are all Ethernet based drivers. However, it
>does not seem the health report framework prohibits the use from any
>non-Ethernet based device drivers. Is my understanding correct?
The whole devlink framework is designed to be independent on
ethernet/networking.
>
>2. Following my first question, in this case, do you think it makes any sense
>to use devlink health report as a generic error reporting and recovery
>mechanism, for other devices, e.g., NVMe and Virt I/O?
Sure.
>
>3. In the Ethernet device driver based use case, if one has a "smart NIC"
>type of platform, i.e., running Linux on the embedded processor of the NIC,
>it seems to make a lot of sense to also use devlink health report to deal
>with other non-Ethernet specific errors, originated from the embedded Linux
>(or any other OSes). The front-end driver that registers various health
>reporters will still be an Ethernet based device driver, running on the host
>server system. Does this make sense to you?
Should not be ethetnet based driver. You should create the devlink
instance in a driver for the particular device you want to report
the health for.
>
>Thanks in advance for your feedback!
>
>Thanks,
>
>Ray
>
>
next prev parent reply other threads:[~2020-02-04 6:48 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-03 23:01 RFC: Use of devlink/health report for non-Ethernet devices Ray Jui
2020-02-04 6:48 ` Jiri Pirko [this message]
2020-02-04 17:46 ` Ray Jui
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200204064854.GK2260@nanopsycho \
--to=jiri@resnulli.us \
--cc=bcm-kernel-feedback-list@broadcom.com \
--cc=davem@davemloft.net \
--cc=jiri@mellanox.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=ray.jui@broadcom.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).