* [PATCH] ASoC: wcd934x: Add missing COMMON_CLK dependency
@ 2020-02-04 10:24 Srinivas Kandagatla
2020-02-04 11:04 ` Mark Brown
0 siblings, 1 reply; 2+ messages in thread
From: Srinivas Kandagatla @ 2020-02-04 10:24 UTC (permalink / raw)
To: broonie; +Cc: alsa-devel, sfr, lee.jones, linux-kernel, Srinivas Kandagatla
Looks like some platforms are not yet using COMMON CLK.
PowerPC allyesconfig failed with below error in next
ld: sound/soc/codecs/wcd934x.o:(.toc+0x0):
undefined reference to `of_clk_src_simple_get'
ld: sound/soc/codecs/wcd934x.o: in function `.wcd934x_codec_probe':
wcd934x.c:(.text.wcd934x_codec_probe+0x3d4):
undefined reference to `.__clk_get_name'
ld: wcd934x.c:(.text.wcd934x_codec_probe+0x438):
undefined reference to `.clk_hw_register'
ld: wcd934x.c:(.text.wcd934x_codec_probe+0x474):
undefined reference to `.of_clk_add_provider'
Add the missing COMMON_CLK dependency to fix this errors.
Reported-by: Stephen Rothwell <sfr@canb.auug.org.au>
Signed-off-by: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
---
sound/soc/codecs/Kconfig | 1 +
1 file changed, 1 insertion(+)
diff --git a/sound/soc/codecs/Kconfig b/sound/soc/codecs/Kconfig
index 4d5b0d5a73d3..3e2396ee727f 100644
--- a/sound/soc/codecs/Kconfig
+++ b/sound/soc/codecs/Kconfig
@@ -1280,6 +1280,7 @@ config SND_SOC_WCD9335
config SND_SOC_WCD934X
tristate "WCD9340/WCD9341 Codec"
depends on SLIMBUS
+ depends on COMMON_CLK
select REGMAP_SLIMBUS
select REGMAP_IRQ
help
--
2.21.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] ASoC: wcd934x: Add missing COMMON_CLK dependency
2020-02-04 10:24 [PATCH] ASoC: wcd934x: Add missing COMMON_CLK dependency Srinivas Kandagatla
@ 2020-02-04 11:04 ` Mark Brown
0 siblings, 0 replies; 2+ messages in thread
From: Mark Brown @ 2020-02-04 11:04 UTC (permalink / raw)
To: Srinivas Kandagatla; +Cc: alsa-devel, sfr, lee.jones, linux-kernel
[-- Attachment #1: Type: text/plain, Size: 258 bytes --]
On Tue, Feb 04, 2020 at 10:24:28AM +0000, Srinivas Kandagatla wrote:
> Looks like some platforms are not yet using COMMON CLK.
>
> PowerPC allyesconfig failed with below error in next
This doesn't apply against current code, please check and resend.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-02-04 11:04 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-02-04 10:24 [PATCH] ASoC: wcd934x: Add missing COMMON_CLK dependency Srinivas Kandagatla
2020-02-04 11:04 ` Mark Brown
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).