From: Phil Auld <pauld@redhat.com>
To: Scott Wood <swood@redhat.com>
Cc: Peter Zijlstra <peterz@infradead.org>,
Frederic Weisbecker <fweisbec@gmail.com>,
Thomas Gleixner <tglx@linutronix.de>,
Ingo Molnar <mingo@kernel.org>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] sched/core: sched_tick_remote: Remove duplicate assignment
Date: Tue, 4 Feb 2020 09:27:19 -0500 [thread overview]
Message-ID: <20200204142718.GA23972@pauld.bos.csb> (raw)
In-Reply-To: <1580776558-12882-1-git-send-email-swood@redhat.com>
Hi Scott,
On Mon, Feb 03, 2020 at 07:35:58PM -0500 Scott Wood wrote:
> A redundant "curr = rq->curr" was added; remove it.
>
> Fixes: ebc0f83c78a2 ("timers/nohz: Update NOHZ load in remote tick")
> Signed-off-by: Scott Wood <swood@redhat.com>
> ---
> kernel/sched/core.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/kernel/sched/core.c b/kernel/sched/core.c
> index 45f79bcc3146..377ec26e9159 100644
> --- a/kernel/sched/core.c
> +++ b/kernel/sched/core.c
> @@ -3683,7 +3683,6 @@ static void sched_tick_remote(struct work_struct *work)
> if (cpu_is_offline(cpu))
> goto out_unlock;
>
> - curr = rq->curr;
> update_rq_clock(rq);
>
> if (!is_idle_task(curr)) {
> --
> 1.8.3.1
>
Reviewed-by: Phil Auld <pauld@redhat.com>
Out of curiosity, why remove this one and not the one right before the
cpu_is_offline check?
Cheers,
Phil
--
next prev parent reply other threads:[~2020-02-04 14:27 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-04 0:35 [PATCH] sched/core: sched_tick_remote: Remove duplicate assignment Scott Wood
2020-02-04 14:27 ` Phil Auld [this message]
2020-02-04 17:00 ` Scott Wood
2020-02-11 12:47 ` [tip: sched/core] sched/core: Remove duplicate assignment in sched_tick_remote() tip-bot2 for Scott Wood
2020-02-20 20:09 ` tip-bot2 for Scott Wood
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200204142718.GA23972@pauld.bos.csb \
--to=pauld@redhat.com \
--cc=fweisbec@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=peterz@infradead.org \
--cc=swood@redhat.com \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).