From: Daniel Thompson <daniel.thompson@linaro.org>
To: Anatoly Pugachev <matorola@gmail.com>
Cc: Doug Anderson <dianders@chromium.org>,
Sparc kernel list <sparclinux@vger.kernel.org>,
Linux Kernel list <linux-kernel@vger.kernel.org>
Subject: Re: [sparc64] unable to build kernel after bbfceba15f8 / "kdb: Get rid of confusing diag msg from "rd" if current task has no regs"
Date: Wed, 5 Feb 2020 15:51:56 +0000 [thread overview]
Message-ID: <20200205155156.5bxbitf3u4tiaxkh@holly.lan> (raw)
In-Reply-To: <CADxRZqwxjqo7h_L0v+9n9nuSqrgCMj5uqKf4kZjekEz8=EMgmQ@mail.gmail.com>
On Wed, Feb 05, 2020 at 12:41:46PM +0300, Anatoly Pugachev wrote:
> On Wed, Feb 5, 2020 at 1:13 AM Doug Anderson <dianders@chromium.org> wrote:
> >
> > Hi,
> >
> > On Tue, Feb 4, 2020 at 1:14 PM Anatoly Pugachev <matorola@gmail.com> wrote:
> > >
> > > Hello!
> > >
> > > After (bisected) bbfceba15f8d1260c328a254efc2b3f2deae4904 got
> > > mainline, i'm unable to build kernel with the following messages:
> > >
> > > ~/linux-2.6$ make -j olddefconfig; make kernel/debug/kdb/
> > > scripts/kconfig/conf --olddefconfig Kconfig
> > > #
> > > # No change to .config
> > > #
> > > CALL scripts/atomic/check-atomics.sh
> > > CALL scripts/checksyscalls.sh
> > > <stdin>:1511:2: warning: #warning syscall clone3 not implemented [-Wcpp]
> > > CC kernel/debug/kdb/kdb_main.o
> > > kernel/debug/kdb/kdb_main.c: In function ‘kdb_rd’:
> > > kernel/debug/kdb/kdb_main.c:1857:11: error: ‘dbg_reg_def’ undeclared
> > > (first use in this function); did you mean ‘dbg_reg_def_t’?
> > > 1857 | rsize = dbg_reg_def[i].size * 2;
> > > | ^~~~~~~~~~~
> > > | dbg_reg_def_t
> > > kernel/debug/kdb/kdb_main.c:1857:11: note: each undeclared identifier
> > > is reported only once for each function it appears in
> > > kernel/debug/kdb/kdb_main.c:1868:12: error: implicit declaration of
> > > function ‘dbg_get_reg’ [-Werror=implicit-function-declaration]
> > > 1868 | rname = dbg_get_reg(i, ®8, kdb_current_regs);
> > > | ^~~~~~~~~~~
> > > kernel/debug/kdb/kdb_main.c:1868:10: warning: assignment to ‘char *’
> > > from ‘int’ makes pointer from integer without a cast
> > > [-Wint-conversion]
> > > 1868 | rname = dbg_get_reg(i, ®8, kdb_current_regs);
> > > | ^
> > > kernel/debug/kdb/kdb_main.c:1874:10: warning: assignment to ‘char *’
> > > from ‘int’ makes pointer from integer without a cast
> > > [-Wint-conversion]
> > > 1874 | rname = dbg_get_reg(i, ®16, kdb_current_regs);
> > > | ^
> > > kernel/debug/kdb/kdb_main.c:1880:10: warning: assignment to ‘char *’
> > > from ‘int’ makes pointer from integer without a cast
> > > [-Wint-conversion]
> > > 1880 | rname = dbg_get_reg(i, ®32, kdb_current_regs);
> > > | ^
> > > kernel/debug/kdb/kdb_main.c:1886:10: warning: assignment to ‘char *’
> > > from ‘int’ makes pointer from integer without a cast
> > > [-Wint-conversion]
> > > 1886 | rname = dbg_get_reg(i, ®64, kdb_current_regs);
> > > | ^
> > > cc1: some warnings being treated as errors
> > > make[3]: *** [scripts/Makefile.build:266: kernel/debug/kdb/kdb_main.o] Error 1
> > > make[2]: *** [scripts/Makefile.build:503: kernel/debug/kdb] Error 2
> > > make[1]: *** [scripts/Makefile.build:503: kernel/debug] Error 2
> > > make: *** [Makefile:1681: kernel] Error 2
> > >
> > >
> > > reversing bbfceba15f8d with current git master branch - makes kernel
> > > compilable again.
> > >
> > > kernel config attached
> >
> > Argh. Sorry about this. :( I'm not setup with a sparc compiler, but
> > I've simulated your results on arm64 by just commenting out the
> > definition of "DBG_MAX_REG_NUM" in "arch/arm64/include/asm/kgdb.h".
> > Hopefully:
> >
> > https://lore.kernel.org/r/20200204141219.1.Ief3f3a7edbbd76165901b14813e90381c290786d@changeid
> >
> > ...will fix you?
>
> Fixes issue for me. Thank you.
Thanks for the update. I'll pass it along shortly.
Somewhat ironically I don't think I ever enabled pre-release sparc
build testing because of conflicts between the way the sparc kernel
adds -Werror to some of the architecture specific files and the tools I
use to detect new warnings. I might have to look at that as well!
Daniel.
next prev parent reply other threads:[~2020-02-05 15:52 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-04 21:14 [sparc64] unable to build kernel after bbfceba15f8 / "kdb: Get rid of confusing diag msg from "rd" if current task has no regs" Anatoly Pugachev
2020-02-04 22:13 ` Doug Anderson
2020-02-05 9:41 ` Anatoly Pugachev
2020-02-05 15:51 ` Daniel Thompson [this message]
2020-02-07 10:58 ` John Paul Adrian Glaubitz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200205155156.5bxbitf3u4tiaxkh@holly.lan \
--to=daniel.thompson@linaro.org \
--cc=dianders@chromium.org \
--cc=linux-kernel@vger.kernel.org \
--cc=matorola@gmail.com \
--cc=sparclinux@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).