From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.9 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 605B3C35247 for ; Wed, 5 Feb 2020 22:42:03 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 33DE5214AF for ; Wed, 5 Feb 2020 22:42:03 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="SgorTlbz" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727566AbgBEWmC (ORCPT ); Wed, 5 Feb 2020 17:42:02 -0500 Received: from us-smtp-2.mimecast.com ([205.139.110.61]:48252 "EHLO us-smtp-delivery-1.mimecast.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1727165AbgBEWmC (ORCPT ); Wed, 5 Feb 2020 17:42:02 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1580942520; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=rH9hapDVBD03GESwcZDF6GjM5sGJp1/0m6Dm+I8b0N0=; b=SgorTlbzs1TFwRJO+GUzGpgEnZAm5AjKLjMJZSFhUHsKxXAWIhqSFmVd8NiJAmwnSntC9D uOalY9fiT6eIAQDk3WEoyIrF+05ReO/ts2IvENmrMKtPu8BK/gfz3YJBjz1sQ14Vci0HlE qwmSLBmUOio8lUOhpyhJ5vhFayqNQkY= Received: from mail-qt1-f197.google.com (mail-qt1-f197.google.com [209.85.160.197]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-412-auNEfzrpMl2ctreByi1rzg-1; Wed, 05 Feb 2020 17:41:59 -0500 X-MC-Unique: auNEfzrpMl2ctreByi1rzg-1 Received: by mail-qt1-f197.google.com with SMTP id e37so2463601qtk.7 for ; Wed, 05 Feb 2020 14:41:59 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=rH9hapDVBD03GESwcZDF6GjM5sGJp1/0m6Dm+I8b0N0=; b=dlEihwA/ceY4CbNMFSjRrGD3WLc40j6rlmbL4jFlRCpU257xPt/Cy35+94AVV8Y7Tj O94CR+vypltdhEoT5d89Pijjx0gFeYjyA5K873hQcvpZVSnjBEpaKtteP6K7iIBWaxXM BCUnhmJ53VmeSs0AeXKtfhT06vDZZF1+acZrxB/OOLh91DGLxx6bjjHu1SmKKuxwUgzQ EzfV4Th4MLk/otMizzVMKPp7QWFR471Pmx3ZyagjcdogokYUWojWXus0BX6rPwQObWoK al+qgvijyK6HGx8hytM2/ukuTxqLPV55WeK1vw2/gmR0TT2r4x4JxVBboBhcCcydcKsY 3pIA== X-Gm-Message-State: APjAAAXlJ5UV3BkBpN8eg4X53Uhvjia73/UM/wo+VNL+TfTg8n5W3R5J eC+jc8rLSpvcU08286C6HCzrVz7/rtgcEcvHdifdASi/Q0a0Qlxnw2WNk0TJJXuTTFuQl3aDqIP RJjxA3KJQt2q/+ZhQAwQ8qywp X-Received: by 2002:a37:4fc3:: with SMTP id d186mr59903qkb.100.1580942518823; Wed, 05 Feb 2020 14:41:58 -0800 (PST) X-Google-Smtp-Source: APXvYqz7uhA3CGENCAtqy4g5GvmYMoxE6Qbx+Ub2ume93+vIa38OEJ1jq8Hx/Hw9ZpC1eb3usykd7Q== X-Received: by 2002:a37:4fc3:: with SMTP id d186mr59892qkb.100.1580942518606; Wed, 05 Feb 2020 14:41:58 -0800 (PST) Received: from xz-x1 ([2607:9880:19c8:32::2]) by smtp.gmail.com with ESMTPSA id a201sm512222qkc.134.2020.02.05.14.41.56 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 05 Feb 2020 14:41:57 -0800 (PST) Date: Wed, 5 Feb 2020 17:41:54 -0500 From: Peter Xu To: Sean Christopherson Cc: Paolo Bonzini , Paul Mackerras , Christian Borntraeger , Janosch Frank , David Hildenbrand , Cornelia Huck , Vitaly Kuznetsov , Wanpeng Li , Jim Mattson , Joerg Roedel , Marc Zyngier , James Morse , Julien Thierry , Suzuki K Poulose , linux-mips@vger.kernel.org, kvm@vger.kernel.org, kvm-ppc@vger.kernel.org, linux-arm-kernel@lists.infradead.org, kvmarm@lists.cs.columbia.edu, linux-kernel@vger.kernel.org, Christoffer Dall , Philippe =?utf-8?Q?Mathieu-Daud=C3=A9?= Subject: Re: [PATCH v5 04/19] KVM: PPC: Move memslot memory allocation into prepare_memory_region() Message-ID: <20200205224154.GG387680@xz-x1> References: <20200121223157.15263-1-sean.j.christopherson@intel.com> <20200121223157.15263-5-sean.j.christopherson@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20200121223157.15263-5-sean.j.christopherson@intel.com> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Jan 21, 2020 at 02:31:42PM -0800, Sean Christopherson wrote: > static int kvmppc_core_prepare_memory_region_hv(struct kvm *kvm, > - struct kvm_memory_slot *memslot, > - const struct kvm_userspace_memory_region *mem) > + struct kvm_memory_slot *slot, > + const struct kvm_userspace_memory_region *mem, > + enum kvm_mr_change change) > { > + unsigned long npages = mem->memory_size >> PAGE_SHIFT; Only in case if this patch still needs a respin: IIUC we can directly use slot->npages below. No matter what: Reviewed-by: Peter Xu > + > + if (change == KVM_MR_CREATE) { > + slot->arch.rmap = vzalloc(array_size(npages, > + sizeof(*slot->arch.rmap))); > + if (!slot->arch.rmap) > + return -ENOMEM; > + } > + > return 0; > } -- Peter Xu