From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.4 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2FE0DC35247 for ; Wed, 5 Feb 2020 23:31:10 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 038FC2082E for ; Wed, 5 Feb 2020 23:31:10 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="U2Zza9rb" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727612AbgBEXbJ (ORCPT ); Wed, 5 Feb 2020 18:31:09 -0500 Received: from us-smtp-2.mimecast.com ([207.211.31.81]:47154 "EHLO us-smtp-delivery-1.mimecast.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1727170AbgBEXbI (ORCPT ); Wed, 5 Feb 2020 18:31:08 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1580945467; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=SAORMzmA6IqKUOqDqPLoO/v1peidnLsrO16O4cWM3o8=; b=U2Zza9rbsdrqyD+4NHJv+GIruJND/YtSy4Z3t0ah6fg1/c8F/HAIsCqC3M0ezDxyU/5WY7 EkhuKAX1J/Ll3cw97cSBacgWw62VIjBNLqxoj5iMdEhQTc1LEL02qUPLbDVhZ9CHhSOIgg Noas+x3GakiwD70GzZWbcPxi7YqS/lk= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-297-n0VIlnPnOMSV8JdkF3Atnw-1; Wed, 05 Feb 2020 18:31:00 -0500 X-MC-Unique: n0VIlnPnOMSV8JdkF3Atnw-1 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.phx2.redhat.com [10.5.11.22]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 38AF59A1C9; Wed, 5 Feb 2020 23:30:58 +0000 (UTC) Received: from localhost (ovpn-12-19.pek2.redhat.com [10.72.12.19]) by smtp.corp.redhat.com (Postfix) with ESMTPS id E8FCE1001920; Wed, 5 Feb 2020 23:30:54 +0000 (UTC) Date: Thu, 6 Feb 2020 07:30:51 +0800 From: Baoquan He To: Wei Yang Cc: David Hildenbrand , linux-kernel@vger.kernel.org, linux-mm@kvack.org, linux-arm-kernel@lists.infradead.org, linux-ia64@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-s390@vger.kernel.org, linux-sh@vger.kernel.org, x86@kernel.org, Andrew Morton , Oscar Salvador , Michal Hocko , Pavel Tatashin , Dan Williams Subject: Re: [PATCH v6 08/10] mm/memory_hotplug: Don't check for "all holes" in shrink_zone_span() Message-ID: <20200205233051.GG8965@MiWiFi-R3L-srv> References: <20191006085646.5768-1-david@redhat.com> <20191006085646.5768-9-david@redhat.com> <20200205095924.GC24162@richard> <20200205144811.GF26758@MiWiFi-R3L-srv> <20200205225633.GA28446@richard> <20200205230826.GF8965@MiWiFi-R3L-srv> <20200205232620.GC28446@richard> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200205232620.GC28446@richard> User-Agent: Mutt/1.10.1 (2018-07-13) X-Scanned-By: MIMEDefang 2.84 on 10.5.11.22 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 02/06/20 at 07:26am, Wei Yang wrote: > On Thu, Feb 06, 2020 at 07:08:26AM +0800, Baoquan He wrote: > >On 02/06/20 at 06:56am, Wei Yang wrote: > >> On Wed, Feb 05, 2020 at 10:48:11PM +0800, Baoquan He wrote: > >> >Hi Wei Yang, > >> > > >> >On 02/05/20 at 05:59pm, Wei Yang wrote: > >> >> >diff --git a/mm/memory_hotplug.c b/mm/memory_hotplug.c > >> >> >index f294918f7211..8dafa1ba8d9f 100644 > >> >> >--- a/mm/memory_hotplug.c > >> >> >+++ b/mm/memory_hotplug.c > >> >> >@@ -393,6 +393,9 @@ static void shrink_zone_span(struct zone *zone, unsigned long start_pfn, > >> >> > if (pfn) { > >> >> > zone->zone_start_pfn = pfn; > >> >> > zone->spanned_pages = zone_end_pfn - pfn; > >> >> >+ } else { > >> >> >+ zone->zone_start_pfn = 0; > >> >> >+ zone->spanned_pages = 0; > >> >> > } > >> >> > } else if (zone_end_pfn == end_pfn) { > >> >> > /* > >> >> >@@ -405,34 +408,11 @@ static void shrink_zone_span(struct zone *zone, unsigned long start_pfn, > >> >> > start_pfn); > >> >> > if (pfn) > >> >> > zone->spanned_pages = pfn - zone_start_pfn + 1; > >> >> >+ else { > >> >> >+ zone->zone_start_pfn = 0; > >> >> >+ zone->spanned_pages = 0; > >> >> >+ } > >> >> > } > >> >> > >> >> If it is me, I would like to take out these two similar logic out. > >> > > >> >I also like this style. > >> >> > >> >> For example: > >> >> > >> >> if () { > >> >> } else if () { > >> >> } else { > >> >> goto out; > >> >Here the last else is unnecessary, right? > >> > > >> > >> I am afraid not. > >> > >> If the range is not the first or last, we would leave pfn not initialized. > > > >Ah, you are right. I forgot that one. Then pfn can be assigned the > >zone_start_pfn as the old code. Then the following logic is the same > >as the original code, find_smallest_section_pfn()/find_biggest_section_pfn() > >have done the iteration the old for loop was doing. > > > > unsigned long pfn = zone_start_pfn; > > if () { > > } else if () { > > } > > > > /* The zone has no valid section */ > > if (!pfn) { > > zone->zone_start_pfn = 0; > > zone->spanned_pages = 0; > > } > > This one look better :-) Thanks for your confirmation, I will make one patch like this and post.