linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: David Miller <davem@davemloft.net>
To: f.fainelli@gmail.com
Cc: netdev@vger.kernel.org, bcm-kernel-feedback-list@broadcom.com,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH net] net: systemport: Avoid RBUF stuck in Wake-on-LAN mode
Date: Thu, 06 Feb 2020 14:29:54 +0100 (CET)	[thread overview]
Message-ID: <20200206.142954.1457791883934476387.davem@davemloft.net> (raw)
In-Reply-To: <20200205203204.14511-1-f.fainelli@gmail.com>

From: Florian Fainelli <f.fainelli@gmail.com>
Date: Wed,  5 Feb 2020 12:32:04 -0800

> After a number of suspend and resume cycles, it is possible for the RBUF
> to be stuck in Wake-on-LAN mode, despite the MPD enable bit being
> cleared which instructed the RBUF to exit that mode.

Must be some weird state latching or something like that...

> Avoid creating that problematic condition by clearing the RX_EN and
> TX_EN bits in the UniMAC prior to disable the Magic Packet Detector
> logic which is guaranteed to make the RBUF exit Wake-on-LAN mode.
> 
> Fixes: 83e82f4c706b ("net: systemport: add Wake-on-LAN support")
> Signed-off-by: Florian Fainelli <f.fainelli@gmail.com>

Applied and queued up for -stable, thanks.

      reply	other threads:[~2020-02-06 13:29 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-02-05 20:32 [PATCH net] net: systemport: Avoid RBUF stuck in Wake-on-LAN mode Florian Fainelli
2020-02-06 13:29 ` David Miller [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200206.142954.1457791883934476387.davem@davemloft.net \
    --to=davem@davemloft.net \
    --cc=bcm-kernel-feedback-list@broadcom.com \
    --cc=f.fainelli@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).