From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.6 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_2 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 79E06C3F68F for ; Thu, 6 Feb 2020 11:24:58 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 47E5D214AF for ; Thu, 6 Feb 2020 11:24:58 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1580988298; bh=nveUzTkK3SAXe1XV2O7CxMbqKFRC1dGbyd31nxACb+I=; h=Date:From:To:Cc:Subject:In-Reply-To:References:List-ID:From; b=HTCKtepBylqOMSM0bFENBomb3abpj9mlaAv/0bogGIYgPYIU5XUnVkYvNsl/YJKKg D7faLH8Ba4jTA6NrDUBUM0jNLESrjOuMNUKRxijhGfy8/qQ13EjfI+i7L/fy0i4A6K 71vMY3axo6AWAZvj5hGvfmlzF3LyoLUJ9obKlo68= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727450AbgBFLY5 (ORCPT ); Thu, 6 Feb 2020 06:24:57 -0500 Received: from mail.kernel.org ([198.145.29.99]:58042 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726687AbgBFLY5 (ORCPT ); Thu, 6 Feb 2020 06:24:57 -0500 Received: from archlinux (cpc149474-cmbg20-2-0-cust94.5-4.cable.virginm.net [82.4.196.95]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id A706E20730; Thu, 6 Feb 2020 11:24:54 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1580988296; bh=nveUzTkK3SAXe1XV2O7CxMbqKFRC1dGbyd31nxACb+I=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=VND0uD4FlfS/1Uavbf+jM+n+nW4tbxmLvBxCDoEey4ltzMh5ovFcNqIAB0HZvptUl bib8JMh8q4tOSl94eRmFhxu1BjMEZmhLmK1k38ybIqx2MgnQZxxV6fUsOG6+1IK3WG SgjmqlqqAYh+w3lk0wvF9P7/qVclR+pUKl/KwK6Q= Date: Thu, 6 Feb 2020 11:24:50 +0000 From: Jonathan Cameron To: Guido =?UTF-8?B?R8O8bnRoZXI=?= Cc: Tomas Novotny , Hartmut Knaack , Lars-Peter Clausen , Peter Meerwald-Stadler , "Angus Ainslie (Purism)" , Marco Felsch , Thomas Gleixner , linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v3 1/2] iio: vcnl4000: Use a single return when getting IIO_CHAN_INFO_RAW Message-ID: <20200206112450.04004361@archlinux> In-Reply-To: <86e272aaf6726d6d5171445e7f2df6cdbb74057f.1580721204.git.agx@sigxcpu.org> References: <86e272aaf6726d6d5171445e7f2df6cdbb74057f.1580721204.git.agx@sigxcpu.org> X-Mailer: Claws Mail 3.17.4 (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 3 Feb 2020 10:17:01 +0100 Guido G=C3=BCnther wrote: > This will be useful when introducing runtime pm. >=20 > Signed-off-by: Guido G=C3=BCnther Applied. Thanks, Jonathan > --- > drivers/iio/light/vcnl4000.c | 15 ++++++++------- > 1 file changed, 8 insertions(+), 7 deletions(-) >=20 > diff --git a/drivers/iio/light/vcnl4000.c b/drivers/iio/light/vcnl4000.c > index b0e241aaefb4..8f198383626b 100644 > --- a/drivers/iio/light/vcnl4000.c > +++ b/drivers/iio/light/vcnl4000.c > @@ -335,17 +335,18 @@ static int vcnl4000_read_raw(struct iio_dev *indio_= dev, > switch (chan->type) { > case IIO_LIGHT: > ret =3D data->chip_spec->measure_light(data, val); > - if (ret < 0) > - return ret; > - return IIO_VAL_INT; > + if (!ret) > + ret =3D IIO_VAL_INT; > + break; > case IIO_PROXIMITY: > ret =3D data->chip_spec->measure_proximity(data, val); > - if (ret < 0) > - return ret; > - return IIO_VAL_INT; > + if (!ret) > + ret =3D IIO_VAL_INT; > + break; > default: > - return -EINVAL; > + ret =3D -EINVAL; > } > + return ret; > case IIO_CHAN_INFO_SCALE: > if (chan->type !=3D IIO_LIGHT) > return -EINVAL;