From: Mark Brown <broonie@kernel.org>
To: Chuanhong Guo <gch981213@gmail.com>
Cc: linux-spi@vger.kernel.org, linux-kernel@vger.kernel.org,
Rob Herring <robh+dt@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
devicetree@vger.kernel.org
Subject: Re: [PATCH resend 1/2] spi: add driver for ar934x spi controller
Date: Thu, 6 Feb 2020 11:31:58 +0000 [thread overview]
Message-ID: <20200206113158.GK3897@sirena.org.uk> (raw)
In-Reply-To: <20200206084443.209719-2-gch981213@gmail.com>
[-- Attachment #1: Type: text/plain, Size: 880 bytes --]
On Thu, Feb 06, 2020 at 04:44:42PM +0800, Chuanhong Guo wrote:
This looks good, just a couple of comments below:
> --- /dev/null
> +++ b/drivers/spi/spi-ar934x.c
> @@ -0,0 +1,230 @@
> +// SPDX-License-Identifier: GPL-2.0
> +/*
> + * SPI controller driver for Qualcomm Atheros AR934x/QCA95xx SoCs
Please make the entire comment block a C++ one so things look
more intentional.
> +static int ar934x_spi_transfer_one(struct spi_controller *master,
> + struct spi_message *m)
> +{
> + struct ar934x_spi *sp = spi_controller_get_devdata(master);
> + struct spi_transfer *t = NULL;
...
> +
> + m->actual_length = 0;
> + list_for_each_entry(t, &m->transfers, transfer_list) {
It looks like this could just be a transfer_one() operation
instead of transfer_one_message() (which is what this is in spite
of the name)? There's nothing custom outside this loop that I
can see.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2020-02-06 11:32 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-06 8:44 [PATCH resend 0/2] spi: add driver for ar934x spi controller Chuanhong Guo
2020-02-06 8:44 ` [PATCH resend 1/2] " Chuanhong Guo
2020-02-06 11:31 ` Mark Brown [this message]
2020-02-06 12:30 ` Chuanhong Guo
2020-02-06 12:33 ` Chuanhong Guo
2020-02-06 13:54 ` Mark Brown
2020-02-06 8:44 ` [PATCH resend 2/2] dt-binding: spi: add bindings for spi-ar934x Chuanhong Guo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200206113158.GK3897@sirena.org.uk \
--to=broonie@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=gch981213@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-spi@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).