From: Wei Huang <wei.huang2@amd.com>
To: Eric Auger <eric.auger@redhat.com>
Cc: eric.auger.pro@gmail.com, linux-kernel@vger.kernel.org,
kvm@vger.kernel.org, pbonzini@redhat.com, vkuznets@redhat.com,
thuth@redhat.com, drjones@redhat.com
Subject: Re: [PATCH v4 1/3] selftests: KVM: Replace get_gdt/idt_base() by get_gdt/idt()
Date: Thu, 6 Feb 2020 11:13:38 -0600 [thread overview]
Message-ID: <20200206171338.GB2465308@weiserver.amd.com> (raw)
In-Reply-To: <20200206104710.16077-2-eric.auger@redhat.com>
On 02/06 11:47, Eric Auger wrote:
> get_gdt_base() and get_idt_base() only return the base address
> of the descriptor tables. Soon we will need to get the size as well.
> Change the prototype of those functions so that they return
> the whole desc_ptr struct instead of the address field.
>
> Signed-off-by: Eric Auger <eric.auger@redhat.com>
> Reviewed-by: Vitaly Kuznetsov <vkuznets@redhat.com>
> Reviewed-by: Miaohe Lin <linmiaohe@huawei.com>
>
> ---
>
> v3 -> v4:
> - Collected R-b's
> ---
> tools/testing/selftests/kvm/include/x86_64/processor.h | 8 ++++----
> tools/testing/selftests/kvm/lib/x86_64/vmx.c | 6 +++---
> 2 files changed, 7 insertions(+), 7 deletions(-)
>
> diff --git a/tools/testing/selftests/kvm/include/x86_64/processor.h b/tools/testing/selftests/kvm/include/x86_64/processor.h
> index aa6451b3f740..6f7fffaea2e8 100644
> --- a/tools/testing/selftests/kvm/include/x86_64/processor.h
> +++ b/tools/testing/selftests/kvm/include/x86_64/processor.h
> @@ -220,20 +220,20 @@ static inline void set_cr4(uint64_t val)
> __asm__ __volatile__("mov %0, %%cr4" : : "r" (val) : "memory");
> }
>
> -static inline uint64_t get_gdt_base(void)
> +static inline struct desc_ptr get_gdt(void)
> {
> struct desc_ptr gdt;
> __asm__ __volatile__("sgdt %[gdt]"
> : /* output */ [gdt]"=m"(gdt));
> - return gdt.address;
> + return gdt;
> }
>
> -static inline uint64_t get_idt_base(void)
> +static inline struct desc_ptr get_idt(void)
> {
> struct desc_ptr idt;
> __asm__ __volatile__("sidt %[idt]"
> : /* output */ [idt]"=m"(idt));
> - return idt.address;
> + return idt;
> }
>
> #define SET_XMM(__var, __xmm) \
> diff --git a/tools/testing/selftests/kvm/lib/x86_64/vmx.c b/tools/testing/selftests/kvm/lib/x86_64/vmx.c
> index 85064baf5e97..7aaa99ca4dbc 100644
> --- a/tools/testing/selftests/kvm/lib/x86_64/vmx.c
> +++ b/tools/testing/selftests/kvm/lib/x86_64/vmx.c
> @@ -288,9 +288,9 @@ static inline void init_vmcs_host_state(void)
> vmwrite(HOST_FS_BASE, rdmsr(MSR_FS_BASE));
> vmwrite(HOST_GS_BASE, rdmsr(MSR_GS_BASE));
> vmwrite(HOST_TR_BASE,
> - get_desc64_base((struct desc64 *)(get_gdt_base() + get_tr())));
> - vmwrite(HOST_GDTR_BASE, get_gdt_base());
> - vmwrite(HOST_IDTR_BASE, get_idt_base());
> + get_desc64_base((struct desc64 *)(get_gdt().address + get_tr())));
> + vmwrite(HOST_GDTR_BASE, get_gdt().address);
> + vmwrite(HOST_IDTR_BASE, get_idt().address);
> vmwrite(HOST_IA32_SYSENTER_ESP, rdmsr(MSR_IA32_SYSENTER_ESP));
> vmwrite(HOST_IA32_SYSENTER_EIP, rdmsr(MSR_IA32_SYSENTER_EIP));
> }
Reviewed-by: Wei Huang <wei.huang2@amd.com>
next prev parent reply other threads:[~2020-02-06 17:13 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-06 10:47 [PATCH v4 0/3] selftests: KVM: AMD Nested SVM test infrastructure Eric Auger
2020-02-06 10:47 ` [PATCH v4 1/3] selftests: KVM: Replace get_gdt/idt_base() by get_gdt/idt() Eric Auger
2020-02-06 17:13 ` Wei Huang [this message]
2020-02-06 19:17 ` Krish Sadhukhan
2020-02-06 10:47 ` [PATCH v4 2/3] selftests: KVM: AMD Nested test infrastructure Eric Auger
2020-02-06 12:20 ` Vitaly Kuznetsov
2020-02-06 12:27 ` Auger Eric
2020-02-06 22:57 ` Krish Sadhukhan
2020-02-07 9:16 ` Vitaly Kuznetsov
2020-02-07 14:16 ` Auger Eric
2020-02-12 11:38 ` Paolo Bonzini
2020-02-06 10:47 ` [PATCH v4 3/3] selftests: KVM: SVM: Add vmcall test Eric Auger
2020-02-06 17:39 ` Wei Huang
2020-02-06 19:08 ` Krish Sadhukhan
2020-02-07 10:05 ` Auger Eric
2020-02-07 10:15 ` Auger Eric
2020-02-12 11:43 ` Paolo Bonzini
2020-02-06 22:46 ` Krish Sadhukhan
2020-02-07 14:06 ` Auger Eric
2020-02-12 11:45 ` Paolo Bonzini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200206171338.GB2465308@weiserver.amd.com \
--to=wei.huang2@amd.com \
--cc=drjones@redhat.com \
--cc=eric.auger.pro@gmail.com \
--cc=eric.auger@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pbonzini@redhat.com \
--cc=thuth@redhat.com \
--cc=vkuznets@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).