From: Rob Herring <robh@kernel.org>
To: min.li.xe@renesas.com
Cc: mark.rutland@arm.com, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] dt-bindings: ptp: Add IDT 82P33 based PTP clock
Date: Thu, 6 Feb 2020 17:48:26 +0000 [thread overview]
Message-ID: <20200206174826.GA6395@bogus> (raw)
In-Reply-To: <1580326471-5389-1-git-send-email-min.li.xe@renesas.com>
On Wed, Jan 29, 2020 at 02:34:31PM -0500, min.li.xe@renesas.com wrote:
> From: Min Li <min.li.xe@renesas.com>
>
> Add device tree binding doc for the PTP clock based on IDT 82P33
> Synchronization Management Unit (SMU).
>
> Signed-off-by: Min Li <min.li.xe@renesas.com>
> ---
> .../devicetree/bindings/ptp/ptp-idt82p33.yaml | 47 ++++++++++++++++++++++
> 1 file changed, 47 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/ptp/ptp-idt82p33.yaml
>
> diff --git a/Documentation/devicetree/bindings/ptp/ptp-idt82p33.yaml b/Documentation/devicetree/bindings/ptp/ptp-idt82p33.yaml
> new file mode 100644
> index 0000000..11d1b40
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/ptp/ptp-idt82p33.yaml
> @@ -0,0 +1,47 @@
> +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/ptp/ptp-idt82p33.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: IDT 82P33 PTP Clock Device Tree Bindings
> +
> +description: |
> + IDT 82P33XXX Synchronization Management Unit (SMU) based PTP clock
> +
> +maintainers:
> + - Min Li <min.li.xe@renesas.com>
> +
> +properties:
> + compatible:
> + enum:
> + - idt,82p33810
> + - idt,82p33813
> + - idt,82p33814
> + - idt,82p33831
> + - idt,82p33910
> + - idt,82p33913
> + - idt,82p33914
> + - idt,82p33931
> +
> + reg:
> + maxItems: 1
> + description:
> + I2C slave address of the device.
Can drop the description. That's every device.
> +
> +required:
> + - compatible
> + - reg
> +
> +examples:
> + - |
> + i2c@1 {
> + compatible = "abc,acme-1234";
> + reg = <0x01 0x400>;
Just do:
i2c {
Eventually undocumented compatibles are going to throw warnings.
> + #address-cells = <1>;
> + #size-cells = <0>;
> + phc@51 {
> + compatible = "idt,82p33810";
> + reg = <0x51>;
> + };
> + };
> --
> 2.7.4
>
prev parent reply other threads:[~2020-02-06 20:47 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-29 19:34 [PATCH 1/2] dt-bindings: ptp: Add IDT 82P33 based PTP clock min.li.xe
2020-02-06 17:48 ` Rob Herring [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200206174826.GA6395@bogus \
--to=robh@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=min.li.xe@renesas.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).