From: Tushar Sugandhi <tusharsu@linux.microsoft.com>
To: zohar@linux.ibm.com, linux-integrity@vger.kernel.org
Cc: sashal@kernel.org, nramas@linux.microsoft.com,
linux-kernel@vger.kernel.org
Subject: [PATCH] IMA: Add log statements for failure conditions.
Date: Fri, 7 Feb 2020 11:53:46 -0800 [thread overview]
Message-ID: <20200207195346.4017-2-tusharsu@linux.microsoft.com> (raw)
In-Reply-To: <20200207195346.4017-1-tusharsu@linux.microsoft.com>
process_buffer_measurement() and ima_alloc_key_entry()
functions do not have log messages for failure conditions.
This change adds log statements in the above functions.
Signed-off-by: Tushar Sugandhi <tusharsu@linux.microsoft.com>
Reviewed-by: Lakshmi Ramasubramanian <nramas@linux.microsoft.com>
---
security/integrity/ima/ima_main.c | 4 ++++
security/integrity/ima/ima_queue_keys.c | 2 ++
2 files changed, 6 insertions(+)
diff --git a/security/integrity/ima/ima_main.c b/security/integrity/ima/ima_main.c
index 9fe949c6a530..afab796fb765 100644
--- a/security/integrity/ima/ima_main.c
+++ b/security/integrity/ima/ima_main.c
@@ -757,6 +757,10 @@ void process_buffer_measurement(const void *buf, int size,
ima_free_template_entry(entry);
out:
+ if (ret < 0)
+ pr_err("Process buffer measurement failed, result: %d\n",
+ ret);
+
return;
}
diff --git a/security/integrity/ima/ima_queue_keys.c b/security/integrity/ima/ima_queue_keys.c
index c87c72299191..2cc52f17ea81 100644
--- a/security/integrity/ima/ima_queue_keys.c
+++ b/security/integrity/ima/ima_queue_keys.c
@@ -90,6 +90,8 @@ static struct ima_key_entry *ima_alloc_key_entry(struct key *keyring,
out:
if (rc) {
+ pr_err("Key entry allocation failed, result: %d\n",
+ rc);
ima_free_key_entry(entry);
entry = NULL;
}
--
2.17.1
next prev parent reply other threads:[~2020-02-07 19:53 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-07 19:53 [PATCH] IMA: Updated KBUILD_MODNAME for IMA files to ima Tushar Sugandhi
2020-02-07 19:53 ` Tushar Sugandhi [this message]
2020-02-09 12:57 ` [PATCH] IMA: Add log statements for failure conditions Mimi Zohar
2020-02-10 2:46 ` Joe Perches
2020-02-10 16:40 ` Lakshmi Ramasubramanian
2020-02-10 16:50 ` Joe Perches
2020-02-10 21:42 ` Tushar Sugandhi
[not found] ` <0c9099b5-da29-3e71-0933-123dfe08442c@linux.microsoft.com>
2020-02-10 21:46 ` Mimi Zohar
2020-02-10 22:19 ` Tushar Sugandhi
2020-06-04 16:32 Lakshmi Ramasubramanian
2020-06-05 18:46 ` Mimi Zohar
2020-06-05 19:37 ` Paul Moore
2020-06-05 19:54 ` Lakshmi Ramasubramanian
2020-06-05 20:49 ` Paul Moore
2020-06-05 21:09 ` Lakshmi Ramasubramanian
2020-06-05 21:34 ` Mimi Zohar
2020-06-05 21:36 ` Lakshmi Ramasubramanian
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200207195346.4017-2-tusharsu@linux.microsoft.com \
--to=tusharsu@linux.microsoft.com \
--cc=linux-integrity@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nramas@linux.microsoft.com \
--cc=sashal@kernel.org \
--cc=zohar@linux.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).