From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.4 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 07E7BC35254 for ; Mon, 10 Feb 2020 03:45:45 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id D2E2B206ED for ; Mon, 10 Feb 2020 03:45:44 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="NSN/AZqa" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727143AbgBJDpo (ORCPT ); Sun, 9 Feb 2020 22:45:44 -0500 Received: from us-smtp-2.mimecast.com ([207.211.31.81]:30312 "EHLO us-smtp-delivery-1.mimecast.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1726958AbgBJDpn (ORCPT ); Sun, 9 Feb 2020 22:45:43 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1581306342; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=iWBQGkhL7pMP44aJ/Ujz98H3OqbOFFDFle3KjBh04+o=; b=NSN/AZqa9QFPoGTfNwBLPxVLg3J81aXCJDJkznUyqrqfQxJI3jvV2uS/mmrkDDgIPkHMzy A/ut3kPzEcPRm8H8U0AjjAo61cVL4im8vV9qJXykLC1JwUbKYC9V7a+W4Wt2T+V7W9OqLh Man/GxtExkHkiszIZbiD7DbMFJHQhvA= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-101-xm68Pfv-Ob-C78m_NhDL5Q-1; Sun, 09 Feb 2020 22:45:38 -0500 X-MC-Unique: xm68Pfv-Ob-C78m_NhDL5Q-1 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id B363818A5502; Mon, 10 Feb 2020 03:45:36 +0000 (UTC) Received: from localhost (ovpn-12-27.pek2.redhat.com [10.72.12.27]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 9BE1D857B4; Mon, 10 Feb 2020 03:45:33 +0000 (UTC) Date: Mon, 10 Feb 2020 11:45:31 +0800 From: Baoquan He To: linux-kernel@vger.kernel.org Cc: linux-mm@kvack.org, akpm@linux-foundation.org, dan.j.williams@intel.com, richardw.yang@linux.intel.com, david@redhat.com Subject: Re: [PATCH 6/7] mm/sparsemem: pfn_to_page is not valid yet on SPARSEMEM Message-ID: <20200210034531.GB8965@MiWiFi-R3L-srv> References: <20200209104826.3385-1-bhe@redhat.com> <20200209104826.3385-7-bhe@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200209104826.3385-7-bhe@redhat.com> User-Agent: Mutt/1.10.1 (2018-07-13) X-Scanned-By: MIMEDefang 2.79 on 10.5.11.11 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 02/09/20 at 06:48pm, Baoquan He wrote: > From: Wei Yang > > When we use SPARSEMEM instead of SPARSEMEM_VMEMMAP, pfn_to_page() > doesn't work before sparse_init_one_section() is called. This leads to a > crash when hotplug memory. > > PGD 0 P4D 0 > Oops: 0002 [#1] SMP PTI > CPU: 3 PID: 8 Comm: kworker/u16:0 Tainted: G W 5.5.0-next-20200205+ #339 > Hardware name: QEMU Standard PC (i440FX + PIIX, 1996), BIOS 0.0.0 02/06/2015 > Workqueue: kacpi_hotplug acpi_hotplug_work_fn > RIP: 0010:__memset+0x24/0x30 > Call Trace: > sparse_add_section+0x150/0x1d8 > __add_pages+0xbf/0x150 > add_pages+0x12/0x60 > add_memory_resource+0xc8/0x210 > ? wake_up_q+0xa0/0xa0 > __add_memory+0x62/0xb0 > acpi_memory_device_add+0x13f/0x300 > acpi_bus_attach+0xf6/0x200 > acpi_bus_scan+0x43/0x90 > acpi_device_hotplug+0x275/0x3d0 > acpi_hotplug_work_fn+0x1a/0x30 > process_one_work+0x1a7/0x370 > worker_thread+0x30/0x380 > ? flush_rcu_work+0x30/0x30 > kthread+0x112/0x130 > ? kthread_create_on_node+0x60/0x60 > ret_from_fork+0x35/0x40 > > We should use memmap as it did. > > Fixes: ba72b4c8cf60 ("mm/sparsemem: support sub-section hotplug") > Signed-off-by: Wei Yang > Acked-by: David Hildenbrand > Reviewed-by: Baoquan He > CC: Dan Williams > Signed-off-by: Baoquan He Git format-patch added this line of Signed-off-by from me, I will remove it if repost. > --- > mm/sparse.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/mm/sparse.c b/mm/sparse.c > index a7e78bfe0dce..623755e88255 100644 > --- a/mm/sparse.c > +++ b/mm/sparse.c > @@ -944,7 +944,7 @@ int __meminit sparse_add_section(int nid, unsigned long start_pfn, > * Poison uninitialized struct pages in order to catch invalid flags > * combinations. > */ > - page_init_poison(pfn_to_page(start_pfn), sizeof(struct page) * nr_pages); > + page_init_poison(memmap, sizeof(struct page) * nr_pages); > > ms = __nr_to_section(section_nr); > set_section_nid(section_nr, nid); > -- > 2.17.2 >