From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6773CC352A4 for ; Mon, 10 Feb 2020 13:25:22 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 4076E208C4 for ; Mon, 10 Feb 2020 13:25:22 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1581341122; bh=wtW89bBfKdH7PmZru2C2Udx1iv4td43s5/oTi/Bh334=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=VbpnIl7oJ+tzCD/8YptVHlZDvSkOUinloepWMgW9uKizV90tu2yKNOELQ20VZvxED 1R7PM4u8K8N40jbskZ4Mz3B6iCKQjCXhafwnxrgmhPcrD5N7oqcfZB7hwI5ejSfqh/ Nh4vK8Fg740bWikM9z3ZJDy/qfMhaGLXkHsjWhhk= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728571AbgBJMg4 (ORCPT ); Mon, 10 Feb 2020 07:36:56 -0500 Received: from mail.kernel.org ([198.145.29.99]:54378 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728196AbgBJMf7 (ORCPT ); Mon, 10 Feb 2020 07:35:59 -0500 Received: from localhost (unknown [209.37.97.194]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id D32C021734; Mon, 10 Feb 2020 12:35:58 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1581338158; bh=wtW89bBfKdH7PmZru2C2Udx1iv4td43s5/oTi/Bh334=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=TbOV+gf0IAk9RUVMrxv/iPy0Io3wZ2iQpxEcWj7w4Ry606P6WVD3eK1uId8Wk3lcF g3LBA0udq1ISjHQ99A3wjIPjbziUnhNYGFDvciv2Y6HSFZNxDofjseLVNaWzNcBaKJ jZe879dtIse+IPPmE3SXpc0hYXZEdoiTMq2V3my0= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Stefan Bader , Mike Snitzer Subject: [PATCH 4.19 089/195] dm: fix potential for q->make_request_fn NULL pointer Date: Mon, 10 Feb 2020 04:32:27 -0800 Message-Id: <20200210122314.067315689@linuxfoundation.org> X-Mailer: git-send-email 2.25.0 In-Reply-To: <20200210122305.731206734@linuxfoundation.org> References: <20200210122305.731206734@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Mike Snitzer commit 47ace7e012b9f7ad71d43ac9063d335ea3d6820b upstream. Move blk_queue_make_request() to dm.c:alloc_dev() so that q->make_request_fn is never NULL during the lifetime of a DM device (even one that is created without a DM table). Otherwise generic_make_request() will crash simply by doing: dmsetup create -n test mount /dev/dm-N /mnt While at it, move ->congested_data initialization out of dm.c:alloc_dev() and into the bio-based specific init method. Reported-by: Stefan Bader BugLink: https://bugs.launchpad.net/bugs/1860231 Fixes: ff36ab34583a ("dm: remove request-based logic from make_request_fn wrapper") Depends-on: c12c9a3c3860c ("dm: various cleanups to md->queue initialization code") Cc: stable@vger.kernel.org Signed-off-by: Mike Snitzer Signed-off-by: Greg Kroah-Hartman --- drivers/md/dm.c | 9 +++++++-- 1 file changed, 7 insertions(+), 2 deletions(-) --- a/drivers/md/dm.c +++ b/drivers/md/dm.c @@ -1819,6 +1819,7 @@ static void dm_init_normal_md_queue(stru /* * Initialize aspects of queue that aren't relevant for blk-mq */ + md->queue->backing_dev_info->congested_data = md; md->queue->backing_dev_info->congested_fn = dm_any_congested; } @@ -1913,7 +1914,12 @@ static struct mapped_device *alloc_dev(i if (!md->queue) goto bad; md->queue->queuedata = md; - md->queue->backing_dev_info->congested_data = md; + /* + * default to bio-based required ->make_request_fn until DM + * table is loaded and md->type established. If request-based + * table is loaded: blk-mq will override accordingly. + */ + blk_queue_make_request(md->queue, dm_make_request); md->disk = alloc_disk_node(1, md->numa_node_id); if (!md->disk) @@ -2242,7 +2248,6 @@ int dm_setup_md_queue(struct mapped_devi case DM_TYPE_BIO_BASED: case DM_TYPE_DAX_BIO_BASED: dm_init_normal_md_queue(md); - blk_queue_make_request(md->queue, dm_make_request); break; case DM_TYPE_NVME_BIO_BASED: dm_init_normal_md_queue(md);