From: Dmitry Safonov <dima@arista.com>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: linux-kernel@vger.kernel.org,
Dmitry Safonov <0x7f454c46@gmail.com>,
Dmitry Safonov <dima@arista.com>,
Linus Torvalds <torvalds@linux-foundation.org>,
Peter Zijlstra <peterz@infradead.org>,
Thomas Gleixner <tglx@linutronix.de>,
Josh Poimboeuf <jpoimboe@redhat.com>,
Ingo Molnar <mingo@kernel.org>
Subject: [PATCH-4.19-stable 0/2] Backport ENCODE_FRAME_POINTER hint
Date: Mon, 10 Feb 2020 14:05:41 +0000 [thread overview]
Message-ID: <20200210140543.79641-1-dima@arista.com> (raw)
On 4.19.93 the following warning was observed with CONFIG_FRAME_POINTER:
> WARNING: kernel stack frame pointer at 00000000bceb5183 in Coronavirus:3282 has bad value (null)
> unwind stack type:0 next_sp: (null) mask:0x2 graph_idx:0
> 000000009630aa47: ffffc9000126fdb0 (0xffffc9000126fdb0)
> 0000000020360f53: ffffffff81038e33 (__save_stack_trace+0xcb/0xee)
> 00000000675081f2: 0000000000000000 ...
> 0000000043198fe7: ffffc9000126c000 (0xffffc9000126c000)
> 0000000008a46231: ffffc90001270000 (0xffffc90001270000)
[..]
It turns to be missing %rbp hint was making frame pointer unwinder
a bit tipsy.
The observed is WARN_ONCE(), so it one time per boot, but imho, worth to
have in stable too.
Peter Zijlstra (2):
x86/stackframe: Move ENCODE_FRAME_POINTER to asm/frame.h
x86/stackframe, x86/ftrace: Add pt_regs frame annotations
arch/x86/entry/calling.h | 15 -----------
arch/x86/entry/entry_32.S | 16 ------------
arch/x86/include/asm/frame.h | 49 ++++++++++++++++++++++++++++++++++++
arch/x86/kernel/ftrace_32.S | 3 +++
arch/x86/kernel/ftrace_64.S | 3 +++
5 files changed, 55 insertions(+), 31 deletions(-)
--
2.25.0
next reply other threads:[~2020-02-10 14:05 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-10 14:05 Dmitry Safonov [this message]
2020-02-10 14:05 ` [PATCH-4.19-stable 1/2] x86/stackframe: Move ENCODE_FRAME_POINTER to asm/frame.h Dmitry Safonov
2020-02-10 14:05 ` [PATCH-4.19-stable 2/2] x86/stackframe, x86/ftrace: Add pt_regs frame annotations Dmitry Safonov
2020-02-13 15:01 ` [PATCH-4.19-stable 0/2] Backport ENCODE_FRAME_POINTER hint Greg Kroah-Hartman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200210140543.79641-1-dima@arista.com \
--to=dima@arista.com \
--cc=0x7f454c46@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=jpoimboe@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=peterz@infradead.org \
--cc=tglx@linutronix.de \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).