linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Will Deacon <will@kernel.org>
To: Wu Hao <hao.wu@intel.com>
Cc: mdf@kernel.org, mark.rutland@arm.com, gregkh@linuxfoundation.org,
	linux-fpga@vger.kernel.org, linux-kernel@vger.kernel.org,
	linux-api@vger.kernel.org, atull@kernel.org, yilun.xu@intel.com,
	Luwei Kang <luwei.kang@intel.com>
Subject: Re: [PATCH v7 2/2] fpga: dfl: fme: add performance reporting support
Date: Mon, 10 Feb 2020 16:34:01 +0000	[thread overview]
Message-ID: <20200210163400.GA21900@willie-the-truck> (raw)
In-Reply-To: <1581306469-22629-3-git-send-email-hao.wu@intel.com>

Hi,

On Mon, Feb 10, 2020 at 11:47:49AM +0800, Wu Hao wrote:
> This patch adds support for performance reporting private feature
> for FPGA Management Engine (FME). Now it supports several different
> performance counters, including 'basic', 'cache', 'fabric', 'vtd'
> and 'vtd_sip'. It allows user to use standard linux tools to access
> these performance counters.

I had a quick look at this, and it mostly looks alright to me. Just a few
high-level comments/questions:

  - I would still prefer for the PMU drivers to live under drivers/perf/

  - You should probably give the PMU a better name than "fme%d", for example
    "intel_fpga_dfl_fme%d".

  - CPU0 can be hotplugged off on non-x86 systems. How do you cope with
    that?

  - readq() will emit 2x32-bit reads on some architectures. What happens
    in this case?

Will

  reply	other threads:[~2020-02-10 16:34 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-02-10  3:47 [PATCH v7 0/2] add performance reporting support to FPGA DFL drivers Wu Hao
2020-02-10  3:47 ` [PATCH v7 1/2] Documentation: fpga: dfl: add description for performance reporting support Wu Hao
2020-02-10  3:47 ` [PATCH v7 2/2] fpga: dfl: fme: add " Wu Hao
2020-02-10 16:34   ` Will Deacon [this message]
2020-02-12  3:19     ` Wu Hao
2020-02-12  5:30       ` Greg KH
2020-02-12 10:02         ` Wu Hao
2020-02-12 13:20           ` Greg KH
2020-02-13  2:51             ` Wu Hao
2020-02-10 20:56   ` Greg KH
2020-02-12  2:39     ` Wu Hao

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200210163400.GA21900@willie-the-truck \
    --to=will@kernel.org \
    --cc=atull@kernel.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=hao.wu@intel.com \
    --cc=linux-api@vger.kernel.org \
    --cc=linux-fpga@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=luwei.kang@intel.com \
    --cc=mark.rutland@arm.com \
    --cc=mdf@kernel.org \
    --cc=yilun.xu@intel.com \
    --subject='Re: [PATCH v7 2/2] fpga: dfl: fme: add performance reporting support' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).