From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.6 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DDE4CC352A3 for ; Mon, 10 Feb 2020 16:34:08 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id B3BED2080C for ; Mon, 10 Feb 2020 16:34:08 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1581352448; bh=M1hd3p9CfdbpxNt92LvggRQSIKAyGUl2mET37GiGwb4=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=U0/4rvN3ijJvXBb+6HL2W9M2UzYZaFp3zCTEgzPsT0+AXGpH1W9KEouAxJsoNkuOH o+zAIISD50ETZOMsH/p2gacpddztp2h2ON4567TFwRqSBvnH1TtwHjmUpmSOsRlSnN QdQRUQf1wM/w2ERmfK9LEBwn1TO1SFcM5kpFjOhk= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727965AbgBJQeH (ORCPT ); Mon, 10 Feb 2020 11:34:07 -0500 Received: from mail.kernel.org ([198.145.29.99]:36948 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727640AbgBJQeG (ORCPT ); Mon, 10 Feb 2020 11:34:06 -0500 Received: from willie-the-truck (236.31.169.217.in-addr.arpa [217.169.31.236]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 83BE42085B; Mon, 10 Feb 2020 16:34:04 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1581352446; bh=M1hd3p9CfdbpxNt92LvggRQSIKAyGUl2mET37GiGwb4=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=USLhZXtzCssL6tE52ftuZWqw+kDdKDOY2DEkJ8Nq9CoKd2ivfCUakOsUtt6txO8ue z/snzuxStwbUXtXTNXQDA22n1aWldWd/aTI5bEfQWKXQZn6+wPpH5IjbU+zTfTDFbV TFmEGG5XJQHUIHMGzNL9LnpS2p2JjDueUGbgds+o= Date: Mon, 10 Feb 2020 16:34:01 +0000 From: Will Deacon To: Wu Hao Cc: mdf@kernel.org, mark.rutland@arm.com, gregkh@linuxfoundation.org, linux-fpga@vger.kernel.org, linux-kernel@vger.kernel.org, linux-api@vger.kernel.org, atull@kernel.org, yilun.xu@intel.com, Luwei Kang Subject: Re: [PATCH v7 2/2] fpga: dfl: fme: add performance reporting support Message-ID: <20200210163400.GA21900@willie-the-truck> References: <1581306469-22629-1-git-send-email-hao.wu@intel.com> <1581306469-22629-3-git-send-email-hao.wu@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1581306469-22629-3-git-send-email-hao.wu@intel.com> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, On Mon, Feb 10, 2020 at 11:47:49AM +0800, Wu Hao wrote: > This patch adds support for performance reporting private feature > for FPGA Management Engine (FME). Now it supports several different > performance counters, including 'basic', 'cache', 'fabric', 'vtd' > and 'vtd_sip'. It allows user to use standard linux tools to access > these performance counters. I had a quick look at this, and it mostly looks alright to me. Just a few high-level comments/questions: - I would still prefer for the PMU drivers to live under drivers/perf/ - You should probably give the PMU a better name than "fme%d", for example "intel_fpga_dfl_fme%d". - CPU0 can be hotplugged off on non-x86 systems. How do you cope with that? - readq() will emit 2x32-bit reads on some architectures. What happens in this case? Will