From: Waiman Long <longman@redhat.com>
To: Peter Zijlstra <peterz@infradead.org>,
Ingo Molnar <mingo@redhat.com>, Will Deacon <will@kernel.org>,
Christoph Lameter <cl@linux.com>,
Pekka Enberg <penberg@kernel.org>,
David Rientjes <rientjes@google.com>,
Joonsoo Kim <iamjoonsoo.kim@lge.com>,
Andrew Morton <akpm@linux-foundation.org>
Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org,
Waiman Long <longman@redhat.com>
Subject: [PATCH 2/3] locking/mutex: Enable some lock event counters
Date: Mon, 10 Feb 2020 15:46:50 -0500 [thread overview]
Message-ID: <20200210204651.21674-3-longman@redhat.com> (raw)
In-Reply-To: <20200210204651.21674-1-longman@redhat.com>
Add a preliminary set of mutex locking event counters.
Signed-off-by: Waiman Long <longman@redhat.com>
---
kernel/locking/lock_events_list.h | 9 +++++++++
kernel/locking/mutex.c | 9 ++++++++-
2 files changed, 17 insertions(+), 1 deletion(-)
diff --git a/kernel/locking/lock_events_list.h b/kernel/locking/lock_events_list.h
index 239039d0ce21..90db996f0608 100644
--- a/kernel/locking/lock_events_list.h
+++ b/kernel/locking/lock_events_list.h
@@ -69,3 +69,12 @@ LOCK_EVENT(rwsem_rlock_handoff) /* # of read lock handoffs */
LOCK_EVENT(rwsem_wlock) /* # of write locks acquired */
LOCK_EVENT(rwsem_wlock_fail) /* # of failed write lock acquisitions */
LOCK_EVENT(rwsem_wlock_handoff) /* # of write lock handoffs */
+
+/*
+ * Locking events for mutex
+ */
+LOCK_EVENT(mutex_slowpath) /* # of mutex sleeping slowpaths */
+LOCK_EVENT(mutex_optspin) /* # of successful optimistic spinnings */
+LOCK_EVENT(mutex_timeout) /* # of mutex timeouts */
+LOCK_EVENT(mutex_sleep) /* # of mutex sleeps */
+LOCK_EVENT(mutex_handoff) /* # of mutex lock handoffs */
diff --git a/kernel/locking/mutex.c b/kernel/locking/mutex.c
index 976179a4ed9e..1c5c252ce6fb 100644
--- a/kernel/locking/mutex.c
+++ b/kernel/locking/mutex.c
@@ -36,6 +36,7 @@
#else
# include "mutex.h"
#endif
+#include "lock_events.h"
void
__mutex_init(struct mutex *lock, const char *name, struct lock_class_key *key)
@@ -996,10 +997,12 @@ __mutex_lock_common(struct mutex *lock, long state, unsigned int subclass,
lock_acquired(&lock->dep_map, ip);
if (use_ww_ctx && ww_ctx)
ww_mutex_set_context_fastpath(ww, ww_ctx);
+ lockevent_inc(mutex_optspin);
preempt_enable();
return 0;
}
+ lockevent_inc(mutex_slowpath);
spin_lock(&lock->wait_lock);
/*
* After waiting to acquire the wait_lock, try again.
@@ -1069,12 +1072,14 @@ __mutex_lock_common(struct mutex *lock, long state, unsigned int subclass,
to = mutex_setup_hrtimer(&timer_sleeper,
timeout);
if (!to || !to->task) {
+ lockevent_inc(mutex_timeout);
ret = -ETIMEDOUT;
goto err;
}
}
spin_unlock(&lock->wait_lock);
+ lockevent_inc(mutex_sleep);
schedule_preempt_disabled();
/*
@@ -1083,8 +1088,10 @@ __mutex_lock_common(struct mutex *lock, long state, unsigned int subclass,
*/
if ((use_ww_ctx && ww_ctx) || !first) {
first = __mutex_waiter_is_first(lock, &waiter);
- if (first)
+ if (first) {
__mutex_set_flag(lock, MUTEX_FLAG_HANDOFF);
+ lockevent_inc(mutex_handoff);
+ }
}
set_current_state(state);
--
2.18.1
next prev parent reply other threads:[~2020-02-10 20:48 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-10 20:46 [PATCH 0/3] locking/mutex: Add mutex_timed_lock() to solve potential deadlock problems Waiman Long
2020-02-10 20:46 ` [PATCH 1/3] locking/mutex: Add mutex_timed_lock() Waiman Long
2020-02-10 20:46 ` Waiman Long [this message]
2020-02-10 20:46 ` [PATCH 3/3] mm/slub: Fix potential deadlock problem in slab_attr_store() Waiman Long
2020-02-10 22:03 ` Andrew Morton
2020-02-10 22:14 ` Waiman Long
2020-02-10 23:10 ` Andrew Morton
2020-02-11 23:30 ` Waiman Long
2020-02-12 20:40 ` Waiman Long
2020-02-13 12:22 ` kbuild test robot
2020-02-13 16:48 ` kbuild test robot
2020-02-11 12:31 ` [PATCH 0/3] locking/mutex: Add mutex_timed_lock() to solve potential deadlock problems Peter Zijlstra
2020-02-11 23:31 ` Waiman Long
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200210204651.21674-3-longman@redhat.com \
--to=longman@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=cl@linux.com \
--cc=iamjoonsoo.kim@lge.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mingo@redhat.com \
--cc=penberg@kernel.org \
--cc=peterz@infradead.org \
--cc=rientjes@google.com \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).