From: Minchan Kim <minchan@kernel.org>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: LKML <linux-kernel@vger.kernel.org>,
linux-mm <linux-mm@kvack.org>,
linux-api@vger.kernel.org, oleksandr@redhat.com,
Suren Baghdasaryan <surenb@google.com>,
Tim Murray <timmurray@google.com>,
Daniel Colascione <dancol@google.com>,
Sandeep Patil <sspatil@google.com>,
Sonny Rao <sonnyrao@google.com>,
Brian Geffon <bgeffon@google.com>, Michal Hocko <mhocko@suse.com>,
Johannes Weiner <hannes@cmpxchg.org>,
Shakeel Butt <shakeelb@google.com>,
John Dias <joaodias@google.com>,
Joel Fernandes <joel@joelfernandes.org>
Subject: Re: [PATCH v3 0/5] introduce memory hinting API for external process
Date: Mon, 10 Feb 2020 13:29:06 -0800 [thread overview]
Message-ID: <20200210212906.GB48790@google.com> (raw)
In-Reply-To: <20200128001641.5086-1-minchan@kernel.org>
Hey Folks,
Can I get review further since I resolved most of concerns(especially,
description stuff) I got from previous iteration?
On Mon, Jan 27, 2020 at 04:16:36PM -0800, Minchan Kim wrote:
> Now, we have MADV_PAGEOUT and MADV_COLD as madvise hinting API. With that,
> application could give hints to kernel what memory range are preferred to be
> reclaimed. However, in some platform(e.g., Android), the information
> required to make the hinting decision is not known to the app.
> Instead, it is known to a centralized userspace daemon(e.g., ActivityManagerService),
> and that daemon must be able to initiate reclaim on its own without any app
> involvement.
>
> To solve the concern, this patch introduces new syscall - process_madvise(2).
> Bascially, it's same with madvise(2) syscall but it has some differences.
>
> 1. It needs pidfd of target process to provide the hint
> 2. It supports only MADV_{COLD|PAGEOUT|MERGEABLE|UNMEREABLE} at this moment.
> Other hints in madvise will be opened when there are explicit requests from
> community to prevent unexpected bugs we couldn't support.
> 3. Only privileged processes can do something for other process's address
> space.
>
> For more detail of the new API, please see "mm: introduce external memory hinting API"
> description in this patchset.
>
> Minchan Kim (3):
> mm: factor out madvise's core functionality
> mm: introduce external memory hinting API
> mm: support both pid and pidfd for process_madvise
>
> Oleksandr Natalenko (2):
> mm/madvise: employ mmget_still_valid for write lock
> mm/madvise: allow KSM hints for remote API
>
> * from v2 - https://lore.kernel.org/linux-mm/20200116235953.163318-1-minchan@kernel.org/
> * check signal callee and caller to bail out - Kirill Tkhai
> * put more clarification for justification of new API
>
> * from v1 - https://lore.kernel.org/linux-mm/20200110213433.94739-1-minchan@kernel.org/
> * fix syscall number - SeongJae
> * use get_pid_task - Kirill Tkhai
> * extend API to support pid as well as pidfd - Kirill Tkhai
>
> arch/alpha/kernel/syscalls/syscall.tbl | 1 +
> arch/arm/tools/syscall.tbl | 1 +
> arch/arm64/include/asm/unistd.h | 2 +-
> arch/arm64/include/asm/unistd32.h | 2 +
> arch/ia64/kernel/syscalls/syscall.tbl | 1 +
> arch/m68k/kernel/syscalls/syscall.tbl | 1 +
> arch/microblaze/kernel/syscalls/syscall.tbl | 1 +
> arch/mips/kernel/syscalls/syscall_n32.tbl | 1 +
> arch/mips/kernel/syscalls/syscall_n64.tbl | 1 +
> arch/parisc/kernel/syscalls/syscall.tbl | 1 +
> arch/powerpc/kernel/syscalls/syscall.tbl | 1 +
> arch/s390/kernel/syscalls/syscall.tbl | 1 +
> arch/sh/kernel/syscalls/syscall.tbl | 1 +
> arch/sparc/kernel/syscalls/syscall.tbl | 1 +
> arch/x86/entry/syscalls/syscall_32.tbl | 1 +
> arch/x86/entry/syscalls/syscall_64.tbl | 1 +
> arch/xtensa/kernel/syscalls/syscall.tbl | 1 +
> include/linux/pid.h | 1 +
> include/linux/syscalls.h | 3 +
> include/uapi/asm-generic/unistd.h | 5 +-
> kernel/exit.c | 17 --
> kernel/pid.c | 17 ++
> kernel/sys_ni.c | 1 +
> mm/madvise.c | 277 ++++++++++++++------
> 24 files changed, 238 insertions(+), 102 deletions(-)
>
> --
> 2.25.0.341.g760bfbb309-goog
>
prev parent reply other threads:[~2020-02-10 21:29 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-28 0:16 [PATCH v3 0/5] introduce memory hinting API for external process Minchan Kim
2020-01-28 0:16 ` [PATCH v3 1/5] mm: factor out madvise's core functionality Minchan Kim
2020-02-10 23:00 ` Alexander Duyck
2020-02-11 21:08 ` Minchan Kim
2020-01-28 0:16 ` [PATCH v3 2/5] mm: introduce external memory hinting API Minchan Kim
2020-02-10 17:50 ` Suren Baghdasaryan
2020-02-10 21:27 ` Minchan Kim
2020-01-28 0:16 ` [PATCH v3 3/5] mm/madvise: employ mmget_still_valid for write lock Minchan Kim
2020-01-28 0:16 ` [PATCH v3 4/5] mm/madvise: allow KSM hints for remote API Minchan Kim
2020-01-28 0:16 ` [PATCH v3 5/5] mm: support both pid and pidfd for process_madvise Minchan Kim
2020-02-10 23:12 ` Alexander Duyck
2020-02-11 21:11 ` Minchan Kim
2020-02-10 21:29 ` Minchan Kim [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200210212906.GB48790@google.com \
--to=minchan@kernel.org \
--cc=akpm@linux-foundation.org \
--cc=bgeffon@google.com \
--cc=dancol@google.com \
--cc=hannes@cmpxchg.org \
--cc=joaodias@google.com \
--cc=joel@joelfernandes.org \
--cc=linux-api@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mhocko@suse.com \
--cc=oleksandr@redhat.com \
--cc=shakeelb@google.com \
--cc=sonnyrao@google.com \
--cc=sspatil@google.com \
--cc=surenb@google.com \
--cc=timmurray@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).