linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH -next] staging: vc04_services: remove set but unused variable 'local_entity_uc'
@ 2020-02-11 13:43 YueHaibing
  2020-02-11 14:24 ` Dan Carpenter
  0 siblings, 1 reply; 3+ messages in thread
From: YueHaibing @ 2020-02-11 13:43 UTC (permalink / raw)
  To: nsaenzjulienne, gregkh, wahrenst, jamal.k.shareef, marcgonzalez,
	nishkadg.linux, nachukannan
  Cc: bcm-kernel-feedback-list, linux-rpi-kernel, linux-arm-kernel,
	devel, linux-kernel, YueHaibing

drivers/staging/vc04_services/interface/vchiq_arm/vchiq_arm.c: In function vchiq_use_internal:
drivers/staging/vc04_services/interface/vchiq_arm/vchiq_arm.c:2346:16:
 warning: variable local_entity_uc set but not used [-Wunused-but-set-variable]

commit bd8aa2850f00 ("staging: vc04_services: Get of even more suspend/resume states")
left behind this unused variable.

Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: YueHaibing <yuehaibing@huawei.com>
---
 drivers/staging/vc04_services/interface/vchiq_arm/vchiq_arm.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_arm.c b/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_arm.c
index c456ced..d30d24d 100644
--- a/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_arm.c
+++ b/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_arm.c
@@ -2343,7 +2343,7 @@ vchiq_use_internal(struct vchiq_state *state, struct vchiq_service *service,
 	enum vchiq_status ret = VCHIQ_SUCCESS;
 	char entity[16];
 	int *entity_uc;
-	int local_uc, local_entity_uc;
+	int local_uc;
 
 	if (!arm_state)
 		goto out;
@@ -2367,7 +2367,6 @@ vchiq_use_internal(struct vchiq_state *state, struct vchiq_service *service,
 
 	write_lock_bh(&arm_state->susp_res_lock);
 	local_uc = ++arm_state->videocore_use_count;
-	local_entity_uc = ++(*entity_uc);
 
 	vchiq_log_trace(vchiq_susp_log_level,
 		"%s %s count %d, state count %d",
-- 
2.7.4



^ permalink raw reply related	[flat|nested] 3+ messages in thread
* Re: [PATCH -next] staging: vc04_services: remove set but unused variable 'local_entity_uc'
  2020-02-11 13:43 [PATCH -next] staging: vc04_services: remove set but unused variable 'local_entity_uc' YueHaibing
@ 2020-02-11 14:24 ` Dan Carpenter
  2020-02-11 14:28   ` Yuehaibing
  0 siblings, 1 reply; 3+ messages in thread
From: Dan Carpenter @ 2020-02-11 14:24 UTC (permalink / raw)
  To: YueHaibing
  Cc: nsaenzjulienne, gregkh, wahrenst, jamal.k.shareef, marcgonzalez,
	nishkadg.linux, nachukannan, devel, linux-kernel,
	bcm-kernel-feedback-list, linux-rpi-kernel, linux-arm-kernel

On Tue, Feb 11, 2020 at 09:43:56PM +0800, YueHaibing wrote:
> drivers/staging/vc04_services/interface/vchiq_arm/vchiq_arm.c: In function vchiq_use_internal:
> drivers/staging/vc04_services/interface/vchiq_arm/vchiq_arm.c:2346:16:
>  warning: variable local_entity_uc set but not used [-Wunused-but-set-variable]
> 
> commit bd8aa2850f00 ("staging: vc04_services: Get of even more suspend/resume states")
> left behind this unused variable.
> 
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Signed-off-by: YueHaibing <yuehaibing@huawei.com>
> ---
>  drivers/staging/vc04_services/interface/vchiq_arm/vchiq_arm.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_arm.c b/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_arm.c
> index c456ced..d30d24d 100644
> --- a/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_arm.c
> +++ b/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_arm.c
> @@ -2343,7 +2343,7 @@ vchiq_use_internal(struct vchiq_state *state, struct vchiq_service *service,
>  	enum vchiq_status ret = VCHIQ_SUCCESS;
>  	char entity[16];
>  	int *entity_uc;
> -	int local_uc, local_entity_uc;
> +	int local_uc;
>  
>  	if (!arm_state)
>  		goto out;
> @@ -2367,7 +2367,6 @@ vchiq_use_internal(struct vchiq_state *state, struct vchiq_service *service,
>  
>  	write_lock_bh(&arm_state->susp_res_lock);
>  	local_uc = ++arm_state->videocore_use_count;
> -	local_entity_uc = ++(*entity_uc);
                          ^^
This ++ is required.

regards,
dan carpenter


^ permalink raw reply	[flat|nested] 3+ messages in thread
* Re: [PATCH -next] staging: vc04_services: remove set but unused variable 'local_entity_uc'
  2020-02-11 14:24 ` Dan Carpenter
@ 2020-02-11 14:28   ` Yuehaibing
  0 siblings, 0 replies; 3+ messages in thread
From: Yuehaibing @ 2020-02-11 14:28 UTC (permalink / raw)
  To: Dan Carpenter
  Cc: nsaenzjulienne, gregkh, wahrenst, jamal.k.shareef, marcgonzalez,
	nishkadg.linux, nachukannan, devel, linux-kernel,
	bcm-kernel-feedback-list, linux-rpi-kernel, linux-arm-kernel

On 2020/2/11 22:24, Dan Carpenter wrote:
> On Tue, Feb 11, 2020 at 09:43:56PM +0800, YueHaibing wrote:
>> drivers/staging/vc04_services/interface/vchiq_arm/vchiq_arm.c: In function vchiq_use_internal:
>> drivers/staging/vc04_services/interface/vchiq_arm/vchiq_arm.c:2346:16:
>>  warning: variable local_entity_uc set but not used [-Wunused-but-set-variable]
>>
>> commit bd8aa2850f00 ("staging: vc04_services: Get of even more suspend/resume states")
>> left behind this unused variable.
>>
>> Reported-by: Hulk Robot <hulkci@huawei.com>
>> Signed-off-by: YueHaibing <yuehaibing@huawei.com>
>> ---
>>  drivers/staging/vc04_services/interface/vchiq_arm/vchiq_arm.c | 3 +--
>>  1 file changed, 1 insertion(+), 2 deletions(-)
>>
>> diff --git a/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_arm.c b/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_arm.c
>> index c456ced..d30d24d 100644
>> --- a/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_arm.c
>> +++ b/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_arm.c
>> @@ -2343,7 +2343,7 @@ vchiq_use_internal(struct vchiq_state *state, struct vchiq_service *service,
>>  	enum vchiq_status ret = VCHIQ_SUCCESS;
>>  	char entity[16];
>>  	int *entity_uc;
>> -	int local_uc, local_entity_uc;
>> +	int local_uc;
>>  
>>  	if (!arm_state)
>>  		goto out;
>> @@ -2367,7 +2367,6 @@ vchiq_use_internal(struct vchiq_state *state, struct vchiq_service *service,
>>  
>>  	write_lock_bh(&arm_state->susp_res_lock);
>>  	local_uc = ++arm_state->videocore_use_count;
>> -	local_entity_uc = ++(*entity_uc);
>                           ^^
> This ++ is required.

oops..., Thanks!

> 
> regards,
> dan carpenter
> 
> 
> .
> 


^ permalink raw reply	[flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-02-11 14:28 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-02-11 13:43 [PATCH -next] staging: vc04_services: remove set but unused variable 'local_entity_uc' YueHaibing
2020-02-11 14:24 ` Dan Carpenter
2020-02-11 14:28   ` Yuehaibing

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).