From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5290EC352A3 for ; Tue, 11 Feb 2020 15:57:10 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 27EF02086A for ; Tue, 11 Feb 2020 15:57:10 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729704AbgBKP5J (ORCPT ); Tue, 11 Feb 2020 10:57:09 -0500 Received: from mga17.intel.com ([192.55.52.151]:21681 "EHLO mga17.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728573AbgBKP5J (ORCPT ); Tue, 11 Feb 2020 10:57:09 -0500 X-Amp-Result: UNKNOWN X-Amp-Original-Verdict: FILE UNKNOWN X-Amp-File-Uploaded: False Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by fmsmga107.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 11 Feb 2020 07:57:08 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.70,428,1574150400"; d="scan'208";a="347300948" Received: from smile.fi.intel.com (HELO smile) ([10.237.68.40]) by fmsmga001.fm.intel.com with ESMTP; 11 Feb 2020 07:57:04 -0800 Received: from andy by smile with local (Exim 4.93) (envelope-from ) id 1j1XuM-000lwv-1b; Tue, 11 Feb 2020 17:57:06 +0200 Date: Tue, 11 Feb 2020 17:57:06 +0200 From: Andy Shevchenko To: Mika Westerberg Cc: Darren Hart , Lee Jones , Greg Kroah-Hartman , Thomas Gleixner , Ingo Molnar , Borislav Petkov , "H . Peter Anvin" , x86@kernel.org, Zha Qipeng , "David E . Box" , Guenter Roeck , Heikki Krogerus , Wim Van Sebroeck , platform-driver-x86@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v5 09/18] mfd: intel_soc_pmic: Add SCU IPC member to struct intel_soc_pmic Message-ID: <20200211155706.GH10400@smile.fi.intel.com> References: <20200211132603.73509-1-mika.westerberg@linux.intel.com> <20200211132603.73509-10-mika.westerberg@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200211132603.73509-10-mika.westerberg@linux.intel.com> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Feb 11, 2020 at 04:25:54PM +0300, Mika Westerberg wrote: > Both PMIC drivers (intel_soc_pmic_mrfld and intel_soc_pmic_bxtwc) will > be using this field going forward to access the SCU IPC instance. > > While there add kernel-doc for the intel_soc_pmic structure. > + * @irq_chip_data_pwrbtn: Chained IRQ chip data for the power button > + * @irq_chip_data_tmu: Chained IRQ chip data for the time management unit > + * @irq_chip_data_bcu: Chained IRQ chip data for the burst control unit > + * @irq_chip_data_adc: Chained IRQ chip data for the general purpose ADC > + * @irq_chip_data_chgr: Chained IRQ chip data for the external charger > + * @irq_chip_data_crit: Chained IRQ chip data for the critical event handler Perhaps capitalize the decoded abbreviation, e.g. general purpose ADC -> General Purpose ADC ? -- With Best Regards, Andy Shevchenko