From: Bjorn Andersson <bjorn.andersson@linaro.org>
To: Arun Kumar Neelakantam <aneela@codeaurora.org>
Cc: clew@codeaurora.org, Andy Gross <agross@kernel.org>,
"open list:ARM/QUALCOMM SUPPORT" <linux-arm-msm@vger.kernel.org>,
open list <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] soc: qcom: aoss: Read back before triggering the IRQ
Date: Tue, 11 Feb 2020 22:32:14 -0800 [thread overview]
Message-ID: <20200212063214.GP3948@builder> (raw)
In-Reply-To: <1579681454-1229-1-git-send-email-aneela@codeaurora.org>
On Wed 22 Jan 00:24 PST 2020, Arun Kumar Neelakantam wrote:
> In some device memory used by msm_qmp, there can be an early ack of a
> write to memory succeeding. This may cause the outgoing interrupt to be
> triggered before the msgram reflects the write.
>
> Add a readback to ensure the data is flushed to device memory before
> triggering the ipc interrupt.
>
> Signed-off-by: Arun Kumar Neelakantam <aneela@codeaurora.org>
Applied
Thanks,
Bjorn
> ---
> drivers/soc/qcom/qcom_aoss.c | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/drivers/soc/qcom/qcom_aoss.c b/drivers/soc/qcom/qcom_aoss.c
> index fe79661..f43a2e0 100644
> --- a/drivers/soc/qcom/qcom_aoss.c
> +++ b/drivers/soc/qcom/qcom_aoss.c
> @@ -225,6 +225,7 @@ static bool qmp_message_empty(struct qmp *qmp)
> static int qmp_send(struct qmp *qmp, const void *data, size_t len)
> {
> long time_left;
> + size_t tlen;
> int ret;
>
> if (WARN_ON(len + sizeof(u32) > qmp->size))
> @@ -239,6 +240,9 @@ static int qmp_send(struct qmp *qmp, const void *data, size_t len)
> __iowrite32_copy(qmp->msgram + qmp->offset + sizeof(u32),
> data, len / sizeof(u32));
> writel(len, qmp->msgram + qmp->offset);
> +
> + /* Read back len to confirm data written in message RAM */
> + tlen = readl(qmp->msgram + qmp->offset);
> qmp_kick(qmp);
>
> time_left = wait_event_interruptible_timeout(qmp->event,
> --
> 1.9.1
prev parent reply other threads:[~2020-02-12 6:32 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-22 8:24 [PATCH] soc: qcom: aoss: Read back before triggering the IRQ Arun Kumar Neelakantam
2020-02-12 6:32 ` Bjorn Andersson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200212063214.GP3948@builder \
--to=bjorn.andersson@linaro.org \
--cc=agross@kernel.org \
--cc=aneela@codeaurora.org \
--cc=clew@codeaurora.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).