linux-next: build warning after merge of the btrfs tree

linux-next: build warning after merge of the btrfs tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 517 bytes --]

Hi all,

After merging the btrfs tree, today's linux-next build (powerpc
ppc64_defconfig) produced this warning:

fs/btrfs/volumes.c: In function 'btrfs_scratch_superblocks':
fs/btrfs/volumes.c:7338:3: warning: ignoring return value of 'write_one_page', declared with attribute warn_unused_result [-Wunused-result]
 7338 |   write_one_page(page);
      |   ^~~~~~~~~~~~~~~~~~~~

Introduced by commit

  d19ec014a46b ("btrfs: use the page-cache for super block reading")

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: linux-next: build warning after merge of the btrfs tree

[David Sterba]

On Wed, Feb 12, 2020 at 09:10:28AM +1100, Stephen Rothwell wrote:
> Hi all,
> 
> After merging the btrfs tree, today's linux-next build (powerpc
> ppc64_defconfig) produced this warning:
> 
> fs/btrfs/volumes.c: In function 'btrfs_scratch_superblocks':
> fs/btrfs/volumes.c:7338:3: warning: ignoring return value of 'write_one_page', declared with attribute warn_unused_result [-Wunused-result]
>  7338 |   write_one_page(page);
>       |   ^~~~~~~~~~~~~~~~~~~~
> 
> Introduced by commit
> 
>   d19ec014a46b ("btrfs: use the page-cache for super block reading")

Known and fix is in the patchset revision that will be in the next
for-next branch update. Thanks.

Re: linux-next: build warning after merge of the btrfs tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 862 bytes --]

Hi David,

On Wed, 12 Feb 2020 17:03:41 +0100 David Sterba <dsterba@suse.cz> wrote:
>
> On Wed, Feb 12, 2020 at 09:10:28AM +1100, Stephen Rothwell wrote:
> > 
> > After merging the btrfs tree, today's linux-next build (powerpc
> > ppc64_defconfig) produced this warning:
> > 
> > fs/btrfs/volumes.c: In function 'btrfs_scratch_superblocks':
> > fs/btrfs/volumes.c:7338:3: warning: ignoring return value of 'write_one_page', declared with attribute warn_unused_result [-Wunused-result]
> >  7338 |   write_one_page(page);
> >       |   ^~~~~~~~~~~~~~~~~~~~
> > 
> > Introduced by commit
> > 
> >   d19ec014a46b ("btrfs: use the page-cache for super block reading")  
> 
> Known and fix is in the patchset revision that will be in the next
> for-next branch update. Thanks.

I am still getting that warning.

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

linux-next: build warning after merge of the btrfs tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 537 bytes --]

Hi all,

After merging the btrfs tree, today's linux-next build (powerpc
ppc64_defconfig) produced this warning:

fs/btrfs/free-space-cache.c: In function 'load_free_space_cache':
fs/btrfs/free-space-cache.c:929:31: warning: variable 'mapping' set but not used [-Wunused-but-set-variable]
  929 |         struct address_space *mapping;
      |                               ^~~~~~~

Introduced by commit

  22d85ab1af7d ("btrfs: Change the lockdep class of struct inode's invalidate_lock")

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: linux-next: build warning after merge of the btrfs tree

[David Sterba]

On Wed, Jan 27, 2021 at 10:18:31AM +1100, Stephen Rothwell wrote:
> Hi all,
> 
> After merging the btrfs tree, today's linux-next build (powerpc
> ppc64_defconfig) produced this warning:
> 
> fs/btrfs/space-info.c:1373: warning: Function parameter or member 'start_ns' not described in 'handle_reserve_ticket'
> fs/btrfs/space-info.c:1373: warning: Function parameter or member 'orig_bytes' not described in 'handle_reserve_ticket'
> 
> Introduced by commit
> 
>   cf61ceb78394 ("btrfs: add a trace point for reserve tickets")

Will be fixed in the next snapshot, thanks.

linux-next: build warning after merge of the btrfs tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 484 bytes --]

Hi all,

After merging the btrfs tree, today's linux-next build (powerpc
ppc64_defconfig) produced this warning:

fs/btrfs/space-info.c:1373: warning: Function parameter or member 'start_ns' not described in 'handle_reserve_ticket'
fs/btrfs/space-info.c:1373: warning: Function parameter or member 'orig_bytes' not described in 'handle_reserve_ticket'

Introduced by commit

  cf61ceb78394 ("btrfs: add a trace point for reserve tickets")

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

linux-next: build warning after merge of the btrfs tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 745 bytes --]

Hi all,

After merging the btrfs tree, today's linux-next build (powerpc
ppc64_defconfig) produced this warning:

fs/btrfs/volumes.c: In function 'btrfs_rm_dev_replace_free_srcdev':
fs/btrfs/volumes.c:2217:24: warning: unused variable 'fs_info' [-Wunused-variable]
 2217 |  struct btrfs_fs_info *fs_info = srcdev->fs_info;
      |                        ^~~~~~~

Introduced by commits

  2a6fac3ea9a1 ("btrfs: move btrfs_scratch_superblocks into btrfs_dev_replace_finishing")
  438ac6dd65ef ("btrfs: switch seed device to list api")

merged in commit

  76e6c55d5432 ("Merge branch 'ext/nikbor/seed-cleanups-v2' into for-next-next-v5.9-20200824")

which should have removed the declaration.

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: linux-next: build warning after merge of the btrfs tree

[David Sterba]

On Mon, Feb 24, 2020 at 09:57:35AM +1100, Stephen Rothwell wrote:
> Hi all,
> 
> After merging the btrfs tree, today's linux-next build (x86_64
> allmodconfig) produced this warning:
> 
> fs/btrfs/check-integrity.c: In function 'btrfsic_process_superblock_dev_mirror':
> fs/btrfs/check-integrity.c:916:9: warning: 'ret' may be used uninitialized in this function [-Wmaybe-uninitialized]
>   916 |  return ret;
>       |         ^~~
> 
> Introduced by commit
> 
>   5a03d907a555 ("btrfs: remove buffer_heads form super block mirror integrity checking")
> 
> I think this is not a false positive since ret is only assigned is a
> "goto out" is executed.

Yes that sounds correct, will be fixed in next update, thanks.

linux-next: build warning after merge of the btrfs tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 604 bytes --]

Hi all,

After merging the btrfs tree, today's linux-next build (x86_64
allmodconfig) produced this warning:

fs/btrfs/check-integrity.c: In function 'btrfsic_process_superblock_dev_mirror':
fs/btrfs/check-integrity.c:916:9: warning: 'ret' may be used uninitialized in this function [-Wmaybe-uninitialized]
  916 |  return ret;
      |         ^~~

Introduced by commit

  5a03d907a555 ("btrfs: remove buffer_heads form super block mirror integrity checking")

I think this is not a false positive since ret is only assigned is a
"goto out" is executed.

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]