From: "gregkh@linuxfoundation.org" <gregkh@linuxfoundation.org>
To: Vladimir Stankovic <vladimir.stankovic@displaylink.com>
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-usb@vger.kernel.org" <linux-usb@vger.kernel.org>,
Petar Kovacevic <petar.kovacevic@displaylink.com>,
Stefan Lugonjic <stefan.lugonjic@displaylink.com>,
Nikola Simic <nikola.simic@displaylink.com>,
Marko Miljkovic <marko.miljkovic@displaylink.com>
Subject: Re: [External] Re: [PATCH 1/1] usb: Add MA USB Host driver
Date: Wed, 12 Feb 2020 05:22:22 -0800 [thread overview]
Message-ID: <20200212132222.GD1789899@kroah.com> (raw)
In-Reply-To: <742e4af7-ad70-6607-62b0-81d11cd5b04e@displaylink.com>
On Wed, Feb 12, 2020 at 09:41:12AM +0000, Vladimir Stankovic wrote:
> On 11.2.20. 17:39, gregkh@linuxfoundation.org wrote:
> > On Tue, Feb 11, 2020 at 04:21:24PM +0000, Vladimir Stankovic wrote:
> >> 39 files changed, 8668 insertions(+)
> >
> > This is a bit hard, if not impossible, to review all in one huge patch.
> >
> > Can you resend this as a patch series, breaking it down into logical
> > chunks, like all other kernel patches have?
> >
> > Also, why so many individual files? For only 8k lines, 39 files seems
> > like a huge number.
> >
> > thanks,
> >
> > greg k-h
> >
> Will break it down into patch series and resend.
>
> In regards of the file count, our intention was to ease the
> troubleshooting efforts during development and have a clear separation
> between logical parts of MA-USB implementation (i.e data in/out, isoch
> in/out, etc.; each source file representing logical chunk).
Yeah, but at the very least, only have a single .h "internal" file, you
have whole files for just 1 or 2 function prototypes, that's totally
overkill.
Simple is good, you don't want to have to bounce around through multiple
files for a simple 8k line driver, that's not a good idea.
thanks,
greg k-h
next prev parent reply other threads:[~2020-02-12 13:22 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <VI1PR10MB1965B4B61D7A9808B2EA095591180@VI1PR10MB1965.EURPRD10.PROD.OUTLOOK.COM>
2020-02-11 16:21 ` [PATCH 1/1] usb: Add MA USB Host driver Vladimir Stankovic
2020-02-11 16:39 ` gregkh
2020-02-12 9:41 ` [External] " Vladimir Stankovic
2020-02-12 13:22 ` gregkh [this message]
2020-02-11 16:39 ` gregkh
2020-02-11 16:41 ` gregkh
2020-02-12 9:43 ` Vladimir Stankovic
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200212132222.GD1789899@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=marko.miljkovic@displaylink.com \
--cc=nikola.simic@displaylink.com \
--cc=petar.kovacevic@displaylink.com \
--cc=stefan.lugonjic@displaylink.com \
--cc=vladimir.stankovic@displaylink.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).