From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.6 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FAKE_REPLY_C,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 422A7C3B186 for ; Wed, 12 Feb 2020 14:01:31 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 193E020873 for ; Wed, 12 Feb 2020 14:01:31 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1581516091; bh=k9etYqQgRrkh7cyiZwIyrLs0t114fOpffvtkOo61KWY=; h=Date:From:To:Cc:Subject:In-Reply-To:List-ID:From; b=XgJxv6OpeShJR3eZW1491z4VqPPIKpJBkMDZ9JGPK65AV1PqB1G6EewmDeg7XoMvd +33LoYH04o3R6AduE+r1GtuX0qhs59XGUl95K76yWB4g6I977HYHX+R1KcFIhNRtdM SUa96MVX/dFbemOCA97ByRe0I9XL//OgU0/FBaJc= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728214AbgBLOBa (ORCPT ); Wed, 12 Feb 2020 09:01:30 -0500 Received: from mail.kernel.org ([198.145.29.99]:53054 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725887AbgBLOBa (ORCPT ); Wed, 12 Feb 2020 09:01:30 -0500 Received: from localhost (173-25-83-245.client.mchsi.com [173.25.83.245]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id EEEDB20658; Wed, 12 Feb 2020 14:01:28 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1581516089; bh=k9etYqQgRrkh7cyiZwIyrLs0t114fOpffvtkOo61KWY=; h=Date:From:To:Cc:Subject:In-Reply-To:From; b=EPX57e7K2CocHRjleSrYsOC4jcMI5oxr+HevHew+S+JLsugZIC+yBlaB/zNAvFapK UZKM6UR6vbTNWupREPcs7S6z357GJD+mZV4emsonCxc74ssTH9I3BK6QzchZrhXNXT P5IrxlIh5dph6VfbTvbebxGRjB9m1vimurMg3Zds= Date: Wed, 12 Feb 2020 08:01:28 -0600 From: Bjorn Helgaas To: Lad Prabhakar Cc: Rob Herring , Mark Rutland , Catalin Marinas , Will Deacon , Kishon Vijay Abraham I , Lorenzo Pieralisi , Arnd Bergmann , Greg Kroah-Hartman , Jingoo Han , Gustavo Pimentel , Marek Vasut , Yoshihiro Shimoda , Shawn Lin , Heiko Stuebner , Andrew Murray , linux-pci@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-renesas-soc@vger.kernel.org, linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, Lad Prabhakar Subject: Re: [PATCH v4 1/6] PCI: rcar: Preparation for adding endpoint support Message-ID: <20200212140127.GA127398@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200208183641.6674-2-prabhakar.mahadev-lad.rj@bp.renesas.com> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org To make the changelog from "git log --oneline" read nicely, the subject should begin with a verb, e.g., PCI: rcar: Move shareable code to a common file On Sat, Feb 08, 2020 at 06:36:36PM +0000, Lad Prabhakar wrote: > Prepare for adding endpoint support to rcar controller, there are no > functional changes with this patch, a common file is created so that > it can be shared with endpoint driver. This commit log doesn't tell us what this patch does. "Prepare" conveys no real information. It's a giant patch and it's difficult to verify that there's no functional change. I *think* what you did was move most of the #defines from pcie-rcar.c to pcie-rcar.h and most of the code from pcie-rcar.c to pcie-rcar-host.c. And in both case, these were strict *moves* without any changes. If that's the case, please say that explicitly in the commit log. That's good; thanks for making this a separate patch so it's not mingled with real changes. > Signed-off-by: Lad Prabhakar > --- > arch/arm64/configs/defconfig | 2 +- > drivers/pci/controller/Kconfig | 4 +- > drivers/pci/controller/Makefile | 2 +- > drivers/pci/controller/pcie-rcar-host.c | 1044 ++++++++++++++++++++++++++ > drivers/pci/controller/pcie-rcar.c | 1229 ++----------------------------- > drivers/pci/controller/pcie-rcar.h | 126 ++++ > 6 files changed, 1227 insertions(+), 1180 deletions(-) > create mode 100644 drivers/pci/controller/pcie-rcar-host.c > create mode 100644 drivers/pci/controller/pcie-rcar.h > > diff --git a/arch/arm64/configs/defconfig b/arch/arm64/configs/defconfig > index b2f6673..8a1f51d 100644 > --- a/arch/arm64/configs/defconfig > +++ b/arch/arm64/configs/defconfig > @@ -182,7 +182,7 @@ CONFIG_HOTPLUG_PCI=y > CONFIG_HOTPLUG_PCI_ACPI=y > CONFIG_PCI_AARDVARK=y > CONFIG_PCI_TEGRA=y > -CONFIG_PCIE_RCAR=y > +CONFIG_PCIE_RCAR_HOST=y > CONFIG_PCI_HOST_GENERIC=y > CONFIG_PCI_XGENE=y > CONFIG_PCIE_ALTERA=y > diff --git a/drivers/pci/controller/Kconfig b/drivers/pci/controller/Kconfig > index f84e5ff..94bb5e9 100644 > --- a/drivers/pci/controller/Kconfig > +++ b/drivers/pci/controller/Kconfig > @@ -54,12 +54,12 @@ config PCI_RCAR_GEN2 > There are 3 internal PCI controllers available with a single > built-in EHCI/OHCI host controller present on each one. > > -config PCIE_RCAR > +config PCIE_RCAR_HOST The config symbol change should be mentioned in the commit log. In general we try to avoid changing config symbols because it's likely to confuse people who keep their .config and update their kernel. But I guess your audience is probably pretty small. > bool "Renesas R-Car PCIe controller" The description needs to be updated, too. This is what people will see in menuconfig. > depends on ARCH_RENESAS || COMPILE_TEST > depends on PCI_MSI_IRQ_DOMAIN > help > - Say Y here if you want PCIe controller support on R-Car SoCs. > + Say Y here if you want PCIe controller support on R-Car SoCs in host mode. Wrap this so it fits in 80 columns like the rest of the file. Bjorn