From: Dan Carpenter <dan.carpenter@oracle.com>
To: Kaaira Gupta <kgupta@es.iitr.ac.in>
Cc: devel@driverdev.osuosl.org, gregkh@linuxfoundation.org,
linux-kernel@vger.kernel.org,
Julia Lawall <julia.lawall@inria.fr>,
Rob Springer <rspringer@google.com>,
Todd Poynor <toddpoynor@google.com>
Subject: Re: [PATCH v2] staging:gasket:gasket_core.c:unified quoted string split across lines in one line
Date: Wed, 12 Feb 2020 17:49:33 +0300 [thread overview]
Message-ID: <20200212144933.GJ1778@kadam> (raw)
In-Reply-To: <20200212144424.GI1778@kadam>
On Wed, Feb 12, 2020 at 05:44:24PM +0300, Dan Carpenter wrote:
> On Wed, Feb 12, 2020 at 05:20:35PM +0530, Kaaira Gupta wrote:
> > When the driver tries to map a region, but the region has certain
> > permissions, or when it attempts to open gasket with tgid, or when it
> > realeases device node;
>
> We don't care about any of this information...
>
> > the logs are displayed in one line only while the
> > code has the strings split in two lines which makes it difficult for
> > developers to search for code based on the log messages. So, this patch
> > fixes three warnings of 'quoted string split across lines' in
> > gasket_core.c by merging the strings in one line.
Another perfectly adequate commit message would be:
Fix three checkpatch.pl warnings of 'quoted string split across lines'
in gasket_core.c by merging the strings in one line.
Which is imperative. :) Hooray!
regards,
dan carpenter
prev parent reply other threads:[~2020-02-12 14:49 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20200211200456.GA10351@kaaira-HP-Pavilion-Notebook>
[not found] ` <alpine.DEB.2.21.2002112139550.3266@hadrien>
2020-02-12 11:50 ` Kaaira Gupta
2020-02-12 14:44 ` Dan Carpenter
2020-02-12 14:49 ` Dan Carpenter [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200212144933.GJ1778@kadam \
--to=dan.carpenter@oracle.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=julia.lawall@inria.fr \
--cc=kgupta@es.iitr.ac.in \
--cc=linux-kernel@vger.kernel.org \
--cc=rspringer@google.com \
--cc=toddpoynor@google.com \
--subject='Re: [PATCH v2] staging:gasket:gasket_core.c:unified quoted string split across lines in one line' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).