From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.6 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9C3CBC3B186 for ; Wed, 12 Feb 2020 16:18:10 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 7484920714 for ; Wed, 12 Feb 2020 16:18:10 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="key not found in DNS" (0-bit key) header.d=mg.codeaurora.org header.i=@mg.codeaurora.org header.b="urBVcOWf" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728708AbgBLQSI (ORCPT ); Wed, 12 Feb 2020 11:18:08 -0500 Received: from mail26.static.mailgun.info ([104.130.122.26]:39980 "EHLO mail26.static.mailgun.info" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728645AbgBLQSG (ORCPT ); Wed, 12 Feb 2020 11:18:06 -0500 DKIM-Signature: a=rsa-sha256; v=1; c=relaxed/relaxed; d=mg.codeaurora.org; q=dns/txt; s=smtp; t=1581524286; h=Date: Message-Id: Cc: To: References: In-Reply-To: From: Subject: Content-Transfer-Encoding: MIME-Version: Content-Type: Sender; bh=8s1WzLOWb+AoZJksEERSbSfmDvAs4ADMWJjK4sRp03g=; b=urBVcOWfjlkMC1FO4sZ2CwgGBN2TA6Ohw0zzUpNxNjQXO7VgGmu4IvCP6PEATTiUWqxtKYFP O+CnsI4fkbzzG3sE0RLeI9b1wo2OejAjm2oa7nfu8ijZgt9icBV435VBAY+5DlltNplcA25u ojQSvaKEulqxfwA69v76d57/2ZE= X-Mailgun-Sending-Ip: 104.130.122.26 X-Mailgun-Sid: WyI0MWYwYSIsICJsaW51eC1rZXJuZWxAdmdlci5rZXJuZWwub3JnIiwgImJlOWU0YSJd Received: from smtp.codeaurora.org (ec2-35-166-182-171.us-west-2.compute.amazonaws.com [35.166.182.171]) by mxa.mailgun.org with ESMTP id 5e44253d.7fbef56473e8-smtp-out-n01; Wed, 12 Feb 2020 16:18:05 -0000 (UTC) Received: by smtp.codeaurora.org (Postfix, from userid 1001) id 1909DC43383; Wed, 12 Feb 2020 16:18:04 +0000 (UTC) Received: from potku.adurom.net (88-114-240-156.elisa-laajakaista.fi [88.114.240.156]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: kvalo) by smtp.codeaurora.org (Postfix) with ESMTPSA id 14222C43383; Wed, 12 Feb 2020 16:17:59 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org 14222C43383 Authentication-Results: aws-us-west-2-caf-mail-1.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: aws-us-west-2-caf-mail-1.web.codeaurora.org; spf=none smtp.mailfrom=kvalo@codeaurora.org Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: Re: [PATCH] brcmfmac: abort and release host after error From: Kalle Valo In-Reply-To: <20200128221457.12467-1-linux@roeck-us.net> References: <20200128221457.12467-1-linux@roeck-us.net> To: Guenter Roeck Cc: Arend van Spriel , Franky Lin , Hante Meuleman , Chi-Hsien Lin , Dan Carpenter , linux-wireless@vger.kernel.org, brcm80211-dev-list.pdl@broadcom.com, brcm80211-dev-list@cypress.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Guenter Roeck , Matthias Kaehlcke , Brian Norris , Douglas Anderson User-Agent: pwcli/0.0.0-git (https://github.com/kvalo/pwcli/) Python/2.7.12 Message-Id: <20200212161804.1909DC43383@smtp.codeaurora.org> Date: Wed, 12 Feb 2020 16:18:04 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Guenter Roeck wrote: > With commit 216b44000ada ("brcmfmac: Fix use after free in > brcmf_sdio_readframes()") applied, we see locking timeouts in > brcmf_sdio_watchdog_thread(). > > brcmfmac: brcmf_escan_timeout: timer expired > INFO: task brcmf_wdog/mmc1:621 blocked for more than 120 seconds. > Not tainted 4.19.94-07984-g24ff99a0f713 #1 > "echo 0 > /proc/sys/kernel/hung_task_timeout_secs" disables this message. > brcmf_wdog/mmc1 D 0 621 2 0x00000000 last_sleep: 2440793077. last_runnable: 2440766827 > [] (__schedule) from [] (schedule+0x98/0xc4) > [] (schedule) from [] (__mmc_claim_host+0x154/0x274) > [] (__mmc_claim_host) from [] (brcmf_sdio_watchdog_thread+0x1b0/0x1f8 [brcmfmac]) > [] (brcmf_sdio_watchdog_thread [brcmfmac]) from [] (kthread+0x178/0x180) > > In addition to restarting or exiting the loop, it is also necessary to > abort the command and to release the host. > > Fixes: 216b44000ada ("brcmfmac: Fix use after free in brcmf_sdio_readframes()") > Cc: Dan Carpenter > Cc: Matthias Kaehlcke > Cc: Brian Norris > Cc: Douglas Anderson > Signed-off-by: Guenter Roeck > Reviewed-by: Douglas Anderson > Acked-by: franky.lin@broadcom.com > Acked-by: Dan Carpenter Patch applied to wireless-drivers-next.git, thanks. 863844ee3bd3 brcmfmac: abort and release host after error -- https://patchwork.kernel.org/patch/11355277/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches