From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.1 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C6EA1C352A4 for ; Wed, 12 Feb 2020 22:46:59 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 98D6320848 for ; Wed, 12 Feb 2020 22:46:59 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="PFFtJaHK" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729186AbgBLWq6 (ORCPT ); Wed, 12 Feb 2020 17:46:58 -0500 Received: from mail-lj1-f193.google.com ([209.85.208.193]:42052 "EHLO mail-lj1-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727692AbgBLWq6 (ORCPT ); Wed, 12 Feb 2020 17:46:58 -0500 Received: by mail-lj1-f193.google.com with SMTP id d10so4277509ljl.9 for ; Wed, 12 Feb 2020 14:46:56 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=jrYNxcmAESHKexGAddHOv9wtAKXJzgWh89e239PGRQo=; b=PFFtJaHKIrNlUKS6NsRZWetgbbjhBlkI0g7tnl2WGU5kaUqi+zNun/iNdoK/DEDDiS HNkQw6hvXdwZihxbQefigPoLmceiAnmLwudOExlfolrXpKRtXYlySM+UthcT1qsmvcW/ zbuCIaL+5o+Ap8LUBQHJ5+Xp+LEU2psM35r/B68UVaY+CMkXphIpRo3a3FgszEnO2dsf yWVpHOk5hKgOE+XnVzmh4Bv26YqiKa6cn6T0wDFLu6ZUnh5lg9aVjSNs/Ic7RI4Mpj9I Izlj168dzT7UUt+SpupM16uiM260AIE494w59HZJZTa6fTgWRVmatKFAYvMqLwd/2GKr duBw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=jrYNxcmAESHKexGAddHOv9wtAKXJzgWh89e239PGRQo=; b=skLPBi6Bho1ucwtwXUgdZ5/a2MR8xFd26DjUaoeTMDOHZB0lLbsr4z1Oz07ZrcMPwX BMckSiVKxvboV7DoHeMb+PT1lnyoo8L4LbKWyyxAFDcPOvlPuNGG0bIcGrqPY95jysoT tLWolY6ENN2ziv+j6g13oEiMWOsOLm4/AA5rkfKIR3EJaltqVuQ+Bnt7N+pgLYvsSSeT 2mYkBvYfsxrFVaXeeFR5IL8A2PGXf3ISx635Fxg3pR6L5h2iQReyLRzfQJRhd6Eq2bix d+rFmITtAPKwDuZQJYwXn7TKjFthdA3hmo5dlQThAt1omnBVQyO6IMqp9dZvmNsfALK2 MkEQ== X-Gm-Message-State: APjAAAWnPRuDXQoxtlS0o+mxw1tLLEuMGVjll2mu9esxE9nCUy+mMAg/ 225S7sxXmcAVOusyyI3O0KM= X-Google-Smtp-Source: APXvYqybqDLRJg2IrAK1fX24sksSPwXxUp90d3598YjdvkPi0K1jiArVzSr4wzrM3vq8gpEnprObzw== X-Received: by 2002:a2e:7818:: with SMTP id t24mr8865749ljc.195.1581547615958; Wed, 12 Feb 2020 14:46:55 -0800 (PST) Received: from kedthinkpad ([5.20.204.163]) by smtp.gmail.com with ESMTPSA id v7sm257086ljd.12.2020.02.12.14.46.54 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 12 Feb 2020 14:46:55 -0800 (PST) Date: Thu, 13 Feb 2020 00:46:53 +0200 From: Andrey Lebedev To: Maxime Ripard Cc: wens@csie.org, airlied@linux.ie, daniel@ffwll.ch, dri-devel@lists.freedesktop.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 1/1] Support LVDS output on Allwinner A20 Message-ID: <20200212224653.GA19494@kedthinkpad> References: <20200210195633.GA21832@kedthinkpad> <20200211072004.46tbqixn5ftilxae@gilmour.lan> <20200211204828.GA4361@kedthinkpad> <20200212125345.j6e3txfjqekuxh2s@gilmour.lan> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200212125345.j6e3txfjqekuxh2s@gilmour.lan> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Feb 12, 2020 at 01:53:45PM +0100, Maxime Ripard wrote: > > > Side question, this will need some DT changes too, right? > > > > Hm, I agree. I think it would be reasonable to include LVDS0/1 pins > > That, but most importantly, the reset and clocks for the LVDS > block. Also from looking at it, I'm not entirely sure that the TCON1 > has a LVDS output I also have impression that LVDS is only supported on TCON0, but that's mostly from this comment in sun4i_lvds.c: /* The LVDS encoder can only work with the TCON channel 0 */ > do you have a board when you have been able to test it? Yes, I have the hardware (Cubieboard 2) at hand, but I cannot change the any physical connections on it. FWIW, it is https://openvario.org, the device we are (painfully) trying to upgrade from old kernel-3.4 with proprietary mali drivers to contemporary software. > > and sample (but disabled) lvds panel, > > That's good for the sake of the example, but it shouldn't be in the > same patch, it won't be merged. I jave just submitted version 2 of the patches - set of 2 patches this time. Addressed your comments, please take a look. -- Andrey Lebedev aka -.- . -.. -.. . .-. Software engineer Homepage: http://lebedev.lt/