From: Tejun Heo <tj@kernel.org>
To: "Michal Koutný" <mkoutny@suse.com>
Cc: cgroups@vger.kernel.org, Li Zefan <lizefan@huawei.com>,
Johannes Weiner <hannes@cmpxchg.org>,
Aleksa Sarai <cyphar@cyphar.com>,
linux-kernel@vger.kernel.org
Subject: Re: [RFC PATCH v2 1/3] cgroup/pids: Separate semantics of pids.events related to pids.max
Date: Wed, 12 Feb 2020 18:03:07 -0500 [thread overview]
Message-ID: <20200212230307.GB88887@mtj.thefacebook.com> (raw)
In-Reply-To: <20200205134426.10570-2-mkoutny@suse.com>
On Wed, Feb 05, 2020 at 02:44:24PM +0100, Michal Koutný wrote:
> Currently, when pids.max limit is breached in the hierarchy, the event
> is counted and reported in the cgroup where the forking task resides.
>
> This decouples the limit and the notification caused by the limit making
> it hard to detect when the actual limit was effected.
>
> Let's introduce new events:
> max
> The number of times the limit of the cgroup was hit.
>
> max.imposed
> The number of times fork failed in the cgroup because of self
> or ancestor limit.
Can you please follow the same convention as memory.events and
memory.events.local?
Thanks.
--
tejun
next prev parent reply other threads:[~2020-02-12 23:03 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-28 17:26 [RFC PATCH] cgroup/pids: Make pids.events notifications affine to pids.max Michal Koutný
2019-12-02 19:11 ` Tejun Heo
2020-02-05 13:44 ` [RFC PATCH v2 0/3] " Michal Koutný
2020-02-05 13:44 ` [RFC PATCH v2 1/3] cgroup/pids: Separate semantics of pids.events related " Michal Koutný
2020-02-12 23:03 ` Tejun Heo [this message]
2020-02-05 13:44 ` [RFC PATCH v2 2/3] cgroup/pids: Make event counters hierarchical Michal Koutný
2020-02-05 13:44 ` [RFC PATCH v2 3/3] selftests: cgroup: Add basic tests for pids controller Michal Koutný
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200212230307.GB88887@mtj.thefacebook.com \
--to=tj@kernel.org \
--cc=cgroups@vger.kernel.org \
--cc=cyphar@cyphar.com \
--cc=hannes@cmpxchg.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lizefan@huawei.com \
--cc=mkoutny@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).